From: "Ye, Tony" <tony.ye@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
Date: Sun, 24 Mar 2019 21:02:15 +0800 [thread overview]
Message-ID: <a5ee5328-5535-e40a-a742-194a2b65235e@intel.com> (raw)
In-Reply-To: <f7e55e11-a556-e6a9-70b4-083fdc91b97d@linux.intel.com>
The kernel was design for Gen11 and the author didn't guarantee it could
work on APL. And the binary was built with iga64 with "-p=11" option. If
you try to build it with "-p=9" you will get "error: NoPreempt not
supported on given platform".
As the purpose of this test was to test the asymmetric subslice of
Gen11, I would suggest to remove the support of Gen9 and Gen10. The
patch looks good to me.
Regards,
Tony
On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>
> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Do not use it on older gens.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>
> Regards,
>
> Tvrtko
>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>> lib/intel_batchbuffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index b2169a1aa145..6e6bcdeba8a6 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>> {
>> igt_vme_func_t fill = NULL;
>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>> + if (IS_GEN11(devid))
>> fill = gen11_media_vme_func;
>> return fill;
>>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
WARNING: multiple messages have this Message-ID (diff)
From: "Ye, Tony" <tony.ye@intel.com>
To: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
igt-dev@lists.freedesktop.org
Cc: Intel-gfx@lists.freedesktop.org,
Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Subject: Re: [igt-dev] [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11
Date: Sun, 24 Mar 2019 21:02:15 +0800 [thread overview]
Message-ID: <a5ee5328-5535-e40a-a742-194a2b65235e@intel.com> (raw)
In-Reply-To: <f7e55e11-a556-e6a9-70b4-083fdc91b97d@linux.intel.com>
The kernel was design for Gen11 and the author didn't guarantee it could
work on APL. And the binary was built with iga64 with "-p=11" option. If
you try to build it with "-p=9" you will get "error: NoPreempt not
supported on given platform".
As the purpose of this test was to test the asymmetric subslice of
Gen11, I would suggest to remove the support of Gen9 and Gen10. The
patch looks good to me.
Regards,
Tony
On 2/25/2019 7:57 PM, Tvrtko Ursulin wrote:
>
> On 25/02/2019 11:55, Tvrtko Ursulin wrote:
>> From: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>>
>> Do not use it on older gens.
>>
>> Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
>
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=109612
>
> Regards,
>
> Tvrtko
>
>> Cc: Tony Ye <tony.ye@intel.com>
>> ---
>> lib/intel_batchbuffer.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
>> index b2169a1aa145..6e6bcdeba8a6 100644
>> --- a/lib/intel_batchbuffer.c
>> +++ b/lib/intel_batchbuffer.c
>> @@ -877,7 +877,7 @@ igt_vme_func_t igt_get_media_vme_func(int devid)
>> {
>> igt_vme_func_t fill = NULL;
>> - if (IS_GEN9(devid) || IS_GEN10(devid) || IS_GEN11(devid))
>> + if (IS_GEN11(devid))
>> fill = gen11_media_vme_func;
>> return fill;
>>
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev
next prev parent reply other threads:[~2019-03-24 13:02 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-25 11:55 [PATCH i-g-t] lib/intel_batchbuffer: Media VME kernel is valid only for Gen11 Tvrtko Ursulin
2019-02-25 11:55 ` [igt-dev] " Tvrtko Ursulin
2019-02-25 11:57 ` Tvrtko Ursulin
2019-02-25 11:57 ` Tvrtko Ursulin
2019-03-24 13:02 ` Ye, Tony [this message]
2019-03-24 13:02 ` Ye, Tony
2019-03-25 10:22 ` Tvrtko Ursulin
2019-03-25 10:22 ` Tvrtko Ursulin
2019-03-25 16:58 ` Ye, Tony
2019-03-25 16:58 ` Ye, Tony
2019-02-25 12:59 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2019-02-25 16:16 ` [igt-dev] ✗ Fi.CI.IGT: failure " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a5ee5328-5535-e40a-a742-194a2b65235e@intel.com \
--to=tony.ye@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=igt-dev@lists.freedesktop.org \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.