Re: [PATCH v5 01/15] landlock: access mask renaming

From: "Mickaël Salaün" <mic@digikod.net>
To: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
Cc: willemdebruijn.kernel@gmail.com,
	linux-security-module@vger.kernel.org, netdev@vger.kernel.org,
	netfilter-devel@vger.kernel.org, yusongping@huawei.com,
	anton.sirazetdinov@huawei.com
Subject: Re: [PATCH v5 01/15] landlock: access mask renaming
Date: Tue, 17 May 2022 10:12:33 +0200	[thread overview]
Message-ID: <a6300c07-87f5-21a4-8998-facbecd63787@digikod.net> (raw)
In-Reply-To: <20220516152038.39594-2-konstantin.meskhidze@huawei.com>

On 16/05/2022 17:20, Konstantin Meskhidze wrote:
> Currently Landlock supports filesystem
> restrictions. To support network type rules,
> this modification extends and renames
> ruleset's access masks.
> This patch adds filesystem helper functions
> to set and get filesystem mask. Also the modification
> adds a helper structure landlock_access_mask to
> support managing multiple access mask.
> 
> Signed-off-by: Konstantin Meskhidze <konstantin.meskhidze@huawei.com>
> ---

[...]

> diff --git a/security/landlock/ruleset.h b/security/landlock/ruleset.h
> index d43231b783e4..f27a79624962 100644
> --- a/security/landlock/ruleset.h
> +++ b/security/landlock/ruleset.h
> @@ -20,6 +20,7 @@
>   #include "object.h"
> 
>   typedef u16 access_mask_t;
> +
>   /* Makes sure all filesystem access rights can be stored. */

Please don't add whitespaces.