* [PATCH net] sfc: Fix error code in probe
@ 2020-09-18 14:33 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-09-18 14:33 UTC (permalink / raw)
To: Solarflare linux maintainers
Cc: Edward Cree, Martin Habets, David S. Miller, Jakub Kicinski,
netdev, kernel-janitors
This failure path should return a negative error code but it currently
returns success.
Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/sfc/ef100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c
index c54b7f8243f3..ffdb36715a49 100644
--- a/drivers/net/ethernet/sfc/ef100.c
+++ b/drivers/net/ethernet/sfc/ef100.c
@@ -490,6 +490,7 @@ static int ef100_pci_probe(struct pci_dev *pci_dev,
if (fcw.offset > pci_resource_len(efx->pci_dev, fcw.bar) - ESE_GZ_FCW_LEN) {
netif_err(efx, probe, efx->net_dev,
"Func control window overruns BAR\n");
+ rc = -EIO;
goto fail;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH net] sfc: Fix error code in probe
@ 2020-09-18 14:33 ` Dan Carpenter
0 siblings, 0 replies; 6+ messages in thread
From: Dan Carpenter @ 2020-09-18 14:33 UTC (permalink / raw)
To: Solarflare linux maintainers
Cc: Edward Cree, Martin Habets, David S. Miller, Jakub Kicinski,
netdev, kernel-janitors
This failure path should return a negative error code but it currently
returns success.
Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/net/ethernet/sfc/ef100.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/sfc/ef100.c b/drivers/net/ethernet/sfc/ef100.c
index c54b7f8243f3..ffdb36715a49 100644
--- a/drivers/net/ethernet/sfc/ef100.c
+++ b/drivers/net/ethernet/sfc/ef100.c
@@ -490,6 +490,7 @@ static int ef100_pci_probe(struct pci_dev *pci_dev,
if (fcw.offset > pci_resource_len(efx->pci_dev, fcw.bar) - ESE_GZ_FCW_LEN) {
netif_err(efx, probe, efx->net_dev,
"Func control window overruns BAR\n");
+ rc = -EIO;
goto fail;
}
--
2.28.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH net] sfc: Fix error code in probe
2020-09-18 14:33 ` Dan Carpenter
@ 2020-09-21 11:09 ` Edward Cree
-1 siblings, 0 replies; 6+ messages in thread
From: Edward Cree @ 2020-09-21 11:09 UTC (permalink / raw)
To: Dan Carpenter, Solarflare linux maintainers
Cc: Martin Habets, David S. Miller, Jakub Kicinski, netdev, kernel-janitors
On 18/09/2020 15:33, Dan Carpenter wrote:
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Edward Cree <ecree@solarflare.com>
Thanks for catching this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] sfc: Fix error code in probe
@ 2020-09-21 11:09 ` Edward Cree
0 siblings, 0 replies; 6+ messages in thread
From: Edward Cree @ 2020-09-21 11:09 UTC (permalink / raw)
To: Dan Carpenter, Solarflare linux maintainers
Cc: Martin Habets, David S. Miller, Jakub Kicinski, netdev, kernel-janitors
On 18/09/2020 15:33, Dan Carpenter wrote:
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Edward Cree <ecree@solarflare.com>
Thanks for catching this.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] sfc: Fix error code in probe
2020-09-18 14:33 ` Dan Carpenter
@ 2020-09-21 20:55 ` David Miller
-1 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-09-21 20:55 UTC (permalink / raw)
To: dan.carpenter
Cc: linux-net-drivers, ecree, mhabets, kuba, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 18 Sep 2020 17:33:11 +0300
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net] sfc: Fix error code in probe
@ 2020-09-21 20:55 ` David Miller
0 siblings, 0 replies; 6+ messages in thread
From: David Miller @ 2020-09-21 20:55 UTC (permalink / raw)
To: dan.carpenter
Cc: linux-net-drivers, ecree, mhabets, kuba, netdev, kernel-janitors
From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Fri, 18 Sep 2020 17:33:11 +0300
> This failure path should return a negative error code but it currently
> returns success.
>
> Fixes: 51b35a454efd ("sfc: skeleton EF100 PF driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thanks.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-21 20:55 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-18 14:33 [PATCH net] sfc: Fix error code in probe Dan Carpenter
2020-09-18 14:33 ` Dan Carpenter
2020-09-21 11:09 ` Edward Cree
2020-09-21 11:09 ` Edward Cree
2020-09-21 20:55 ` David Miller
2020-09-21 20:55 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.