* [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup
@ 2021-04-13 8:15 Lorenzo Bianconi
2021-04-13 8:27 ` Lorenzo Bianconi
0 siblings, 1 reply; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-04-13 8:15 UTC (permalink / raw)
To: nbd; +Cc: linux-wireless, lorenzo.bianconi, sean.wang
Remove mt7921_dma_cleanup routine since it is no longer used
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
---
.../net/wireless/mediatek/mt76/mt7921/dma.c | 23 -------------------
.../wireless/mediatek/mt76/mt7921/mt7921.h | 1 -
2 files changed, 24 deletions(-)
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
index 992faf82ad09..14e694563a89 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
@@ -331,26 +331,3 @@ int mt7921_dma_init(struct mt7921_dev *dev)
return 0;
}
-
-void mt7921_dma_cleanup(struct mt7921_dev *dev)
-{
- /* disable */
- mt76_clear(dev, MT_WFDMA0_GLO_CFG,
- MT_WFDMA0_GLO_CFG_TX_DMA_EN |
- MT_WFDMA0_GLO_CFG_RX_DMA_EN |
- MT_WFDMA0_GLO_CFG_CSR_DISP_BASE_PTR_CHAIN_EN |
- MT_WFDMA0_GLO_CFG_OMIT_TX_INFO |
- MT_WFDMA0_GLO_CFG_OMIT_RX_INFO |
- MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2);
-
- /* reset */
- mt76_clear(dev, MT_WFDMA0_RST,
- MT_WFDMA0_RST_DMASHDL_ALL_RST |
- MT_WFDMA0_RST_LOGIC_RST);
-
- mt76_set(dev, MT_WFDMA0_RST,
- MT_WFDMA0_RST_DMASHDL_ALL_RST |
- MT_WFDMA0_RST_LOGIC_RST);
-
- mt76_dma_cleanup(&dev->mt76);
-}
diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
index e3d83d3d954c..1e70c749bbf3 100644
--- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
+++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
@@ -225,7 +225,6 @@ int mt7921_eeprom_get_target_power(struct mt7921_dev *dev,
void mt7921_eeprom_init_sku(struct mt7921_dev *dev);
int mt7921_dma_init(struct mt7921_dev *dev);
void mt7921_dma_prefetch(struct mt7921_dev *dev);
-void mt7921_dma_cleanup(struct mt7921_dev *dev);
int mt7921_run_firmware(struct mt7921_dev *dev);
int mt7921_mcu_init(struct mt7921_dev *dev);
int mt7921_mcu_add_bss_info(struct mt7921_phy *phy,
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup
2021-04-13 8:15 [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup Lorenzo Bianconi
@ 2021-04-13 8:27 ` Lorenzo Bianconi
0 siblings, 0 replies; 2+ messages in thread
From: Lorenzo Bianconi @ 2021-04-13 8:27 UTC (permalink / raw)
To: Lorenzo Bianconi; +Cc: nbd, linux-wireless, sean.wang
[-- Attachment #1: Type: text/plain, Size: 2219 bytes --]
> Remove mt7921_dma_cleanup routine since it is no longer used
>
> Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
> ---
> .../net/wireless/mediatek/mt76/mt7921/dma.c | 23 -------------------
> .../wireless/mediatek/mt76/mt7921/mt7921.h | 1 -
> 2 files changed, 24 deletions(-)
Hi Felix,
please ignore this patch, we need mt7921_dma_cleanup unloading the module.
Regards,
Lorenzo
>
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> index 992faf82ad09..14e694563a89 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/dma.c
> @@ -331,26 +331,3 @@ int mt7921_dma_init(struct mt7921_dev *dev)
>
> return 0;
> }
> -
> -void mt7921_dma_cleanup(struct mt7921_dev *dev)
> -{
> - /* disable */
> - mt76_clear(dev, MT_WFDMA0_GLO_CFG,
> - MT_WFDMA0_GLO_CFG_TX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_RX_DMA_EN |
> - MT_WFDMA0_GLO_CFG_CSR_DISP_BASE_PTR_CHAIN_EN |
> - MT_WFDMA0_GLO_CFG_OMIT_TX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO |
> - MT_WFDMA0_GLO_CFG_OMIT_RX_INFO_PFET2);
> -
> - /* reset */
> - mt76_clear(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_set(dev, MT_WFDMA0_RST,
> - MT_WFDMA0_RST_DMASHDL_ALL_RST |
> - MT_WFDMA0_RST_LOGIC_RST);
> -
> - mt76_dma_cleanup(&dev->mt76);
> -}
> diff --git a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> index e3d83d3d954c..1e70c749bbf3 100644
> --- a/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> +++ b/drivers/net/wireless/mediatek/mt76/mt7921/mt7921.h
> @@ -225,7 +225,6 @@ int mt7921_eeprom_get_target_power(struct mt7921_dev *dev,
> void mt7921_eeprom_init_sku(struct mt7921_dev *dev);
> int mt7921_dma_init(struct mt7921_dev *dev);
> void mt7921_dma_prefetch(struct mt7921_dev *dev);
> -void mt7921_dma_cleanup(struct mt7921_dev *dev);
> int mt7921_run_firmware(struct mt7921_dev *dev);
> int mt7921_mcu_init(struct mt7921_dev *dev);
> int mt7921_mcu_add_bss_info(struct mt7921_phy *phy,
> --
> 2.30.2
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-13 8:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-04-13 8:15 [PATCH] mt76: mt7921: get rid of mt7921_dma_cleanup Lorenzo Bianconi
2021-04-13 8:27 ` Lorenzo Bianconi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.