From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>
Subject: Re: [alsa-devel] [PATCH] ASoC: adav80x: mark expected switch fall-through
Date: Thu, 9 Aug 2018 13:23:58 +0200 [thread overview]
Message-ID: <a68c854c-013a-8cb2-49de-5bb109b27fc3@metafoo.de> (raw)
In-Reply-To: <20180809093002.GB6132@sirena.org.uk>
On 08/09/2018 11:30 AM, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 02:19:33PM -0500, Gustavo A. R. Silva wrote:
>
>> @@ -648,6 +648,7 @@ static int adav80x_set_pll(struct snd_soc_component *component, int pll_id,
>> pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
>> break;
>> }
>> + /* fall through */
>> default:
>> return -EINVAL;
>> }
>
> Are you *positive* this is a deliberate fall through?
It is. But it might make sense to re-order the code to look like
case 54000000:
if (source != ADAV80X_PLL_SRC_XIN)
return -EINVAL;
pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
break;
It is just as many lines added when adding the /* fall through */, but it
makes it more obvious what is going on.
Either way:
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
WARNING: multiple messages have this Message-ID (diff)
From: Lars-Peter Clausen <lars@metafoo.de>
To: Mark Brown <broonie@kernel.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: adav80x: mark expected switch fall-through
Date: Thu, 9 Aug 2018 13:23:58 +0200 [thread overview]
Message-ID: <a68c854c-013a-8cb2-49de-5bb109b27fc3@metafoo.de> (raw)
In-Reply-To: <20180809093002.GB6132@sirena.org.uk>
On 08/09/2018 11:30 AM, Mark Brown wrote:
> On Wed, Aug 08, 2018 at 02:19:33PM -0500, Gustavo A. R. Silva wrote:
>
>> @@ -648,6 +648,7 @@ static int adav80x_set_pll(struct snd_soc_component *component, int pll_id,
>> pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
>> break;
>> }
>> + /* fall through */
>> default:
>> return -EINVAL;
>> }
>
> Are you *positive* this is a deliberate fall through?
It is. But it might make sense to re-order the code to look like
case 54000000:
if (source != ADAV80X_PLL_SRC_XIN)
return -EINVAL;
pll_ctrl1 |= ADAV80X_PLL_CTRL1_PLLDIV;
break;
It is just as many lines added when adding the /* fall through */, but it
makes it more obvious what is going on.
Either way:
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
next prev parent reply other threads:[~2018-08-09 11:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 19:19 [PATCH] ASoC: adav80x: mark expected switch fall-through Gustavo A. R. Silva
2018-08-09 9:30 ` Mark Brown
2018-08-09 9:30 ` Mark Brown
2018-08-09 11:23 ` Lars-Peter Clausen [this message]
2018-08-09 11:23 ` Lars-Peter Clausen
2018-08-09 13:46 ` [alsa-devel] " Mark Brown
2018-08-09 13:46 ` Mark Brown
2018-08-09 13:46 ` Applied "ASoC: adav80x: mark expected switch fall-through" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a68c854c-013a-8cb2-49de-5bb109b27fc3@metafoo.de \
--to=lars@metafoo.de \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=gustavo@embeddedor.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.