All of lore.kernel.org
 help / color / mirror / Atom feed
From: Phil Elwell <phil@raspberrypi.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] random: defer crediting bootloader randomness to random_init()
Date: Tue, 7 Jun 2022 15:13:51 +0100	[thread overview]
Message-ID: <a696e6fe-7337-2f16-9349-13130bc7805e@raspberrypi.com> (raw)
In-Reply-To: <CAHmME9owv1Cj8=XVV+i-4uC9Tc1TsKDUMeFcO-ziGv88GRk8Ow@mail.gmail.com>

Jason,

On 07/06/2022 14:51, Jason A. Donenfeld wrote:
> Hi Phil,
> 
> And this one also works, I assume?
> 
> https://lore.kernel.org/lkml/20220607100210.683136-1-Jason@zx2c4.com/

Using the metrics "earlier is better2 and "shorter is better", that patch wins 
on both counts:

With 5.15.45 + CONFIG_RANDOM_TRUST_BOOTLOADER=y:
[    0.000000] random: crng init done
[    1.985290] bcm2835-rng 3f104000.rng: hwrng registered

With rpi-5.15.y:
[    0.000000] random: crng init done
[    1.969552] bcm2835-rng 3f104000.rng: hwrng registered

No splats in either, of course.

Phil

WARNING: multiple messages have this Message-ID (diff)
From: Phil Elwell <phil@raspberrypi.com>
To: "Jason A. Donenfeld" <Jason@zx2c4.com>
Cc: linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	LKML <linux-kernel@vger.kernel.org>,
	Stephen Boyd <swboyd@chromium.org>,
	Ard Biesheuvel <ardb@kernel.org>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Russell King <linux@armlinux.org.uk>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: [PATCH v3] random: defer crediting bootloader randomness to random_init()
Date: Tue, 7 Jun 2022 15:13:51 +0100	[thread overview]
Message-ID: <a696e6fe-7337-2f16-9349-13130bc7805e@raspberrypi.com> (raw)
In-Reply-To: <CAHmME9owv1Cj8=XVV+i-4uC9Tc1TsKDUMeFcO-ziGv88GRk8Ow@mail.gmail.com>

Jason,

On 07/06/2022 14:51, Jason A. Donenfeld wrote:
> Hi Phil,
> 
> And this one also works, I assume?
> 
> https://lore.kernel.org/lkml/20220607100210.683136-1-Jason@zx2c4.com/

Using the metrics "earlier is better2 and "shorter is better", that patch wins 
on both counts:

With 5.15.45 + CONFIG_RANDOM_TRUST_BOOTLOADER=y:
[    0.000000] random: crng init done
[    1.985290] bcm2835-rng 3f104000.rng: hwrng registered

With rpi-5.15.y:
[    0.000000] random: crng init done
[    1.969552] bcm2835-rng 3f104000.rng: hwrng registered

No splats in either, of course.

Phil

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-06-07 14:13 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-07 11:15 [PATCH] random: defer use of bootloader randomness to random_init() Jason A. Donenfeld
2022-06-07 11:15 ` Jason A. Donenfeld
2022-06-07 11:22 ` Jason A. Donenfeld
2022-06-07 11:22   ` Jason A. Donenfeld
2022-06-07 11:32   ` [PATCH v2] random: defer crediting " Jason A. Donenfeld
2022-06-07 11:32     ` Jason A. Donenfeld
2022-06-07 12:19     ` Phil Elwell
2022-06-07 12:19       ` Phil Elwell
2022-06-07 12:23       ` Jason A. Donenfeld
2022-06-07 12:23         ` Jason A. Donenfeld
2022-06-07 12:44         ` [PATCH v3] " Jason A. Donenfeld
2022-06-07 12:44           ` Jason A. Donenfeld
2022-06-07 13:21           ` Phil Elwell
2022-06-07 13:21             ` Phil Elwell
2022-06-07 13:51             ` Jason A. Donenfeld
2022-06-07 13:51               ` Jason A. Donenfeld
2022-06-07 14:13               ` Phil Elwell [this message]
2022-06-07 14:13                 ` Phil Elwell
2022-06-07 11:55 ` [PATCH] random: defer use of " Ard Biesheuvel
2022-06-07 11:55   ` Ard Biesheuvel
2022-06-07 12:04   ` Jason A. Donenfeld
2022-06-07 12:04     ` Jason A. Donenfeld
2022-06-07 12:15     ` Ard Biesheuvel
2022-06-07 12:15       ` Ard Biesheuvel
2022-06-07 12:21       ` Jason A. Donenfeld
2022-06-07 12:21         ` Jason A. Donenfeld
2022-06-07 14:19         ` Ard Biesheuvel
2022-06-07 14:19           ` Ard Biesheuvel
2022-06-07 14:48           ` Jason A. Donenfeld
2022-06-07 14:48             ` Jason A. Donenfeld
2022-06-07 14:51             ` Ard Biesheuvel
2022-06-07 14:51               ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a696e6fe-7337-2f16-9349-13130bc7805e@raspberrypi.com \
    --to=phil@raspberrypi.com \
    --cc=Jason@zx2c4.com \
    --cc=ardb@kernel.org \
    --cc=arnd@arndb.de \
    --cc=catalin.marinas@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.