From: Huan Wang <alison.wang@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 6/7] arm: ls102xa: Add SD boot support for LS1021AQDS board
Date: Mon, 22 Sep 2014 06:46:20 +0000 [thread overview]
Message-ID: <a6b33b7077c64cea9cc4d7025a99d165@BN1PR0301MB0689.namprd03.prod.outlook.com> (raw)
In-Reply-To: <E1XV0Xb-0002D2-KV@janus>
Hi, Albert,
> > On Thu, 18 Sep 2014 13:47:18 +0800, Alison Wang <b18965@freescale.com>
> > wrote:
> >
> > > +
> > > + . = ALIGN(4);
> > > + .u_boot_list : {
> > > + KEEP(*(SORT(.u_boot_list*_i2c_*)));
> > > + }
> >
> > IS this required? And if it is, could it not be added to the
> > arch/arm/cpu/u-boot-spl.lds file? This way you would not need an .lds
> > file at all.
> >
> > [Alison Wang] Yes, it is required.
>
> Ok -- what for? :)
[Alison Wang] In SPL part, DDR is initialized by reading SPD through I2C interface.
For I2C, ll_entry_count() is called, and it returns the number of elements of a
linker-generated array placed into subsection of .u_boot_list section specified
by _list argument. So I need to add this to make I2C work in SPL.
>
> > I would like to add it in arch/arm/cpu/u-boot-spl.lds. I was not sure
> > adding it in arch/arm/cpu/u-boot-spl.lds is acceptable or not.
>
> (assuming the reason why it is needed is valid) If it causes no change
> to boards which do not use it right now (and I mean 'no change' ad
> 'binary identical') then this is acceptable. Make sure you check the
> binary invariance and that you mention it in the commit.
>
[Alison Wang] It will cause the binary is not identical for other board. I think
it may be not good to add in arch/arm/cpu/u-boot-spl.lds. What's your opinion about it?
Best Regards,
Alison Wang
next prev parent reply other threads:[~2014-09-22 6:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-18 5:47 [U-Boot] [PATCH 0/7] Add SD boot support for LS1021AQDS/TWR board Alison Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 1/7] spl: pbl: Add new SPL image for pblimage tool Alison Wang
2014-09-18 9:37 ` Albert ARIBAUD
2014-09-19 5:07 ` Huan Wang
2014-09-20 7:47 ` Albert ARIBAUD
2014-09-22 6:17 ` Huan Wang
2014-09-22 15:49 ` York Sun
2014-09-23 2:43 ` Huan Wang
2014-09-23 3:40 ` York Sun
2014-09-25 6:33 ` Huan Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 2/7] ls102xa: pblimage: Add pblimage tool support for LS102xA Alison Wang
2014-09-18 9:57 ` Albert ARIBAUD
2014-09-22 6:22 ` Huan Wang
2014-09-24 7:55 ` [U-Boot] [OT] " Albert ARIBAUD
2014-09-24 8:00 ` Huan Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 3/7] spl: Use u-boot.img instead of u-boot.bin when CONFIG_SPL_PBL_PAD is enabled Alison Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 4/7] ls102xa: qixis: Add CONFIG_QIXIS_I2C_ACCESS macro Alison Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 5/7] common: spl: Add interactive DDR debugger support for SPL Alison Wang
2014-09-18 5:47 ` [U-Boot] [PATCH 6/7] arm: ls102xa: Add SD boot support for LS1021AQDS board Alison Wang
2014-09-18 11:20 ` Albert ARIBAUD
2014-09-19 3:40 ` Alison Wang
2014-09-19 5:10 ` Huan Wang
[not found] ` <1411053355745.66856@freescale.com>
2014-09-19 15:56 ` Albert ARIBAUD
2014-09-22 6:46 ` Huan Wang [this message]
2014-09-22 11:01 ` Albert ARIBAUD
2014-09-25 6:45 ` Huan Wang
2014-10-01 18:08 ` Albert ARIBAUD
2014-10-08 9:53 ` Huan Wang
2014-10-11 11:30 ` Albert ARIBAUD
2014-10-15 6:56 ` Huan Wang
2014-10-15 10:30 ` Albert ARIBAUD
2014-09-18 5:47 ` [U-Boot] [PATCH 7/7] arm: ls102xa: Add SD boot support for LS1021ATWR board Alison Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6b33b7077c64cea9cc4d7025a99d165@BN1PR0301MB0689.namprd03.prod.outlook.com \
--to=alison.wang@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.