[PATCH v2] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append"

[PATCH v2] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append"

[Johannes Thumshirn]

Now that commit f34ee1dce642 ("dm crypt: Fix zoned block device support")
is merged in master, the device-mapper code can fully emulate zone append
there's no need for this check anymore.

This reverts commit 1d68128c107a ("btrfs: zoned: fail mount if the device
does not support zone append").

Cc: Naohiro  Aota <naohiro.aota@wdc.com>
Cc: Damien Le Moal <damien.lemoal@wdc.com>
Singed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
---
 fs/btrfs/zoned.c | 7 -------
 1 file changed, 7 deletions(-)

diff --git a/fs/btrfs/zoned.c b/fs/btrfs/zoned.c
index 297c0b1c0634..e4087a2364a2 100644
--- a/fs/btrfs/zoned.c
+++ b/fs/btrfs/zoned.c
@@ -354,13 +354,6 @@ int btrfs_get_dev_zone_info(struct btrfs_device *device)
 	if (!IS_ALIGNED(nr_sectors, zone_sectors))
 		zone_info->nr_zones++;
 
-	if (bdev_is_zoned(bdev) && zone_info->max_zone_append_size == 0) {
-		btrfs_err(fs_info, "zoned: device %pg does not support zone append",
-			  bdev);
-		ret = -EINVAL;
-		goto out;
-	}
-
 	zone_info->seq_zones = bitmap_zalloc(zone_info->nr_zones, GFP_KERNEL);
 	if (!zone_info->seq_zones) {
 		ret = -ENOMEM;
-- 
2.31.1

Re: [PATCH v2] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append"

[Neal Gompa]

On Fri, Jul 2, 2021 at 6:30 AM Johannes Thumshirn
<johannes.thumshirn@wdc.com> wrote:
>
> Now that commit f34ee1dce642 ("dm crypt: Fix zoned block device support")
> is merged in master, the device-mapper code can fully emulate zone append
> there's no need for this check anymore.
>
> This reverts commit 1d68128c107a ("btrfs: zoned: fail mount if the device
> does not support zone append").
>
> Cc: Naohiro  Aota <naohiro.aota@wdc.com>
> Cc: Damien Le Moal <damien.lemoal@wdc.com>
> Singed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>

This should be "Signed-off-by", no?


-- 
真実はいつも一つ！/ Always, there's only one truth!

Re: [PATCH v2] btrfs: zoned: revert "btrfs: zoned: fail mount if the device does not support zone append"

[Johannes Thumshirn]

On 02/07/2021 13:33, Neal Gompa wrote:
> On Fri, Jul 2, 2021 at 6:30 AM Johannes Thumshirn
> <johannes.thumshirn@wdc.com> wrote:
>>
>> Now that commit f34ee1dce642 ("dm crypt: Fix zoned block device support")
>> is merged in master, the device-mapper code can fully emulate zone append
>> there's no need for this check anymore.
>>
>> This reverts commit 1d68128c107a ("btrfs: zoned: fail mount if the device
>> does not support zone append").
>>
>> Cc: Naohiro  Aota <naohiro.aota@wdc.com>
>> Cc: Damien Le Moal <damien.lemoal@wdc.com>
>> Singed-off-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
> 
> This should be "Signed-off-by", no?
> 
> 


Indeed it does, no one want's to hear me singing (trust me).