From: "Tamminen, Eero T" <eero.t.tamminen@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>
Cc: "Intel-gfx@lists.freedesktop.org"
<Intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status
Date: Thu, 1 Apr 2021 10:24:07 +0000 [thread overview]
Message-ID: <a6d8cdfca6c642ef441c6ec104c8cf74b378bc02.camel@intel.com> (raw)
In-Reply-To: <YGWYZffWGb6zPvzj@intel.com>
Hi,
On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote:
> On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote:
...
> > I think it is possible to argue both ways.
> >
> > 1)
> > HAS_RC6 means hardware has RC6 so if we view PMU as very low level
> > we can
> > say always export it.
> >
> > If i915 had to turn it off (rc6->supported == false) due firmware or
> > GVT-g,
> > then we could say reporting zero RC6 is accurate in that sense. Only
> > the
> > reason "why it is zero" is missing for PMU users.
> >
> > 2)
> > Or if we go with this patch we could say that presence of the PMU
> > metric
> > means RC6 is active and enabled, while absence means it is either
> > not
> > supported due platform (or firmware) or how the platform is getting
> > used
> > (GVT-g).
> >
>
> yeap, these 2 cases described well my mental conflict...
>
> > So I think patch is a bit better. I don't see it is adding more
> > confusion.
>
> As I said on the other patch I have no strong position on which is
> better,
> but if you and Eero feel that this works better for the current case,
> let's do it...
IMHO seeing case 1) i.e. zero RC6 could be slightly better from user
point of view than not seeing RC6 at all, because:
A) user then knows that GPU is not entering RC6, and
B) then the question is why it's not going to RC6 => one can see from
sysfs that it has been disabled
Whereas in case 2), the question is why there's no RC6 info, and user
doesn't know whether GPU is suspended or not (i.e. why GPU power
consumption is higher than expected). It would help if i-g-t could show
e.g. "RC6 OFF" in that case.
- Eero
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Tamminen, Eero T" <eero.t.tamminen@intel.com>
To: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>,
"tvrtko.ursulin@linux.intel.com" <tvrtko.ursulin@linux.intel.com>
Cc: "Intel-gfx@lists.freedesktop.org"
<Intel-gfx@lists.freedesktop.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>
Subject: Re: [Intel-gfx] [PATCH] drm/i915/pmu: Check actual RC6 status
Date: Thu, 1 Apr 2021 10:24:07 +0000 [thread overview]
Message-ID: <a6d8cdfca6c642ef441c6ec104c8cf74b378bc02.camel@intel.com> (raw)
In-Reply-To: <YGWYZffWGb6zPvzj@intel.com>
Hi,
On Thu, 2021-04-01 at 05:54 -0400, Rodrigo Vivi wrote:
> On Thu, Apr 01, 2021 at 10:38:11AM +0100, Tvrtko Ursulin wrote:
...
> > I think it is possible to argue both ways.
> >
> > 1)
> > HAS_RC6 means hardware has RC6 so if we view PMU as very low level
> > we can
> > say always export it.
> >
> > If i915 had to turn it off (rc6->supported == false) due firmware or
> > GVT-g,
> > then we could say reporting zero RC6 is accurate in that sense. Only
> > the
> > reason "why it is zero" is missing for PMU users.
> >
> > 2)
> > Or if we go with this patch we could say that presence of the PMU
> > metric
> > means RC6 is active and enabled, while absence means it is either
> > not
> > supported due platform (or firmware) or how the platform is getting
> > used
> > (GVT-g).
> >
>
> yeap, these 2 cases described well my mental conflict...
>
> > So I think patch is a bit better. I don't see it is adding more
> > confusion.
>
> As I said on the other patch I have no strong position on which is
> better,
> but if you and Eero feel that this works better for the current case,
> let's do it...
IMHO seeing case 1) i.e. zero RC6 could be slightly better from user
point of view than not seeing RC6 at all, because:
A) user then knows that GPU is not entering RC6, and
B) then the question is why it's not going to RC6 => one can see from
sysfs that it has been disabled
Whereas in case 2), the question is why there's no RC6 info, and user
doesn't know whether GPU is suspended or not (i.e. why GPU power
consumption is higher than expected). It would help if i-g-t could show
e.g. "RC6 OFF" in that case.
- Eero
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2021-04-01 10:24 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-31 10:18 [PATCH] drm/i915/pmu: Check actual RC6 status Tvrtko Ursulin
2021-03-31 10:18 ` [Intel-gfx] " Tvrtko Ursulin
2021-03-31 16:16 ` [Intel-gfx] ✗ Fi.CI.DOCS: warning for " Patchwork
2021-03-31 16:40 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2021-03-31 19:35 ` [Intel-gfx] ✗ Fi.CI.IGT: failure " Patchwork
2021-04-01 9:19 ` [Intel-gfx] [PATCH] " Rodrigo Vivi
2021-04-01 9:19 ` Rodrigo Vivi
2021-04-01 9:38 ` Tvrtko Ursulin
2021-04-01 9:38 ` Tvrtko Ursulin
2021-04-01 9:54 ` Rodrigo Vivi
2021-04-01 9:54 ` Rodrigo Vivi
2021-04-01 10:24 ` Tamminen, Eero T [this message]
2021-04-01 10:24 ` Tamminen, Eero T
2021-04-01 11:38 ` Tvrtko Ursulin
2021-04-01 11:38 ` Tvrtko Ursulin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a6d8cdfca6c642ef441c6ec104c8cf74b378bc02.camel@intel.com \
--to=eero.t.tamminen@intel.com \
--cc=Intel-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tvrtko.ursulin@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.