All of lore.kernel.org
 help / color / mirror / Atom feed
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, dongas86@gmail.com,
	linux-imx@nxp.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, shawnguo@kernel.org,
	kernel@pengutronix.de, abel.vesa@nxp.com
Subject: Re: [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND
Date: Thu, 20 May 2021 12:10:27 +0900	[thread overview]
Message-ID: <a6f61bf1-b1c3-692a-608c-fe5486a77e52@samsung.com> (raw)
In-Reply-To: <20210519070545.1728197-2-aisheng.dong@nxp.com>

On 5/19/21 4:05 PM, Dong Aisheng wrote:
> The driver can't support simple ondemand governor due to missing
> .get_dev_status() capability.
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/devfreq/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 20373a893b44..e87d01c0b76a 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ
>  	tristate "i.MX8M DDRC DEVFREQ Driver"
>  	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
>  		(COMPILE_TEST && HAVE_ARM_SMCCC)
> -	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_USERSPACE
>  	help
>  	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows
> 

Looks good to me. But, How about changing the patch title as following?
- PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND dependency


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

WARNING: multiple messages have this Message-ID (diff)
From: Chanwoo Choi <cw00.choi@samsung.com>
To: Dong Aisheng <aisheng.dong@nxp.com>, linux-pm@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, dongas86@gmail.com,
	linux-imx@nxp.com, myungjoo.ham@samsung.com,
	kyungmin.park@samsung.com, shawnguo@kernel.org,
	kernel@pengutronix.de, abel.vesa@nxp.com
Subject: Re: [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND
Date: Thu, 20 May 2021 12:10:27 +0900	[thread overview]
Message-ID: <a6f61bf1-b1c3-692a-608c-fe5486a77e52@samsung.com> (raw)
In-Reply-To: <20210519070545.1728197-2-aisheng.dong@nxp.com>

On 5/19/21 4:05 PM, Dong Aisheng wrote:
> The driver can't support simple ondemand governor due to missing
> .get_dev_status() capability.
> 
> Cc: Chanwoo Choi <cw00.choi@samsung.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
> ---
>  drivers/devfreq/Kconfig | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/devfreq/Kconfig b/drivers/devfreq/Kconfig
> index 20373a893b44..e87d01c0b76a 100644
> --- a/drivers/devfreq/Kconfig
> +++ b/drivers/devfreq/Kconfig
> @@ -103,7 +103,6 @@ config ARM_IMX8M_DDRC_DEVFREQ
>  	tristate "i.MX8M DDRC DEVFREQ Driver"
>  	depends on (ARCH_MXC && HAVE_ARM_SMCCC) || \
>  		(COMPILE_TEST && HAVE_ARM_SMCCC)
> -	select DEVFREQ_GOV_SIMPLE_ONDEMAND
>  	select DEVFREQ_GOV_USERSPACE
>  	help
>  	  This adds the DEVFREQ driver for the i.MX8M DDR Controller. It allows
> 

Looks good to me. But, How about changing the patch title as following?
- PM / devfreq: imx8m-ddrc: Remove DEVFREQ_GOV_SIMPLE_ONDEMAND dependency


-- 
Best Regards,
Chanwoo Choi
Samsung Electronics

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-05-20  2:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <CGME20210519070646epcas1p278827601f2ce81e96e088f8fcac31d32@epcas1p2.samsung.com>
2021-05-19  7:05 ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Dong Aisheng
2021-05-19  7:05   ` Dong Aisheng
2021-05-19  7:05   ` [PATCH 2/2] devfreq: imx8m-ddrc: de-select DEVFREQ_GOV_SIMPLE_ONDEMAND Dong Aisheng
2021-05-19  7:05     ` Dong Aisheng
2021-05-20  3:10     ` Chanwoo Choi [this message]
2021-05-20  3:10       ` Chanwoo Choi
2021-05-21  3:04       ` Aisheng Dong
2021-05-21  3:04         ` Aisheng Dong
2021-05-20  2:51   ` [PATCH 1/2] PM / devfreq: imx-bus: Remove imx_bus_get_dev_status Chanwoo Choi
2021-05-20  2:51     ` Chanwoo Choi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a6f61bf1-b1c3-692a-608c-fe5486a77e52@samsung.com \
    --to=cw00.choi@samsung.com \
    --cc=abel.vesa@nxp.com \
    --cc=aisheng.dong@nxp.com \
    --cc=dongas86@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-imx@nxp.com \
    --cc=linux-pm@vger.kernel.org \
    --cc=myungjoo.ham@samsung.com \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.