[PATCH] drm/radeon/kms: never treat rs4xx as AGP

[PATCH] drm/radeon/kms: never treat rs4xx as AGP

[Alex Deucher]

[-- Attachment #1: Type: text/plain, Size: 1250 bytes --]

>From 7ac6ef362be216990835bfb5a7a71fdcf6d04ff5 Mon Sep 17 00:00:00 2001
From: Alex Deucher <alexdeucher@gmail.com>
Date: Sun, 21 Mar 2010 11:51:24 -0400
Subject: [PATCH] drm/radeon/kms: never treat rs4xx as AGP

RS4xx+ IGP chips use an internal gart, however,
some of them have the agp cap bits set in their pci
configs.  Make sure to clear the AGP flag as AGP will
not work with them.

Should fix fdo bug 27225

Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
---
 drivers/gpu/drm/radeon/radeon_device.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/gpu/drm/radeon/radeon_device.c
b/drivers/gpu/drm/radeon/radeon_device.c
index 75f7b1e..8de9edd 100644
--- a/drivers/gpu/drm/radeon/radeon_device.c
+++ b/drivers/gpu/drm/radeon/radeon_device.c
@@ -563,6 +563,14 @@ int radeon_device_init(struct radeon_device *rdev,
 		return r;
 	radeon_check_arguments(rdev);

+	/* all of the newer IGP chips have an internal gart
+	 * However some rs4xx report as AGP, so remove that here.
+	 */
+	if ((rdev->family >= CHIP_RS400) &&
+	    (rdev->flags & RADEON_IS_AGP)) {
+		rdev->flags &= ~RADEON_IS_AGP;
+	}
+
 	if (rdev->flags & RADEON_IS_AGP && radeon_agpmode == -1) {
 		radeon_agp_disable(rdev);
 	}
-- 
1.5.6.3

[-- Attachment #2: 0001-drm-radeon-kms-never-treat-rs4xx-as-AGP.patch --]
[-- Type: application/mbox, Size: 1251 bytes --]

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel

Re: [PATCH] drm/radeon/kms: never treat rs4xx as AGP

[Alex Deucher]

[-- Attachment #1: Type: text/plain, Size: 1597 bytes --]

ARGH!  typo in that patch.  Correct version attached.

Alex


On Sun, Mar 21, 2010 at 11:56 AM, Alex Deucher <alexdeucher@gmail.com> wrote:
> From 7ac6ef362be216990835bfb5a7a71fdcf6d04ff5 Mon Sep 17 00:00:00 2001
> From: Alex Deucher <alexdeucher@gmail.com>
> Date: Sun, 21 Mar 2010 11:51:24 -0400
> Subject: [PATCH] drm/radeon/kms: never treat rs4xx as AGP
>
> RS4xx+ IGP chips use an internal gart, however,
> some of them have the agp cap bits set in their pci
> configs.  Make sure to clear the AGP flag as AGP will
> not work with them.
>
> Should fix fdo bug 27225
>
> Signed-off-by: Alex Deucher <alexdeucher@gmail.com>
> ---
>  drivers/gpu/drm/radeon/radeon_device.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_device.c
> b/drivers/gpu/drm/radeon/radeon_device.c
> index 75f7b1e..8de9edd 100644
> --- a/drivers/gpu/drm/radeon/radeon_device.c
> +++ b/drivers/gpu/drm/radeon/radeon_device.c
> @@ -563,6 +563,14 @@ int radeon_device_init(struct radeon_device *rdev,
>                return r;
>        radeon_check_arguments(rdev);
>
> +       /* all of the newer IGP chips have an internal gart
> +        * However some rs4xx report as AGP, so remove that here.
> +        */
> +       if ((rdev->family >= CHIP_RS400) &&
> +           (rdev->flags & RADEON_IS_AGP)) {
> +               rdev->flags &= ~RADEON_IS_AGP;
> +       }
> +
>        if (rdev->flags & RADEON_IS_AGP && radeon_agpmode == -1) {
>                radeon_agp_disable(rdev);
>        }
> --
> 1.5.6.3
>

[-- Attachment #2: 0001-drm-radeon-kms-never-treat-rs4xx-as-AGP.patch --]
[-- Type: application/mbox, Size: 1251 bytes --]

[-- Attachment #3: Type: text/plain, Size: 345 bytes --]

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev

[-- Attachment #4: Type: text/plain, Size: 161 bytes --]

--
_______________________________________________
Dri-devel mailing list
Dri-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/dri-devel