linux-next: Fixes tag needs some work in the arc-current tree

linux-next: Fixes tag needs some work in the arc-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 484 bytes --]

Hi all,

In commit

  a20aadab6ad6 ("arc: drop definitions of pgd_index() and pgd_offset{, _k}() entirely")

Fixes tag

  Fixes: 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions")

has these problem(s):

  - SHA1 should be at least 12 digits long
    This can be fixed for the future by setting core.abbrev to 12 (or
    more) or (for git v2.11 or later) just making sure it is not set
    (or set to "auto").

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the arc-current tree

[Vineet Gupta]

Hi Stephen,

On 4/18/22 13:40, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>    a20aadab6ad6 ("arc: drop definitions of pgd_index() and pgd_offset{, _k}() entirely")
>
> Fixes tag
>
>    Fixes: 974b9b2c68f ("mm: consolidate pte_index() and pte_offset_*() definitions")
>
> has these problem(s):
>
>    - SHA1 should be at least 12 digits long
>      This can be fixed for the future by setting core.abbrev to 12 (or
>      more) or (for git v2.11 or later) just making sure it is not set
>      (or set to "auto").

I've fixed this and pushed.

Thx,
-Vineet

Re: linux-next: Fixes tag needs some work in the arc-current tree

[Vineet Gupta]

On 9/1/20 4:36 AM, Stephen Rothwell wrote:
> Hi Mike,
>
> On Tue, 1 Sep 2020 12:13:08 +0300 Mike Rapoport <rppt@linux.ibm.com> wrote:
>> On Tue, Sep 01, 2020 at 06:49:28PM +1000, Stephen Rothwell wrote:
>>> In commit
>>>
>>>   7000c9462d1b ("arc: fix memory initialization for systems with two memory banks")
>>>
>>> Fixes tag
>>>
>>>   Fixes: 51930df5801e ("mm: free_area_init: allow defining max_zone_pfn in descend ing order")  
>> It's line rewrapping:                                                               ^
> Yeah, wrapped and then unwrapped with an extra space :-(

Its vim's doing. Now fixed and pushed !

Thx,
-Vineet

Re: linux-next: Fixes tag needs some work in the arc-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 593 bytes --]

Hi Mike,

On Tue, 1 Sep 2020 12:13:08 +0300 Mike Rapoport <rppt@linux.ibm.com> wrote:
>
> On Tue, Sep 01, 2020 at 06:49:28PM +1000, Stephen Rothwell wrote:
> > 
> > In commit
> > 
> >   7000c9462d1b ("arc: fix memory initialization for systems with two memory banks")
> > 
> > Fixes tag
> > 
> >   Fixes: 51930df5801e ("mm: free_area_init: allow defining max_zone_pfn in descend ing order")  
> 
> It's line rewrapping:                                                               ^

Yeah, wrapped and then unwrapped with an extra space :-(

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the arc-current tree

[Mike Rapoport]

On Tue, Sep 01, 2020 at 06:49:28PM +1000, Stephen Rothwell wrote:
> Hi all,
> 
> In commit
> 
>   7000c9462d1b ("arc: fix memory initialization for systems with two memory banks")
> 
> Fixes tag
> 
>   Fixes: 51930df5801e ("mm: free_area_init: allow defining max_zone_pfn in descend ing order")

It's line rewrapping:                                                               ^

> 
> has these problem(s):
> 
>   - Subject does not match target commit subject
>     Just use
> 	git log -1 --format='Fixes: %h ("%s")'
> 
> -- 
> Cheers,
> Stephen Rothwell

-- 
Sincerely yours,
Mike.

linux-next: Fixes tag needs some work in the arc-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 386 bytes --]

Hi all,

In commit

  7000c9462d1b ("arc: fix memory initialization for systems with two memory banks")

Fixes tag

  Fixes: 51930df5801e ("mm: free_area_init: allow defining max_zone_pfn in descend ing order")

has these problem(s):

  - Subject does not match target commit subject
    Just use
	git log -1 --format='Fixes: %h ("%s")'

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

linux-next: Fixes tag needs some work in the arc-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 342 bytes --]

Hi Vineet,

Commit

  8bfa90f936b3 ("ARC: adjust memblock_reserve of kernel memory")

Fixes tag

  Fixes: 9ed68785f7f2b2b ("ARC: mm: Decouple RAM base address from kernel link addr")

has these problem:

  - Target SHA1 does not exist

Looks like the "2b" on the end was repeasted accidentally.
-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

Re: linux-next: Fixes tag needs some work in the arc-current tree

[Vineet Gupta]

On 1/17/19 12:33 PM, Stephen Rothwell wrote:
> Hi Vineet,
>
> Commit
>
>   8e542d2a28c9 ("ARC: adjust memblock_reserve of kernel memory")
>
> Fixes tag
>
>   Fixes: 9ed68785f7f ("ARC: mm: Decouple RAM base address from kernel link addr")
>
> has these problems:
>
>   - SHA1 should be at least 12 digits long
>

Thx for the report Stephen. Now fixed and pushed !

-Vineet

linux-next: Fixes tag needs some work in the arc-current tree

[Stephen Rothwell]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

Hi Vineet,

Commit

  8e542d2a28c9 ("ARC: adjust memblock_reserve of kernel memory")

Fixes tag

  Fixes: 9ed68785f7f ("ARC: mm: Decouple RAM base address from kernel link addr")

has these problems:

  - SHA1 should be at least 12 digits long

-- 
Cheers,
Stephen Rothwell

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]