* [PATCH v2 0/5] clock_settime/gettime for timespec64
@ 2021-03-12 4:01 chensong
2021-03-12 10:19 ` florian.bezdeka
0 siblings, 1 reply; 4+ messages in thread
From: chensong @ 2021-03-12 4:01 UTC (permalink / raw)
To: florian.bezdeka, xenomai, rpm
This patch serial is aimed to introduce a new syscall clock_settime64
and clock_gettime64 which are specific for 64-bit time_t.
There is no impact to current implementation of clock_settime, nothing
broken.
---
v2:
1, merge clock_settime64 and compat clock_settime64
2, remove checking __xn_feat_time64
3, add clock_gettime64
4, add smokey test for clock_settime64 and clock_gettime64
chensong (5):
[y2038] cobalt: posix: clock: Adding clock_settime64
[y2038] cobalt: posix: clock: Adding clock_gettime64
[y2038] lib: cobalt: clock: dispatch clock_settime
[y2038] lib: cobalt: clock: dispatch clock_gettime
[y2038] testsuite: smokey: y2038: testcase for settime64 and gettime64
include/cobalt/kernel/time.h | 3 +
include/cobalt/uapi/syscall.h | 2 +
kernel/cobalt/posix/clock.c | 28 +++++++-
kernel/cobalt/posix/clock.h | 7 ++
kernel/cobalt/posix/syscall32.c | 27 ++++++++
kernel/cobalt/posix/syscall32.h | 8 +++
kernel/cobalt/time.c | 11 ++++
lib/cobalt/clock.c | 12 ++++
testsuite/smokey/y2038/syscall-tests.c | 114 +++++++++++++++++++++++++++++++--
9 files changed, 206 insertions(+), 6 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/5] clock_settime/gettime for timespec64
2021-03-12 4:01 [PATCH v2 0/5] clock_settime/gettime for timespec64 chensong
@ 2021-03-12 10:19 ` florian.bezdeka
2021-03-17 9:03 ` chensong
0 siblings, 1 reply; 4+ messages in thread
From: florian.bezdeka @ 2021-03-12 10:19 UTC (permalink / raw)
To: rpm, xenomai, chensong
On Fri, 2021-03-12 at 12:01 +0800, chensong wrote:
> This patch serial is aimed to introduce a new syscall clock_settime64
> and clock_gettime64 which are specific for 64-bit time_t.
>
> There is no impact to current implementation of clock_settime, nothing
> broken.
>
> ---
> v2:
> 1, merge clock_settime64 and compat clock_settime64
> 2, remove checking __xn_feat_time64
> 3, add clock_gettime64
> 4, add smokey test for clock_settime64 and clock_gettime64
>
> chensong (5):
> [y2038] cobalt: posix: clock: Adding clock_settime64
> [y2038] cobalt: posix: clock: Adding clock_gettime64
I would suggest to change the order of the first two patches to use the
same order for y2038 syscalls as for non-y2038 ones.
> [y2038] lib: cobalt: clock: dispatch clock_settime
> [y2038] lib: cobalt: clock: dispatch clock_gettime
> [y2038] testsuite: smokey: y2038: testcase for settime64 and gettime64
>
> include/cobalt/kernel/time.h | 3 +
> include/cobalt/uapi/syscall.h | 2 +
> kernel/cobalt/posix/clock.c | 28 +++++++-
> kernel/cobalt/posix/clock.h | 7 ++
> kernel/cobalt/posix/syscall32.c | 27 ++++++++
> kernel/cobalt/posix/syscall32.h | 8 +++
> kernel/cobalt/time.c | 11 ++++
> lib/cobalt/clock.c | 12 ++++
> testsuite/smokey/y2038/syscall-tests.c | 114 +++++++++++++++++++++++++++++++--
> 9 files changed, 206 insertions(+), 6 deletions(-)
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/5] clock_settime/gettime for timespec64
2021-03-12 10:19 ` florian.bezdeka
@ 2021-03-17 9:03 ` chensong
2021-03-17 9:36 ` florian.bezdeka
0 siblings, 1 reply; 4+ messages in thread
From: chensong @ 2021-03-17 9:03 UTC (permalink / raw)
To: florian.bezdeka, rpm, xenomai
On 2021年03月12日 18:19, florian.bezdeka@siemens.com wrote:
> On Fri, 2021-03-12 at 12:01 +0800, chensong wrote:
>> This patch serial is aimed to introduce a new syscall clock_settime64
>> and clock_gettime64 which are specific for 64-bit time_t.
>>
>> There is no impact to current implementation of clock_settime, nothing
>> broken.
>>
>> ---
>> v2:
>> 1, merge clock_settime64 and compat clock_settime64
>> 2, remove checking __xn_feat_time64
>> 3, add clock_gettime64
>> 4, add smokey test for clock_settime64 and clock_gettime64
>>
>> chensong (5):
>> [y2038] cobalt: posix: clock: Adding clock_settime64
>> [y2038] cobalt: posix: clock: Adding clock_gettime64
>
> I would suggest to change the order of the first two patches to use the
> same order for y2038 syscalls as for non-y2038 ones.
please clarify the order you expected:
[PATCH v2 2/5] [y2038] cobalt: posix: clock: Adding clock_gettime64
[PATCH v2 1/5] [y2038] cobalt: posix: clock: Adding clock_settime64
[PATCH v2 3/5] [y2038] lib: cobalt: clock: dispatch clock_settime
[PATCH v2 4/5] [y2038] lib: cobalt: clock: dispatch clock_gettime
[PATCH v2 5/5] [y2038] testsuite: smokey: y2038: testcase for settime64
and gettime64
is it correct?
besides that, also need to do :
1, flip order c_cobalt_clock_settime64 and c_cobalt_clock_gettime64
2, documentation for cobalt_put_timespec64
3, improve test case
anything else?
Song
>
>> [y2038] lib: cobalt: clock: dispatch clock_settime
>> [y2038] lib: cobalt: clock: dispatch clock_gettime
>> [y2038] testsuite: smokey: y2038: testcase for settime64 and gettime64
>>
>> include/cobalt/kernel/time.h | 3 +
>> include/cobalt/uapi/syscall.h | 2 +
>> kernel/cobalt/posix/clock.c | 28 +++++++-
>> kernel/cobalt/posix/clock.h | 7 ++
>> kernel/cobalt/posix/syscall32.c | 27 ++++++++
>> kernel/cobalt/posix/syscall32.h | 8 +++
>> kernel/cobalt/time.c | 11 ++++
>> lib/cobalt/clock.c | 12 ++++
>> testsuite/smokey/y2038/syscall-tests.c | 114 +++++++++++++++++++++++++++++++--
>> 9 files changed, 206 insertions(+), 6 deletions(-)
>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2 0/5] clock_settime/gettime for timespec64
2021-03-17 9:03 ` chensong
@ 2021-03-17 9:36 ` florian.bezdeka
0 siblings, 0 replies; 4+ messages in thread
From: florian.bezdeka @ 2021-03-17 9:36 UTC (permalink / raw)
To: rpm, xenomai, chensong
On Wed, 2021-03-17 at 17:03 +0800, chensong wrote:
>
> On 2021年03月12日 18:19, florian.bezdeka@siemens.com wrote:
> > On Fri, 2021-03-12 at 12:01 +0800, chensong wrote:
> > > This patch serial is aimed to introduce a new syscall clock_settime64
> > > and clock_gettime64 which are specific for 64-bit time_t.
> > >
> > > There is no impact to current implementation of clock_settime, nothing
> > > broken.
> > >
> > > ---
> > > v2:
> > > 1, merge clock_settime64 and compat clock_settime64
> > > 2, remove checking __xn_feat_time64
> > > 3, add clock_gettime64
> > > 4, add smokey test for clock_settime64 and clock_gettime64
> > >
> > > chensong (5):
> > > [y2038] cobalt: posix: clock: Adding clock_settime64
> > > [y2038] cobalt: posix: clock: Adding clock_gettime64
> >
> > I would suggest to change the order of the first two patches to use the
> > same order for y2038 syscalls as for non-y2038 ones.
>
> please clarify the order you expected:
> [PATCH v2 2/5] [y2038] cobalt: posix: clock: Adding clock_gettime64
> [PATCH v2 1/5] [y2038] cobalt: posix: clock: Adding clock_settime64
>
> [PATCH v2 3/5] [y2038] lib: cobalt: clock: dispatch clock_settime
> [PATCH v2 4/5] [y2038] lib: cobalt: clock: dispatch clock_gettime
> [PATCH v2 5/5] [y2038] testsuite: smokey: y2038: testcase for settime64
> and gettime64
>
> is it correct?
Yes.
>
> besides that, also need to do :
> 1, flip order c_cobalt_clock_settime64 and c_cobalt_clock_gettime64
> 2, documentation for cobalt_put_timespec64
> 3, improve test case
While at it: Make sure that we don't crash when NULL or a bad address
is supplied as argument. The expected error code is EFAULT.
>
> anything else?
I guess that's it.
>
> Song
>
> >
> > > [y2038] lib: cobalt: clock: dispatch clock_settime
> > > [y2038] lib: cobalt: clock: dispatch clock_gettime
> > > [y2038] testsuite: smokey: y2038: testcase for settime64 and gettime64
> > >
> > > include/cobalt/kernel/time.h | 3 +
> > > include/cobalt/uapi/syscall.h | 2 +
> > > kernel/cobalt/posix/clock.c | 28 +++++++-
> > > kernel/cobalt/posix/clock.h | 7 ++
> > > kernel/cobalt/posix/syscall32.c | 27 ++++++++
> > > kernel/cobalt/posix/syscall32.h | 8 +++
> > > kernel/cobalt/time.c | 11 ++++
> > > lib/cobalt/clock.c | 12 ++++
> > > testsuite/smokey/y2038/syscall-tests.c | 114 +++++++++++++++++++++++++++++++--
> > > 9 files changed, 206 insertions(+), 6 deletions(-)
> > >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-03-17 9:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-12 4:01 [PATCH v2 0/5] clock_settime/gettime for timespec64 chensong
2021-03-12 10:19 ` florian.bezdeka
2021-03-17 9:03 ` chensong
2021-03-17 9:36 ` florian.bezdeka
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.