* [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
@ 2022-07-14 9:39 ` Pin-Yen Lin
0 siblings, 0 replies; 6+ messages in thread
From: Pin-Yen Lin @ 2022-07-14 9:39 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: Hsin-Yi Wang, Allen Chen, Pin-Yen Lin, dri-devel, linux-kernel
Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable
callback. Without this command, some monitors won't show up again after
changing the resolution.
Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
---
Changes in v2:
- Update the typo in the summary (power on --> power off)
- Re-write the commit message to make it clearer.
drivers/gpu/drm/bridge/ite-it6505.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..e5626035f311 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2945,6 +2945,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
if (ret)
dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
+ it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
+ DP_SET_POWER_D0);
+
it6505_update_video_parameter(it6505, mode);
ret = it6505_send_video_infoframe(it6505, &frame);
--
2.37.0.144.g8ac04bfd2-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
@ 2022-07-14 9:39 ` Pin-Yen Lin
0 siblings, 0 replies; 6+ messages in thread
From: Pin-Yen Lin @ 2022-07-14 9:39 UTC (permalink / raw)
To: Andrzej Hajda, Neil Armstrong, Robert Foss, Laurent Pinchart,
Jonas Karlman, Jernej Skrabec, David Airlie, Daniel Vetter
Cc: Allen Chen, linux-kernel, dri-devel, Pin-Yen Lin, Hsin-Yi Wang
Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable
callback. Without this command, some monitors won't show up again after
changing the resolution.
Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
---
Changes in v2:
- Update the typo in the summary (power on --> power off)
- Re-write the commit message to make it clearer.
drivers/gpu/drm/bridge/ite-it6505.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..e5626035f311 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2945,6 +2945,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
if (ret)
dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
+ it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
+ DP_SET_POWER_D0);
+
it6505_update_video_parameter(it6505, mode);
ret = it6505_send_video_infoframe(it6505, &frame);
--
2.37.0.144.g8ac04bfd2-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
2022-07-14 9:39 ` Pin-Yen Lin
@ 2022-07-14 10:41 ` allen.chen
-1 siblings, 0 replies; 6+ messages in thread
From: allen.chen @ 2022-07-14 10:41 UTC (permalink / raw)
To: treapking, andrzej.hajda, narmstrong, robert.foss,
Laurent.pinchart, jonas, jernej.skrabec, airlied, daniel
Cc: hsinyi, dri-devel, linux-kernel, Kenneth.Hung, Jau-Chih.Tseng, Hermes.Wu
Reviewed-by: Allen Chen <allen.chen@ite.com.tw>
-----Original Message-----
From: Pin-Yen Lin <treapking@chromium.org>
Sent: Thursday, July 14, 2022 5:39 PM
To: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>; Allen Chen (陳柏宇) <allen.chen@ite.com.tw>; Pin-Yen Lin <treapking@chromium.org>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable callback. Without this command, some monitors won't show up again after changing the resolution.
Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
---
Changes in v2:
- Update the typo in the summary (power on --> power off)
- Re-write the commit message to make it clearer.
drivers/gpu/drm/bridge/ite-it6505.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..e5626035f311 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2945,6 +2945,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
if (ret)
dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
+ it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
+ DP_SET_POWER_D0);
+
it6505_update_video_parameter(it6505, mode);
ret = it6505_send_video_infoframe(it6505, &frame);
--
2.37.0.144.g8ac04bfd2-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* RE: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
@ 2022-07-14 10:41 ` allen.chen
0 siblings, 0 replies; 6+ messages in thread
From: allen.chen @ 2022-07-14 10:41 UTC (permalink / raw)
To: treapking, andrzej.hajda, narmstrong, robert.foss,
Laurent.pinchart, jonas, jernej.skrabec, airlied, daniel
Cc: Kenneth.Hung, Jau-Chih.Tseng, linux-kernel, dri-devel, Hermes.Wu, hsinyi
Reviewed-by: Allen Chen <allen.chen@ite.com.tw>
-----Original Message-----
From: Pin-Yen Lin <treapking@chromium.org>
Sent: Thursday, July 14, 2022 5:39 PM
To: Andrzej Hajda <andrzej.hajda@intel.com>; Neil Armstrong <narmstrong@baylibre.com>; Robert Foss <robert.foss@linaro.org>; Laurent Pinchart <Laurent.pinchart@ideasonboard.com>; Jonas Karlman <jonas@kwiboo.se>; Jernej Skrabec <jernej.skrabec@gmail.com>; David Airlie <airlied@linux.ie>; Daniel Vetter <daniel@ffwll.ch>
Cc: Hsin-Yi Wang <hsinyi@chromium.org>; Allen Chen (陳柏宇) <allen.chen@ite.com.tw>; Pin-Yen Lin <treapking@chromium.org>; dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
Subject: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
Send DPCD DP_SET_POWER_D0 command to the monitor in .atomic_enable callback. Without this command, some monitors won't show up again after changing the resolution.
Fixes: 46ca7da7f1e8 ("drm/bridge: it6505: Send DPCD SET_POWER to downstream")
Signed-off-by: Pin-Yen Lin <treapking@chromium.org>
---
Changes in v2:
- Update the typo in the summary (power on --> power off)
- Re-write the commit message to make it clearer.
drivers/gpu/drm/bridge/ite-it6505.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/bridge/ite-it6505.c b/drivers/gpu/drm/bridge/ite-it6505.c
index 4b673c4792d7..e5626035f311 100644
--- a/drivers/gpu/drm/bridge/ite-it6505.c
+++ b/drivers/gpu/drm/bridge/ite-it6505.c
@@ -2945,6 +2945,9 @@ static void it6505_bridge_atomic_enable(struct drm_bridge *bridge,
if (ret)
dev_err(dev, "Failed to setup AVI infoframe: %d", ret);
+ it6505_drm_dp_link_set_power(&it6505->aux, &it6505->link,
+ DP_SET_POWER_D0);
+
it6505_update_video_parameter(it6505, mode);
ret = it6505_send_video_infoframe(it6505, &frame);
--
2.37.0.144.g8ac04bfd2-goog
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
2022-07-14 10:41 ` allen.chen
@ 2022-07-18 11:28 ` Robert Foss
-1 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-07-18 11:28 UTC (permalink / raw)
To: allen.chen
Cc: treapking, andrzej.hajda, narmstrong, Laurent.pinchart, jonas,
jernej.skrabec, airlied, daniel, hsinyi, dri-devel, linux-kernel,
Kenneth.Hung, Jau-Chih.Tseng, Hermes.Wu
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable
@ 2022-07-18 11:28 ` Robert Foss
0 siblings, 0 replies; 6+ messages in thread
From: Robert Foss @ 2022-07-18 11:28 UTC (permalink / raw)
To: allen.chen
Cc: Kenneth.Hung, jonas, airlied, dri-devel, narmstrong,
linux-kernel, jernej.skrabec, treapking, Hermes.Wu,
Laurent.pinchart, andrzej.hajda, hsinyi, Jau-Chih.Tseng
Applied to drm-misc-next
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2022-07-18 11:29 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-07-14 9:39 [PATCH v2] drm/bridge: it6505: Power on downstream device in .atomic_enable Pin-Yen Lin
2022-07-14 9:39 ` Pin-Yen Lin
2022-07-14 10:41 ` allen.chen
2022-07-14 10:41 ` allen.chen
2022-07-18 11:28 ` Robert Foss
2022-07-18 11:28 ` Robert Foss
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.