Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Guenter Roeck]

On Wed, Nov 02, 2022 at 11:05:30PM +0100, Marek Vasut wrote:
> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: linux-watchdog@vger.kernel.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add missing required: properties
>     - Drop quotes around ref: referenced schema file name
> ---
> NOTE: The Maintainer entry should likely be changed, although it seems
>       like this driver and its matching bindings are now unmaintained.

I still can not parse this note. The MAINTAINERS entry for watchdog devices
includes

F:      Documentation/devicetree/bindings/watchdog/
F:      drivers/watchdog/

which should cover both the old and the new bindings as well as the driver.

Please explain.

Guenter

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Marek Vasut]

On 11/3/22 02:22, Guenter Roeck wrote:
> On Wed, Nov 02, 2022 at 11:05:30PM +0100, Marek Vasut wrote:
>> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
>>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> ---
>> Cc: Guenter Roeck <linux@roeck-us.net>
>> Cc: Rob Herring <robh+dt@kernel.org>
>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
>> Cc: linux-watchdog@vger.kernel.org
>> To: devicetree@vger.kernel.org
>> ---
>> V2: - Add missing required: properties
>>      - Drop quotes around ref: referenced schema file name
>> ---
>> NOTE: The Maintainer entry should likely be changed, although it seems
>>        like this driver and its matching bindings are now unmaintained.
> 
> I still can not parse this note. The MAINTAINERS entry for watchdog devices
> includes
> 
> F:      Documentation/devicetree/bindings/watchdog/
> F:      drivers/watchdog/
> 
> which should cover both the old and the new bindings as well as the driver.
> 
> Please explain.

I don't mind placing you and Wim into the yaml DT maintainer section if 
that's OK with you ?

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Guenter Roeck]

On Thu, Nov 03, 2022 at 05:31:12PM +0100, Marek Vasut wrote:
> On 11/3/22 02:22, Guenter Roeck wrote:
> > On Wed, Nov 02, 2022 at 11:05:30PM +0100, Marek Vasut wrote:
> > > Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
> > > 
> > > Signed-off-by: Marek Vasut <marex@denx.de>
> > > ---
> > > Cc: Guenter Roeck <linux@roeck-us.net>
> > > Cc: Rob Herring <robh+dt@kernel.org>
> > > Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> > > Cc: linux-watchdog@vger.kernel.org
> > > To: devicetree@vger.kernel.org
> > > ---
> > > V2: - Add missing required: properties
> > >      - Drop quotes around ref: referenced schema file name
> > > ---
> > > NOTE: The Maintainer entry should likely be changed, although it seems
> > >        like this driver and its matching bindings are now unmaintained.
> > 
> > I still can not parse this note. The MAINTAINERS entry for watchdog devices
> > includes
> > 
> > F:      Documentation/devicetree/bindings/watchdog/
> > F:      drivers/watchdog/
> > 
> > which should cover both the old and the new bindings as well as the driver.
> > 
> > Please explain.
> 
> I don't mind placing you and Wim into the yaml DT maintainer section if
> that's OK with you ?

Ah, you mean the _yaml_ Maintainer entry. Just add me; I can not make
the call for Wim.

Guenter

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Marek Vasut]

On 11/3/22 18:20, Guenter Roeck wrote:
> On Thu, Nov 03, 2022 at 05:31:12PM +0100, Marek Vasut wrote:
>> On 11/3/22 02:22, Guenter Roeck wrote:
>>> On Wed, Nov 02, 2022 at 11:05:30PM +0100, Marek Vasut wrote:
>>>> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
>>>>
>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>> ---
>>>> Cc: Guenter Roeck <linux@roeck-us.net>
>>>> Cc: Rob Herring <robh+dt@kernel.org>
>>>> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
>>>> Cc: linux-watchdog@vger.kernel.org
>>>> To: devicetree@vger.kernel.org
>>>> ---
>>>> V2: - Add missing required: properties
>>>>       - Drop quotes around ref: referenced schema file name
>>>> ---
>>>> NOTE: The Maintainer entry should likely be changed, although it seems
>>>>         like this driver and its matching bindings are now unmaintained.
>>>
>>> I still can not parse this note. The MAINTAINERS entry for watchdog devices
>>> includes
>>>
>>> F:      Documentation/devicetree/bindings/watchdog/
>>> F:      drivers/watchdog/
>>>
>>> which should cover both the old and the new bindings as well as the driver.
>>>
>>> Please explain.
>>
>> I don't mind placing you and Wim into the yaml DT maintainer section if
>> that's OK with you ?
> 
> Ah, you mean the _yaml_ Maintainer entry. Just add me; I can not make
> the call for Wim.

Yes, that entry. That's what I was wondering about.

I'll wait a bit before sending V3.

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Rob Herring]

On Wed, 02 Nov 2022 23:05:30 +0100, Marek Vasut wrote:
> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: linux-watchdog@vger.kernel.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add missing required: properties
>     - Drop quotes around ref: referenced schema file name
> ---
> NOTE: The Maintainer entry should likely be changed, although it seems
>       like this driver and its matching bindings are now unmaintained.
> ---
>  .../devicetree/bindings/watchdog/gpio-wdt.txt | 28 -----------
>  .../bindings/watchdog/linux,wdt-gpio.yaml     | 47 +++++++++++++++++++
>  2 files changed, 47 insertions(+), 28 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
>  create mode 100644 Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Re: [PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Guenter Roeck]

On Wed, Nov 02, 2022 at 11:05:30PM +0100, Marek Vasut wrote:
> Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.
> 
> Signed-off-by: Marek Vasut <marex@denx.de>
> ---
> Cc: Guenter Roeck <linux@roeck-us.net>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
> Cc: linux-watchdog@vger.kernel.org
> To: devicetree@vger.kernel.org
> ---
> V2: - Add missing required: properties
>     - Drop quotes around ref: referenced schema file name
> ---
> NOTE: The Maintainer entry should likely be changed, although it seems
>       like this driver and its matching bindings are now unmaintained.

Where do you get that Cc: list from anyway ? get_maintainer.pl on both the
mainline kernel and on linux-next tells me

Wim Van Sebroeck <wim@linux-watchdog.org> (maintainer:WATCHDOG DEVICE DRIVERS)
Guenter Roeck <linux@roeck-us.net> (maintainer:WATCHDOG DEVICE DRIVERS)
Rob Herring <robh+dt@kernel.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> (maintainer:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-watchdog@vger.kernel.org (open list:WATCHDOG DEVICE DRIVERS)
devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS)
linux-kernel@vger.kernel.org (open list)

Why don't you copy Krzysztof ?

Guenter

[PATCH v2] dt-bindings: watchdog: gpio: Convert bindings to YAML

[Marek Vasut]

Convert the gpio-wdt bindings from text to YAML ones, to permit DT validation.

Signed-off-by: Marek Vasut <marex@denx.de>
---
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Rob Herring <robh+dt@kernel.org>
Cc: Wim Van Sebroeck <wim@linux-watchdog.org>
Cc: linux-watchdog@vger.kernel.org
To: devicetree@vger.kernel.org
---
V2: - Add missing required: properties
    - Drop quotes around ref: referenced schema file name
---
NOTE: The Maintainer entry should likely be changed, although it seems
      like this driver and its matching bindings are now unmaintained.
---
 .../devicetree/bindings/watchdog/gpio-wdt.txt | 28 -----------
 .../bindings/watchdog/linux,wdt-gpio.yaml     | 47 +++++++++++++++++++
 2 files changed, 47 insertions(+), 28 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
 create mode 100644 Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml

diff --git a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt b/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
deleted file mode 100644
index 198794963786b..0000000000000
--- a/Documentation/devicetree/bindings/watchdog/gpio-wdt.txt
+++ /dev/null
@@ -1,28 +0,0 @@
-* GPIO-controlled Watchdog
-
-Required Properties:
-- compatible: Should contain "linux,wdt-gpio".
-- gpios: From common gpio binding; gpio connection to WDT reset pin.
-- hw_algo: The algorithm used by the driver. Should be one of the
-  following values:
-  - toggle: Either a high-to-low or a low-to-high transition clears
-    the WDT counter. The watchdog timer is disabled when GPIO is
-    left floating or connected to a three-state buffer.
-  - level: Low or high level starts counting WDT timeout,
-    the opposite level disables the WDT. Active level is determined
-    by the GPIO flags.
-- hw_margin_ms: Maximum time to reset watchdog circuit (milliseconds).
-
-Optional Properties:
-- always-running: If the watchdog timer cannot be disabled, add this flag to
-  have the driver keep toggling the signal without a client. It will only cease
-  to toggle the signal when the device is open and the timeout elapsed.
-
-Example:
-	watchdog: watchdog {
-		/* ADM706 */
-		compatible = "linux,wdt-gpio";
-		gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
-		hw_algo = "toggle";
-		hw_margin_ms = <1600>;
-	};
diff --git a/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
new file mode 100644
index 0000000000000..ff0b0b241513c
--- /dev/null
+++ b/Documentation/devicetree/bindings/watchdog/linux,wdt-gpio.yaml
@@ -0,0 +1,47 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/watchdog/linux,wdt-gpio.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: GPIO-controlled Watchdog
+
+maintainers:
+  - Marek Vasut <marex@denx.de>
+
+properties:
+  compatible:
+    const: linux,wdt-gpio
+
+  gpios:
+    description: gpio connection to WDT reset pin
+    maxItems: 1
+
+  hw_algo:
+    description: The algorithm used by the driver.
+    enum: [ level, toggle ]
+
+  hw_margin_ms:
+    description: Maximum time to reset watchdog circuit (milliseconds).
+    $ref: /schemas/types.yaml#/definitions/uint32
+
+required:
+  - compatible
+  - gpios
+  - hw_algo
+  - hw_margin_ms
+
+allOf:
+  - $ref: watchdog.yaml#
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+    watchdog {
+        compatible = "linux,wdt-gpio";
+        gpios = <&gpio3 9 GPIO_ACTIVE_LOW>;
+        hw_algo = "toggle";
+        hw_margin_ms = <1600>;
+    };
-- 
2.35.1