* [PATCH] drm/drv: Remove initialization of static variables
@ 2021-02-19 2:30 Tian Tao
2021-02-19 8:23 ` Thomas Zimmermann
0 siblings, 1 reply; 2+ messages in thread
From: Tian Tao @ 2021-02-19 2:30 UTC (permalink / raw)
To: maarten.lankhorst, mripard, tzimmermann, airlied, daniel; +Cc: dri-devel
Address the following checkpatch errors:
ERROR: do not initialise statics to false
Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
---
drivers/gpu/drm/drm_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
index 20d22e4..c2f78de 100644
--- a/drivers/gpu/drm/drm_drv.c
+++ b/drivers/gpu/drm/drm_drv.c
@@ -61,7 +61,7 @@ static struct idr drm_minors_idr;
* prefer to embed struct drm_device into their own device
* structure and call drm_dev_init() themselves.
*/
-static bool drm_core_init_complete = false;
+static bool drm_core_init_complete;
static struct dentry *drm_debugfs_root;
--
2.7.4
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/drv: Remove initialization of static variables
2021-02-19 2:30 [PATCH] drm/drv: Remove initialization of static variables Tian Tao
@ 2021-02-19 8:23 ` Thomas Zimmermann
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Zimmermann @ 2021-02-19 8:23 UTC (permalink / raw)
To: Tian Tao, maarten.lankhorst, mripard, airlied, daniel; +Cc: dri-devel
[-- Attachment #1.1.1: Type: text/plain, Size: 1071 bytes --]
Am 19.02.21 um 03:30 schrieb Tian Tao:
> Address the following checkpatch errors:
> ERROR: do not initialise statics to false
>
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Acked-by: Thomas Zimmermann <tzimmermann@suse.de>
Thanks for the patch.
> ---
> drivers/gpu/drm/drm_drv.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c
> index 20d22e4..c2f78de 100644
> --- a/drivers/gpu/drm/drm_drv.c
> +++ b/drivers/gpu/drm/drm_drv.c
> @@ -61,7 +61,7 @@ static struct idr drm_minors_idr;
> * prefer to embed struct drm_device into their own device
> * structure and call drm_dev_init() themselves.
> */
> -static bool drm_core_init_complete = false;
> +static bool drm_core_init_complete;
>
> static struct dentry *drm_debugfs_root;
>
>
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Felix Imendörffer
[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 840 bytes --]
[-- Attachment #2: Type: text/plain, Size: 160 bytes --]
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-19 8:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-19 2:30 [PATCH] drm/drv: Remove initialization of static variables Tian Tao
2021-02-19 8:23 ` Thomas Zimmermann
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.