* drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition
@ 2017-03-27 10:47 ` David Binderman
0 siblings, 0 replies; 4+ messages in thread
From: David Binderman @ 2017-03-27 10:47 UTC (permalink / raw)
To: mturquette, sboyd, rjui, sbranden, jonmason,
bcm-kernel-feedback-list, linux-clk, linux-arm-kernel
Hello there,
linux-4.11-rc4/drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant cond=
ition: If 'rate >=3D 2200000000', the comparison 'rate' is always true.
Source code is
} else if (rate >=3D VCO_HIGH && rate && rate < VCO_HIGH_HIGH) {
Suggest new code
} else if (rate >=3D VCO_HIGH && rate < VCO_HIGH_HIGH) {
Regards
David Binderman
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition
@ 2017-03-27 10:47 ` David Binderman
0 siblings, 0 replies; 4+ messages in thread
From: David Binderman @ 2017-03-27 10:47 UTC (permalink / raw)
To: linux-arm-kernel
Hello there,
linux-4.11-rc4/drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition: If 'rate >= 2200000000', the comparison 'rate' is always true.
Source code is
} else if (rate >= VCO_HIGH && rate && rate < VCO_HIGH_HIGH) {
Suggest new code
} else if (rate >= VCO_HIGH && rate < VCO_HIGH_HIGH) {
Regards
David Binderman
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition
2017-03-27 10:47 ` David Binderman
@ 2017-04-05 18:27 ` Ray Jui
-1 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2017-04-05 18:27 UTC (permalink / raw)
To: David Binderman, mturquette, sboyd, rjui, sbranden, jonmason,
bcm-kernel-feedback-list, linux-clk, linux-arm-kernel
Hi David,
Thanks for reporting. I'll send out a patch to address this.
Ray
On 3/27/2017 3:47 AM, David Binderman wrote:
> Hello there,
>
>
> linux-4.11-rc4/drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition: If 'rate >= 2200000000', the comparison 'rate' is always true.
>
> Source code is
>
> } else if (rate >= VCO_HIGH && rate && rate < VCO_HIGH_HIGH) {
>
> Suggest new code
>
> } else if (rate >= VCO_HIGH && rate < VCO_HIGH_HIGH) {
>
> Regards
>
> David Binderman
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition
@ 2017-04-05 18:27 ` Ray Jui
0 siblings, 0 replies; 4+ messages in thread
From: Ray Jui @ 2017-04-05 18:27 UTC (permalink / raw)
To: linux-arm-kernel
Hi David,
Thanks for reporting. I'll send out a patch to address this.
Ray
On 3/27/2017 3:47 AM, David Binderman wrote:
> Hello there,
>
>
> linux-4.11-rc4/drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition: If 'rate >= 2200000000', the comparison 'rate' is always true.
>
> Source code is
>
> } else if (rate >= VCO_HIGH && rate && rate < VCO_HIGH_HIGH) {
>
> Suggest new code
>
> } else if (rate >= VCO_HIGH && rate < VCO_HIGH_HIGH) {
>
> Regards
>
> David Binderman
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-04-05 18:27 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-27 10:47 drivers/clk/bcm/clk-iproc-pll.c:280]: (style) Redundant condition David Binderman
2017-03-27 10:47 ` David Binderman
2017-04-05 18:27 ` Ray Jui
2017-04-05 18:27 ` Ray Jui
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.