* [PATCH] libsamplerate0: Set correct soname for 0.1.9
@ 2021-09-24 12:47 Tom Pollard
2021-09-24 16:15 ` [OE-core] " Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Tom Pollard @ 2021-09-24 12:47 UTC (permalink / raw)
To: openembedded-core; +Cc: Tom Pollard
Manually patch SHARED_VERSION_INFO, which was missed in
the 0.1.9 release and later incorrectly fixed until 0.2.1
Signed-off-by: Tom Pollard <tom.pollard@codethink.co.uk>
---
.../libsamplerate0/shared_version_info.patch | 13 +++++++++++++
.../libsamplerate/libsamplerate0_0.1.9.bb | 1 +
2 files changed, 14 insertions(+)
create mode 100644 meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
new file mode 100644
index 0000000000..b42d564b4b
--- /dev/null
+++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
@@ -0,0 +1,13 @@
+Index: libsamplerate-0.1.8/configure.ac
+===================================================================
+--- libsamplerate-0.1.8.orig/configure.ac
++++ libsamplerate-0.1.8/configure.ac
+@@ -53,7 +53,7 @@ AC_PROG_LN_S
+ # 6. If any interfaces have been removed since the last public release, then set age
+ # to 0.
+
+-SHARED_VERSION_INFO="1:8:1"
++SHARED_VERSION_INFO="1:9:1"
+
+
+
diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
index 6dfc42b436..8345d6880f 100644
--- a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
+++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
@@ -10,6 +10,7 @@ PR = "r1"
SRC_URI = "http://www.mega-nerd.com/SRC/libsamplerate-${PV}.tar.gz \
file://0001-configure.ac-improve-alsa-handling.patch \
+ file://shared_version_info.patch \
"
SRC_URI[md5sum] = "2b78ae9fe63b36b9fbb6267fad93f259"
--
2.30.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] libsamplerate0: Set correct soname for 0.1.9
2021-09-24 12:47 [PATCH] libsamplerate0: Set correct soname for 0.1.9 Tom Pollard
@ 2021-09-24 16:15 ` Khem Raj
2021-09-27 11:10 ` Tom Pollard
0 siblings, 1 reply; 4+ messages in thread
From: Khem Raj @ 2021-09-24 16:15 UTC (permalink / raw)
To: Tom Pollard, openembedded-core
On 9/24/21 5:47 AM, Tom Pollard wrote:
> Manually patch SHARED_VERSION_INFO, which was missed in
> the 0.1.9 release and later incorrectly fixed until 0.2.1
>
> Signed-off-by: Tom Pollard <tom.pollard@codethink.co.uk>
> ---
> .../libsamplerate0/shared_version_info.patch | 13 +++++++++++++
> .../libsamplerate/libsamplerate0_0.1.9.bb | 1 +
> 2 files changed, 14 insertions(+)
> create mode 100644 meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>
> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
> new file mode 100644
> index 0000000000..b42d564b4b
> --- /dev/null
> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
> @@ -0,0 +1,13 @@
> +Index: libsamplerate-0.1.8/configure.ac
> +===================================================================
> +--- libsamplerate-0.1.8.orig/configure.ac
> ++++ libsamplerate-0.1.8/configure.ac
> +@@ -53,7 +53,7 @@ AC_PROG_LN_S
> + # 6. If any interfaces have been removed since the last public release, then set age
> + # to 0.
> +
> +-SHARED_VERSION_INFO="1:8:1"
> ++SHARED_VERSION_INFO="1:9:1"
> +
it can be synthesized from PV, that will be better, since we dont have
to change it manually everytime version upgrade is done.
> +
> +
> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
> index 6dfc42b436..8345d6880f 100644
> --- a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
> @@ -10,6 +10,7 @@ PR = "r1"
>
> SRC_URI = "http://www.mega-nerd.com/SRC/libsamplerate-${PV}.tar.gz \
> file://0001-configure.ac-improve-alsa-handling.patch \
> + file://shared_version_info.patch \
> "
>
> SRC_URI[md5sum] = "2b78ae9fe63b36b9fbb6267fad93f259"
>
>
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#156294): https://lists.openembedded.org/g/openembedded-core/message/156294
> Mute This Topic: https://lists.openembedded.org/mt/85838060/1997914
> Group Owner: openembedded-core+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] libsamplerate0: Set correct soname for 0.1.9
2021-09-24 16:15 ` [OE-core] " Khem Raj
@ 2021-09-27 11:10 ` Tom Pollard
2021-09-27 15:40 ` Khem Raj
0 siblings, 1 reply; 4+ messages in thread
From: Tom Pollard @ 2021-09-27 11:10 UTC (permalink / raw)
To: Khem Raj, openembedded-core
Hi Khem,
On 24/09/2021 17:15, Khem Raj wrote:
>
>
> On 9/24/21 5:47 AM, Tom Pollard wrote:
>> Manually patch SHARED_VERSION_INFO, which was missed in
>> the 0.1.9 release and later incorrectly fixed until 0.2.1
>>
>> Signed-off-by: Tom Pollard <tom.pollard@codethink.co.uk>
>> ---
>> .../libsamplerate0/shared_version_info.patch | 13 +++++++++++++
>> .../libsamplerate/libsamplerate0_0.1.9.bb | 1 +
>> 2 files changed, 14 insertions(+)
>> create mode 100644 meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>>
>> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>> new file mode 100644
>> index 0000000000..b42d564b4b
>> --- /dev/null
>> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>> @@ -0,0 +1,13 @@
>> +Index: libsamplerate-0.1.8/configure.ac
>> +===================================================================
>> +--- libsamplerate-0.1.8.orig/configure.ac
>> ++++ libsamplerate-0.1.8/configure.ac
>> +@@ -53,7 +53,7 @@ AC_PROG_LN_S
>> + # 6. If any interfaces have been removed since the last public release, then set age
>> + # to 0.
>> +
>> +-SHARED_VERSION_INFO="1:8:1"
>> ++SHARED_VERSION_INFO="1:9:1"
>> +
>
> it can be synthesized from PV, that will be better, since we dont have
> to change it manually everytime version upgrade is done.
This patch is only required for this specific 0.1.9 release, it was
incorrectly 'fixed' across a number of commits going into the following
release 0.2.0, which is marked as do not use because of the issue:
https://github.com/libsndfile/libsamplerate/releases/tag/0.2.0
Once the recipe is bumped to the next release 0.2.1 and thus targets
github releases it the patch be dropped.
>
>> +
>> +
>> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>> index 6dfc42b436..8345d6880f 100644
>> --- a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>> @@ -10,6 +10,7 @@ PR = "r1"
>>
>> SRC_URI = "http://www.mega-nerd.com/SRC/libsamplerate-${PV}.tar.gz \
>> file://0001-configure.ac-improve-alsa-handling.patch \
>> + file://shared_version_info.patch \
>> "
>>
>> SRC_URI[md5sum] = "2b78ae9fe63b36b9fbb6267fad93f259"
>>
>>
>>
>>
>>
>>
>>
>> -=-=-=-=-=-=-=-=-=-=-=-
>> Links: You receive all messages sent to this group.
>> View/Reply Online (#156333): https://lists.openembedded.org/g/openembedded-core/message/156333
>> Mute This Topic: https://lists.openembedded.org/mt/85838060/2167528
>> Group Owner: openembedded-core+owner@lists.openembedded.org
>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [tom.pollard@codethink.co.uk]
>> -=-=-=-=-=-=-=-=-=-=-=-
>>
--
https://www.codethink.co.uk/privacy.html
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [OE-core] [PATCH] libsamplerate0: Set correct soname for 0.1.9
2021-09-27 11:10 ` Tom Pollard
@ 2021-09-27 15:40 ` Khem Raj
0 siblings, 0 replies; 4+ messages in thread
From: Khem Raj @ 2021-09-27 15:40 UTC (permalink / raw)
To: Tom Pollard, openembedded-core
On 9/27/21 4:10 AM, Tom Pollard wrote:
> Hi Khem,
>
> On 24/09/2021 17:15, Khem Raj wrote:
>>
>>
>> On 9/24/21 5:47 AM, Tom Pollard wrote:
>>> Manually patch SHARED_VERSION_INFO, which was missed in
>>> the 0.1.9 release and later incorrectly fixed until 0.2.1
>>>
>>> Signed-off-by: Tom Pollard <tom.pollard@codethink.co.uk>
>>> ---
>>> .../libsamplerate0/shared_version_info.patch | 13 +++++++++++++
>>> .../libsamplerate/libsamplerate0_0.1.9.bb | 1 +
>>> 2 files changed, 14 insertions(+)
>>> create mode 100644 meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>>>
>>> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>>> new file mode 100644
>>> index 0000000000..b42d564b4b
>>> --- /dev/null
>>> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0/shared_version_info.patch
>>> @@ -0,0 +1,13 @@
>>> +Index: libsamplerate-0.1.8/configure.ac
>>> +===================================================================
>>> +--- libsamplerate-0.1.8.orig/configure.ac
>>> ++++ libsamplerate-0.1.8/configure.ac
>>> +@@ -53,7 +53,7 @@ AC_PROG_LN_S
>>> + # 6. If any interfaces have been removed since the last public release, then set age
>>> + # to 0.
>>> +
>>> +-SHARED_VERSION_INFO="1:8:1"
>>> ++SHARED_VERSION_INFO="1:9:1"
>>> +
>>
>> it can be synthesized from PV, that will be better, since we dont have
>> to change it manually everytime version upgrade is done.
>
> This patch is only required for this specific 0.1.9 release, it was
> incorrectly 'fixed' across a number of commits going into the following
> release 0.2.0, which is marked as do not use because of the issue:
>
> https://github.com/libsndfile/libsamplerate/releases/tag/0.2.0
>
> Once the recipe is bumped to the next release 0.2.1 and thus targets
> github releases it the patch be dropped.
I see thanks for update. This is fine interim fix then.
>
>>
>>> +
>>> +
>>> diff --git a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>>> index 6dfc42b436..8345d6880f 100644
>>> --- a/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>>> +++ b/meta/recipes-multimedia/libsamplerate/libsamplerate0_0.1.9.bb
>>> @@ -10,6 +10,7 @@ PR = "r1"
>>>
>>> SRC_URI = "http://www.mega-nerd.com/SRC/libsamplerate-${PV}.tar.gz \
>>> file://0001-configure.ac-improve-alsa-handling.patch \
>>> + file://shared_version_info.patch \
>>> "
>>>
>>> SRC_URI[md5sum] = "2b78ae9fe63b36b9fbb6267fad93f259"
>>>
>>>
>>>
>>>
>>>
>>>
>>>
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>> Links: You receive all messages sent to this group.
>>> View/Reply Online (#156333): https://lists.openembedded.org/g/openembedded-core/message/156333
>>> Mute This Topic: https://lists.openembedded.org/mt/85838060/2167528
>>> Group Owner: openembedded-core+owner@lists.openembedded.org
>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [tom.pollard@codethink.co.uk]
>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-09-27 15:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-24 12:47 [PATCH] libsamplerate0: Set correct soname for 0.1.9 Tom Pollard
2021-09-24 16:15 ` [OE-core] " Khem Raj
2021-09-27 11:10 ` Tom Pollard
2021-09-27 15:40 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.