All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3 01/15] staging: greybus: shorten comparison to NULL
       [not found] <cover.1541771591.git.code@wizofe.uk>
@ 2018-11-09 13:53 ` Ioannis Valasakis
  2018-11-09 13:53 ` [PATCH v3 02/15] staging: greybus: align parameters to parentheses Ioannis Valasakis
                   ` (13 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Shorten pointer NULL check by simple truth test.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index dafa430d176e..5d14a4e8dada 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -48,7 +48,7 @@ static bool greybus_match_one_id(struct gb_bundle *bundle,
 static const struct greybus_bundle_id *
 greybus_match_id(struct gb_bundle *bundle, const struct greybus_bundle_id *id)
 {
-	if (id == NULL)
+	if (!id)
 		return NULL;
 
 	for (; id->vendor || id->product || id->class || id->driver_info;
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 02/15] staging: greybus: align parameters to parentheses
       [not found] <cover.1541771591.git.code@wizofe.uk>
  2018-11-09 13:53 ` [PATCH v3 01/15] staging: greybus: shorten comparison to NULL Ioannis Valasakis
@ 2018-11-09 13:53 ` Ioannis Valasakis
  2018-11-09 13:53 ` [PATCH v3 03/15] staging: greybus: add a blank line after declaration Ioannis Valasakis
                   ` (12 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Align parameters to the right side of the left parentheses
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/core.c b/drivers/staging/greybus/core.c
index 5d14a4e8dada..412337daf45c 100644
--- a/drivers/staging/greybus/core.c
+++ b/drivers/staging/greybus/core.c
@@ -28,7 +28,7 @@ int greybus_disabled(void)
 EXPORT_SYMBOL_GPL(greybus_disabled);
 
 static bool greybus_match_one_id(struct gb_bundle *bundle,
-				     const struct greybus_bundle_id *id)
+				 const struct greybus_bundle_id *id)
 {
 	if ((id->match_flags & GREYBUS_ID_MATCH_VENDOR) &&
 	    (id->vendor != bundle->intf->vendor_id))
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 03/15] staging: greybus: add a blank line after declaration
       [not found] <cover.1541771591.git.code@wizofe.uk>
  2018-11-09 13:53 ` [PATCH v3 01/15] staging: greybus: shorten comparison to NULL Ioannis Valasakis
  2018-11-09 13:53 ` [PATCH v3 02/15] staging: greybus: align parameters to parentheses Ioannis Valasakis
@ 2018-11-09 13:53 ` Ioannis Valasakis
  2018-11-09 17:47   ` Greg KH
  2018-11-09 13:53 ` [PATCH v3 04/15] staging: greybus: fix SPDX License Identifier Ioannis Valasakis
                   ` (11 subsequent siblings)
  14 siblings, 1 reply; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Add a blank line after the struct declaration.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 643ddb9e0f92..9c453e0b1b33 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -24,6 +24,7 @@ struct gb_control {
 	char *vendor_string;
 	char *product_string;
 };
+
 #define to_gb_control(d) container_of(d, struct gb_control, dev)
 
 struct gb_control *gb_control_create(struct gb_interface *intf);
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 04/15] staging: greybus: fix SPDX License Identifier
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (2 preceding siblings ...)
  2018-11-09 13:53 ` [PATCH v3 03/15] staging: greybus: add a blank line after declaration Ioannis Valasakis
@ 2018-11-09 13:53 ` Ioannis Valasakis
  2018-11-09 13:53 ` [PATCH v3 05/15] staging: greybus: align arguments with parentheses Ioannis Valasakis
                   ` (10 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Replace the SPDX identifier with standard C comment.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index 9c453e0b1b33..ebb7a2ee17dc 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus CPort control protocol
  *
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 05/15] staging: greybus: align arguments with parentheses
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (3 preceding siblings ...)
  2018-11-09 13:53 ` [PATCH v3 04/15] staging: greybus: fix SPDX License Identifier Ioannis Valasakis
@ 2018-11-09 13:53 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 06/15] staging: greybus: correct SPDX License Identifier Ioannis Valasakis
                   ` (9 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:53 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Align arguments with the right side of the open left parentheses.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/control.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
index ebb7a2ee17dc..5a45d55349a1 100644
--- a/drivers/staging/greybus/control.h
+++ b/drivers/staging/greybus/control.h
@@ -41,7 +41,7 @@ int gb_control_get_bundle_versions(struct gb_control *control);
 int gb_control_connected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnected_operation(struct gb_control *control, u16 cport_id);
 int gb_control_disconnecting_operation(struct gb_control *control,
-					u16 cport_id);
+				       u16 cport_id);
 int gb_control_mode_switch_operation(struct gb_control *control);
 void gb_control_mode_switch_prepare(struct gb_control *control);
 void gb_control_mode_switch_complete(struct gb_control *control);
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 06/15] staging: greybus: correct SPDX License Identifier
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (4 preceding siblings ...)
  2018-11-09 13:53 ` [PATCH v3 05/15] staging: greybus: align arguments with parentheses Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 07/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
                   ` (8 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Replace SPDX License Identifier comments with C comments.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/arche_platform.h        | 2 +-
 drivers/staging/greybus/arpc.h                  | 2 +-
 drivers/staging/greybus/audio_apbridgea.h       | 2 +-
 drivers/staging/greybus/audio_codec.h           | 2 +-
 drivers/staging/greybus/audio_manager.h         | 2 +-
 drivers/staging/greybus/audio_manager_private.h | 2 +-
 drivers/staging/greybus/bundle.h                | 2 +-
 drivers/staging/greybus/connection.h            | 2 +-
 8 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/drivers/staging/greybus/arche_platform.h b/drivers/staging/greybus/arche_platform.h
index 02056351d25a..9d997f2d6517 100644
--- a/drivers/staging/greybus/arche_platform.h
+++ b/drivers/staging/greybus/arche_platform.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Arche Platform driver to enable Unipro link.
  *
diff --git a/drivers/staging/greybus/arpc.h b/drivers/staging/greybus/arpc.h
index 3534ba1a4e6c..3dab6375909c 100644
--- a/drivers/staging/greybus/arpc.h
+++ b/drivers/staging/greybus/arpc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * This file is provided under a dual BSD/GPLv2 license.  When using or
  * redistributing this file, you may do so under either license.
diff --git a/drivers/staging/greybus/audio_apbridgea.h b/drivers/staging/greybus/audio_apbridgea.h
index 42ac6059bfc7..330fc7a397eb 100644
--- a/drivers/staging/greybus/audio_apbridgea.h
+++ b/drivers/staging/greybus/audio_apbridgea.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: BSD-3-Clause
+/* SPDX-License-Identifier: BSD-3-Clause */
 /**
  * Copyright (c) 2015-2016 Google Inc.
  * All rights reserved.
diff --git a/drivers/staging/greybus/audio_codec.h b/drivers/staging/greybus/audio_codec.h
index 4efd8b3ebe07..d36f8cd35e06 100644
--- a/drivers/staging/greybus/audio_codec.h
+++ b/drivers/staging/greybus/audio_codec.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus audio driver
  * Copyright 2015 Google Inc.
diff --git a/drivers/staging/greybus/audio_manager.h b/drivers/staging/greybus/audio_manager.h
index dcb1a20f5ff1..be605485a8ce 100644
--- a/drivers/staging/greybus/audio_manager.h
+++ b/drivers/staging/greybus/audio_manager.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *
diff --git a/drivers/staging/greybus/audio_manager_private.h b/drivers/staging/greybus/audio_manager_private.h
index 9d9b58fc54c4..2b3a766c7de7 100644
--- a/drivers/staging/greybus/audio_manager_private.h
+++ b/drivers/staging/greybus/audio_manager_private.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *
diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h
index ffcfd43802cc..8734d2055657 100644
--- a/drivers/staging/greybus/bundle.h
+++ b/drivers/staging/greybus/bundle.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus bundles
  *
diff --git a/drivers/staging/greybus/connection.h b/drivers/staging/greybus/connection.h
index ec3f1d3ef3b9..8deeb1d5f008 100644
--- a/drivers/staging/greybus/connection.h
+++ b/drivers/staging/greybus/connection.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus connections
  *
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 07/15] staging: greybus: remove multiple blank lines
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (5 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 06/15] staging: greybus: correct SPDX License Identifier Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 08/15] staging: greybus: insert empty line after struct Ioannis Valasakis
                   ` (7 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove continuous multiple blank lines.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/arche-apb-ctrl.c | 1 -
 drivers/staging/greybus/connection.c     | 4 ----
 2 files changed, 5 deletions(-)

diff --git a/drivers/staging/greybus/arche-apb-ctrl.c b/drivers/staging/greybus/arche-apb-ctrl.c
index cc8d6fc831b4..be5ffed90bcf 100644
--- a/drivers/staging/greybus/arche-apb-ctrl.c
+++ b/drivers/staging/greybus/arche-apb-ctrl.c
@@ -20,7 +20,6 @@
 #include <linux/spinlock.h>
 #include "arche_platform.h"
 
-
 static void apb_bootret_deassert(struct device *dev);
 
 struct arche_apb_ctrl_drvdata {
diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index 2103168b585e..56ae30533a70 100644
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -11,17 +11,13 @@
 #include "greybus.h"
 #include "greybus_trace.h"
 
-
 #define GB_CONNECTION_CPORT_QUIESCE_TIMEOUT	1000
 
-
 static void gb_connection_kref_release(struct kref *kref);
 
-
 static DEFINE_SPINLOCK(gb_connections_lock);
 static DEFINE_MUTEX(gb_connection_mutex);
 
-
 /* Caller holds gb_connection_mutex. */
 static bool gb_connection_cport_in_use(struct gb_interface *intf, u16 cport_id)
 {
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 08/15] staging: greybus: insert empty line after struct
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (6 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 07/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 17:47   ` Greg KH
  2018-11-09 13:54 ` [PATCH v3 09/15] staging: greybus: remove space before tab Ioannis Valasakis
                   ` (6 subsequent siblings)
  14 siblings, 1 reply; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Insert empty line after struct definition.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/bundle.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h
index 8734d2055657..4aaf7a0880fd 100644
--- a/drivers/staging/greybus/bundle.h
+++ b/drivers/staging/greybus/bundle.h
@@ -31,6 +31,7 @@ struct gb_bundle {
 
 	struct list_head	links;	/* interface->bundles */
 };
+
 #define to_gb_bundle(d) container_of(d, struct gb_bundle, dev)
 
 /* Greybus "private" definitions" */
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 09/15] staging: greybus: remove space before tab
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (7 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 08/15] staging: greybus: insert empty line after struct Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 10/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
                   ` (5 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove extra space before a tab character.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/uart.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/uart.c b/drivers/staging/greybus/uart.c
index 3313cb0b60af..b3bffe91ae99 100644
--- a/drivers/staging/greybus/uart.c
+++ b/drivers/staging/greybus/uart.c
@@ -805,8 +805,8 @@ static const struct tty_operations gb_ops = {
 	.tiocmget =		gb_tty_tiocmget,
 	.tiocmset =		gb_tty_tiocmset,
 	.get_icount =		gb_tty_get_icount,
-	.set_serial = 		set_serial_info,
-	.get_serial = 		get_serial_info,
+	.set_serial =		set_serial_info,
+	.get_serial =		get_serial_info,
 };
 
 static const struct tty_port_operations gb_port_ops = {
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 10/15] staging: greybus: remove multiple blank lines
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (8 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 09/15] staging: greybus: remove space before tab Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 11/15] staging: greybus: add extra space around OR operator Ioannis Valasakis
                   ` (4 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove extra blank lines to conform with coding style.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/greybus_protocols.h | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index 9bd7b6dfb476..f38f4a8db2b7 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -65,7 +65,6 @@
 #define GB_CONTROL_BUNDLE_ID			0
 #define GB_CONTROL_CPORT_ID			0
 
-
 /*
  * All operation messages (both requests and responses) begin with
  * a header that encodes the size of the message (header included).
@@ -95,7 +94,6 @@ struct gb_operation_msg_hdr {
 	__u8	pad[2];		/* must be zero (ignore when read) */
 } __packed;
 
-
 /* Generic request types */
 #define GB_REQUEST_TYPE_CPORT_SHUTDOWN		0x00
 #define GB_REQUEST_TYPE_INVALID			0x7f
@@ -104,7 +102,6 @@ struct gb_cport_shutdown_request {
 	__u8 phase;
 } __packed;
 
-
 /* Control Protocol */
 
 /* Greybus control request types */
@@ -249,7 +246,6 @@ struct gb_apb_request_cport_flags {
 #define GB_APB_CPORT_FLAG_HIGH_PRIO		0x02
 } __packed;
 
-
 /* Firmware Download Protocol */
 
 /* Request Types */
@@ -286,7 +282,6 @@ struct gb_fw_download_release_firmware_request {
 } __packed;
 /* firmware download release firmware response has no payload */
 
-
 /* Firmware Management Protocol */
 
 /* Request Types */
@@ -368,7 +363,6 @@ struct gb_fw_mgmt_backend_fw_updated_request {
 } __packed;
 /* firmware management backend firmware updated response has no payload */
 
-
 /* Component Authentication Protocol (CAP) */
 
 /* Request Types */
@@ -405,7 +399,6 @@ struct gb_cap_authenticate_response {
 	__u8			signature[0];
 } __packed;
 
-
 /* Bootrom Protocol */
 
 /* Version of the Greybus bootrom protocol we support */
@@ -474,7 +467,6 @@ struct gb_bootrom_get_vid_pid_response {
 	__le32			product_id;
 } __packed;
 
-
 /* Power Supply */
 
 /* Greybus power supply request types */
@@ -648,7 +640,6 @@ struct gb_power_supply_event_request {
 #define GB_POWER_SUPPLY_UPDATE		0x01
 } __packed;
 
-
 /* HID */
 
 /* Greybus HID operation types */
@@ -694,7 +685,6 @@ struct gb_hid_input_report_request {
 	__u8				report[0];
 } __packed;
 
-
 /* I2C */
 
 /* Greybus i2c request types */
@@ -730,7 +720,6 @@ struct gb_i2c_transfer_response {
 	__u8				data[0];	/* inbound data */
 } __packed;
 
-
 /* GPIO */
 
 /* Greybus GPIO request types */
@@ -829,7 +818,6 @@ struct gb_gpio_irq_event_request {
 } __packed;
 /* irq event has no response */
 
-
 /* PWM */
 
 /* Greybus PWM operation types */
@@ -1317,7 +1305,6 @@ struct gb_svc_intf_oops_request {
 } __packed;
 /* intf_oops response has no payload */
 
-
 /* RAW */
 
 /* Greybus raw request types */
@@ -1328,7 +1315,6 @@ struct gb_raw_send_request {
 	__u8	data[0];
 } __packed;
 
-
 /* UART */
 
 /* Greybus UART operation types */
@@ -2204,7 +2190,6 @@ struct gb_audio_send_data_request {
 	__u8	data[0];
 } __packed;
 
-
 /* Log */
 
 /* operations */
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 11/15] staging: greybus: add extra space around OR operator
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (9 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 10/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 12/15] staging: greybus: remove extra space before tab Ioannis Valasakis
                   ` (3 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Add extra spaces around the OR operator.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/greybus_protocols.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index f38f4a8db2b7..5783f715bdc2 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -866,10 +866,10 @@ struct gb_pwm_disable_request {
 /* Should match up with modes in linux/spi/spi.h */
 #define GB_SPI_MODE_CPHA		0x01		/* clock phase */
 #define GB_SPI_MODE_CPOL		0x02		/* clock polarity */
-#define GB_SPI_MODE_MODE_0		(0|0)		/* (original MicroWire) */
-#define GB_SPI_MODE_MODE_1		(0|GB_SPI_MODE_CPHA)
-#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL|0)
-#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL|GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_0		(0 | 0)		/* (original MicroWire) */
+#define GB_SPI_MODE_MODE_1		(0 | GB_SPI_MODE_CPHA)
+#define GB_SPI_MODE_MODE_2		(GB_SPI_MODE_CPOL | 0)
+#define GB_SPI_MODE_MODE_3		(GB_SPI_MODE_CPOL | GB_SPI_MODE_CPHA)
 #define GB_SPI_MODE_CS_HIGH		0x04		/* chipselect active high? */
 #define GB_SPI_MODE_LSB_FIRST		0x08		/* per-word bits-on-wire */
 #define GB_SPI_MODE_3WIRE		0x10		/* SI/SO signals shared */
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 12/15] staging: greybus: remove extra space before tab
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (10 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 11/15] staging: greybus: add extra space around OR operator Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:54 ` [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
                   ` (2 subsequent siblings)
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove extra spaces before the tab character inside a comment section.
Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/greybus_protocols.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index 5783f715bdc2..a0eb72cb225b 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -914,8 +914,8 @@ struct gb_spi_device_config_response {
 
 /**
  * struct gb_spi_transfer - a read/write buffer pair
- * @speed_hz: Select a speed other than the device default for this transfer. If
- *	0 the default (from @spi_device) is used.
+ * @speed_hz: Select a speed other than the device default for this transfer.
+ * If 0 the default (from @spi_device) is used.
  * @len: size of rx and tx buffers (in bytes)
  * @delay_usecs: microseconds to delay after this transfer before (optionally)
  * 	changing the chipselect status, then starting the next transfer or
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (11 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 12/15] staging: greybus: remove extra space before tab Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 17:48   ` Greg KH
  2018-11-09 13:54 ` [PATCH v3 14/15] staging: greybus: remove comparison to BOOL Ioannis Valasakis
  2018-11-09 13:55 ` [PATCH v3 15/15] staging: greybus: remove unmatched right bracket Ioannis Valasakis
  14 siblings, 1 reply; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Correct the SPDX License Identifiers by replacing the comment to C-style
comment. Reported by checkpatch.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/firmware.h               | 2 +-
 drivers/staging/greybus/gb-camera.h              | 2 +-
 drivers/staging/greybus/gbphy.h                  | 2 +-
 drivers/staging/greybus/greybus.h                | 2 +-
 drivers/staging/greybus/greybus_authentication.h | 2 +-
 drivers/staging/greybus/greybus_firmware.h       | 2 +-
 drivers/staging/greybus/greybus_manifest.h       | 2 +-
 drivers/staging/greybus/greybus_protocols.h      | 2 +-
 drivers/staging/greybus/greybus_trace.h          | 2 +-
 drivers/staging/greybus/hd.h                     | 2 +-
 drivers/staging/greybus/interface.h              | 2 +-
 drivers/staging/greybus/manifest.h               | 2 +-
 drivers/staging/greybus/module.h                 | 2 +-
 drivers/staging/greybus/operation.h              | 2 +-
 drivers/staging/greybus/spilib.h                 | 2 +-
 drivers/staging/greybus/svc.h                    | 2 +-
 16 files changed, 16 insertions(+), 16 deletions(-)

diff --git a/drivers/staging/greybus/firmware.h b/drivers/staging/greybus/firmware.h
index 946221307ef6..72dfabfa4704 100644
--- a/drivers/staging/greybus/firmware.h
+++ b/drivers/staging/greybus/firmware.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Firmware Management Header
  *
diff --git a/drivers/staging/greybus/gb-camera.h b/drivers/staging/greybus/gb-camera.h
index ee293e461fc3..5fc469101fc1 100644
--- a/drivers/staging/greybus/gb-camera.h
+++ b/drivers/staging/greybus/gb-camera.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Camera protocol driver.
  *
diff --git a/drivers/staging/greybus/gbphy.h b/drivers/staging/greybus/gbphy.h
index 99463489d7d6..087928a586fb 100644
--- a/drivers/staging/greybus/gbphy.h
+++ b/drivers/staging/greybus/gbphy.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Bridged-Phy Bus driver
  *
diff --git a/drivers/staging/greybus/greybus.h b/drivers/staging/greybus/greybus.h
index d03ddb7c9df0..f0488ffff93e 100644
--- a/drivers/staging/greybus/greybus.h
+++ b/drivers/staging/greybus/greybus.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus driver and device API
  *
diff --git a/drivers/staging/greybus/greybus_authentication.h b/drivers/staging/greybus/greybus_authentication.h
index 03ea9615b217..d654760cf175 100644
--- a/drivers/staging/greybus/greybus_authentication.h
+++ b/drivers/staging/greybus/greybus_authentication.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * Greybus Component Authentication User Header
  *
diff --git a/drivers/staging/greybus/greybus_firmware.h b/drivers/staging/greybus/greybus_firmware.h
index b58281a63ba4..13ef3aa5279e 100644
--- a/drivers/staging/greybus/greybus_firmware.h
+++ b/drivers/staging/greybus/greybus_firmware.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * Greybus Firmware Management User Header
  *
diff --git a/drivers/staging/greybus/greybus_manifest.h b/drivers/staging/greybus/greybus_manifest.h
index 2cec5cf7a846..db68f7e7d5a7 100644
--- a/drivers/staging/greybus/greybus_manifest.h
+++ b/drivers/staging/greybus/greybus_manifest.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus manifest definition
  *
diff --git a/drivers/staging/greybus/greybus_protocols.h b/drivers/staging/greybus/greybus_protocols.h
index a0eb72cb225b..071d946bd14f 100644
--- a/drivers/staging/greybus/greybus_protocols.h
+++ b/drivers/staging/greybus/greybus_protocols.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause)
+/* SPDX-License-Identifier: (GPL-2.0 OR BSD-3-Clause) */
 /*
  * This file is provided under a dual BSD/GPLv2 license.  When using or
  * redistributing this file, you may do so under either license.
diff --git a/drivers/staging/greybus/greybus_trace.h b/drivers/staging/greybus/greybus_trace.h
index 7b5e2c6b1f6b..1bc9f1275c65 100644
--- a/drivers/staging/greybus/greybus_trace.h
+++ b/drivers/staging/greybus/greybus_trace.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus driver and device API
  *
diff --git a/drivers/staging/greybus/hd.h b/drivers/staging/greybus/hd.h
index 6cf024a20a58..348b76fabc9a 100644
--- a/drivers/staging/greybus/hd.h
+++ b/drivers/staging/greybus/hd.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Host Device
  *
diff --git a/drivers/staging/greybus/interface.h b/drivers/staging/greybus/interface.h
index 1c00c5bb3ec9..8fb1eacda302 100644
--- a/drivers/staging/greybus/interface.h
+++ b/drivers/staging/greybus/interface.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Interface Block code
  *
diff --git a/drivers/staging/greybus/manifest.h b/drivers/staging/greybus/manifest.h
index f3c95a255631..88aa7e44cad5 100644
--- a/drivers/staging/greybus/manifest.h
+++ b/drivers/staging/greybus/manifest.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus manifest parsing
  *
diff --git a/drivers/staging/greybus/module.h b/drivers/staging/greybus/module.h
index b1ebcc6636db..2a27e520ee94 100644
--- a/drivers/staging/greybus/module.h
+++ b/drivers/staging/greybus/module.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus Module code
  *
diff --git a/drivers/staging/greybus/operation.h b/drivers/staging/greybus/operation.h
index 40b7b02fff88..17ba3daf111b 100644
--- a/drivers/staging/greybus/operation.h
+++ b/drivers/staging/greybus/operation.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus operations
  *
diff --git a/drivers/staging/greybus/spilib.h b/drivers/staging/greybus/spilib.h
index 043d4d32c3ee..9d416839e3be 100644
--- a/drivers/staging/greybus/spilib.h
+++ b/drivers/staging/greybus/spilib.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus SPI library header
  *
diff --git a/drivers/staging/greybus/svc.h b/drivers/staging/greybus/svc.h
index ad01783bac9c..e7452057cfe4 100644
--- a/drivers/staging/greybus/svc.h
+++ b/drivers/staging/greybus/svc.h
@@ -1,4 +1,4 @@
-// SPDX-License-Identifier: GPL-2.0
+/* SPDX-License-Identifier: GPL-2.0 */
 /*
  * Greybus SVC code
  *
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 14/15] staging: greybus: remove comparison to BOOL
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (12 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
@ 2018-11-09 13:54 ` Ioannis Valasakis
  2018-11-09 13:55 ` [PATCH v3 15/15] staging: greybus: remove unmatched right bracket Ioannis Valasakis
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:54 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove two instances of a comparison to BOOL.
Reported by coccinelle.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/es2.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/es2.c b/drivers/staging/greybus/es2.c
index b082d81833a0..b4e3d6a3d523 100644
--- a/drivers/staging/greybus/es2.c
+++ b/drivers/staging/greybus/es2.c
@@ -316,8 +316,8 @@ static struct urb *next_free_urb(struct es2_ap_dev *es2, gfp_t gfp_mask)
 
 	/* Look in our pool of allocated urbs first, as that's the "fastest" */
 	for (i = 0; i < NUM_CPORT_OUT_URB; ++i) {
-		if (es2->cport_out_urb_busy[i] == false &&
-				es2->cport_out_urb_cancelled[i] == false) {
+		if (!es2->cport_out_urb_busy[i] &&
+		    !es2->cport_out_urb_cancelled[i]) {
 			es2->cport_out_urb_busy[i] = true;
 			urb = es2->cport_out_urb[i];
 			break;
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* [PATCH v3 15/15] staging: greybus: remove unmatched right bracket
       [not found] <cover.1541771591.git.code@wizofe.uk>
                   ` (13 preceding siblings ...)
  2018-11-09 13:54 ` [PATCH v3 14/15] staging: greybus: remove comparison to BOOL Ioannis Valasakis
@ 2018-11-09 13:55 ` Ioannis Valasakis
  14 siblings, 0 replies; 18+ messages in thread
From: Ioannis Valasakis @ 2018-11-09 13:55 UTC (permalink / raw)
  To: outreachy-kernel; +Cc: gregkh

Remove unmatched right bracket. Reported by uncrustify.

Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
---
 drivers/staging/greybus/camera.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/staging/greybus/camera.c b/drivers/staging/greybus/camera.c
index 6dded10f4155..c6d65430ea4c 100644
--- a/drivers/staging/greybus/camera.c
+++ b/drivers/staging/greybus/camera.c
@@ -1190,7 +1190,6 @@ static int gb_camera_debugfs_init(struct gb_camera *gcam)
 		debugfs_create_file(entry->name, entry->mask,
 				    gcam->debugfs.root, gcam,
 				    &gb_camera_debugfs_ops);
-		}
 	}
 
 	return 0;
-- 
2.19.1




^ permalink raw reply related	[flat|nested] 18+ messages in thread
* Re: [PATCH v3 03/15] staging: greybus: add a blank line after declaration
  2018-11-09 13:53 ` [PATCH v3 03/15] staging: greybus: add a blank line after declaration Ioannis Valasakis
@ 2018-11-09 17:47   ` Greg KH
  0 siblings, 0 replies; 18+ messages in thread
From: Greg KH @ 2018-11-09 17:47 UTC (permalink / raw)
  To: Ioannis Valasakis; +Cc: outreachy-kernel

On Fri, Nov 09, 2018 at 01:53:39PM +0000, Ioannis Valasakis wrote:
> Add a blank line after the struct declaration.
> Reported by checkpatch.
> 
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/control.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/greybus/control.h b/drivers/staging/greybus/control.h
> index 643ddb9e0f92..9c453e0b1b33 100644
> --- a/drivers/staging/greybus/control.h
> +++ b/drivers/staging/greybus/control.h
> @@ -24,6 +24,7 @@ struct gb_control {
>  	char *vendor_string;
>  	char *product_string;
>  };
> +
>  #define to_gb_control(d) container_of(d, struct gb_control, dev)

Traditionally the "to_SOMETHING" #defines are right after the structure
definition.  So this is fine as-is.  I'll just drop it from the queue.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH v3 08/15] staging: greybus: insert empty line after struct
  2018-11-09 13:54 ` [PATCH v3 08/15] staging: greybus: insert empty line after struct Ioannis Valasakis
@ 2018-11-09 17:47   ` Greg KH
  0 siblings, 0 replies; 18+ messages in thread
From: Greg KH @ 2018-11-09 17:47 UTC (permalink / raw)
  To: Ioannis Valasakis; +Cc: outreachy-kernel

On Fri, Nov 09, 2018 at 01:54:17PM +0000, Ioannis Valasakis wrote:
> Insert empty line after struct definition.
> Reported by checkpatch.
> 
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/bundle.h | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/staging/greybus/bundle.h b/drivers/staging/greybus/bundle.h
> index 8734d2055657..4aaf7a0880fd 100644
> --- a/drivers/staging/greybus/bundle.h
> +++ b/drivers/staging/greybus/bundle.h
> @@ -31,6 +31,7 @@ struct gb_bundle {
>  
>  	struct list_head	links;	/* interface->bundles */
>  };
> +
>  #define to_gb_bundle(d) container_of(d, struct gb_bundle, dev)

Same thing here, it's ok as-is.

greg k-h


^ permalink raw reply	[flat|nested] 18+ messages in thread
* Re: [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers
  2018-11-09 13:54 ` [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
@ 2018-11-09 17:48   ` Greg KH
  0 siblings, 0 replies; 18+ messages in thread
From: Greg KH @ 2018-11-09 17:48 UTC (permalink / raw)
  To: Ioannis Valasakis; +Cc: outreachy-kernel

On Fri, Nov 09, 2018 at 01:54:51PM +0000, Ioannis Valasakis wrote:
> Correct the SPDX License Identifiers by replacing the comment to C-style
> comment. Reported by checkpatch.
> 
> Signed-off-by: Ioannis Valasakis <code@wizofe.uk>
> ---
>  drivers/staging/greybus/firmware.h               | 2 +-
>  drivers/staging/greybus/gb-camera.h              | 2 +-
>  drivers/staging/greybus/gbphy.h                  | 2 +-
>  drivers/staging/greybus/greybus.h                | 2 +-
>  drivers/staging/greybus/greybus_authentication.h | 2 +-
>  drivers/staging/greybus/greybus_firmware.h       | 2 +-
>  drivers/staging/greybus/greybus_manifest.h       | 2 +-
>  drivers/staging/greybus/greybus_protocols.h      | 2 +-
>  drivers/staging/greybus/greybus_trace.h          | 2 +-
>  drivers/staging/greybus/hd.h                     | 2 +-
>  drivers/staging/greybus/interface.h              | 2 +-
>  drivers/staging/greybus/manifest.h               | 2 +-
>  drivers/staging/greybus/module.h                 | 2 +-
>  drivers/staging/greybus/operation.h              | 2 +-
>  drivers/staging/greybus/spilib.h                 | 2 +-
>  drivers/staging/greybus/svc.h                    | 2 +-
>  16 files changed, 16 insertions(+), 16 deletions(-)

Not a problem, but why did you split this action into two different
patches at two different places in the patch series?  Next time just do
it all in one patch.

thanks,

greg k-h


^ permalink raw reply	[flat|nested] 18+ messages in thread
end of thread, other threads:[~2018-11-09 17:48 UTC | newest]

Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <cover.1541771591.git.code@wizofe.uk>
2018-11-09 13:53 ` [PATCH v3 01/15] staging: greybus: shorten comparison to NULL Ioannis Valasakis
2018-11-09 13:53 ` [PATCH v3 02/15] staging: greybus: align parameters to parentheses Ioannis Valasakis
2018-11-09 13:53 ` [PATCH v3 03/15] staging: greybus: add a blank line after declaration Ioannis Valasakis
2018-11-09 17:47   ` Greg KH
2018-11-09 13:53 ` [PATCH v3 04/15] staging: greybus: fix SPDX License Identifier Ioannis Valasakis
2018-11-09 13:53 ` [PATCH v3 05/15] staging: greybus: align arguments with parentheses Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 06/15] staging: greybus: correct SPDX License Identifier Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 07/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 08/15] staging: greybus: insert empty line after struct Ioannis Valasakis
2018-11-09 17:47   ` Greg KH
2018-11-09 13:54 ` [PATCH v3 09/15] staging: greybus: remove space before tab Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 10/15] staging: greybus: remove multiple blank lines Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 11/15] staging: greybus: add extra space around OR operator Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 12/15] staging: greybus: remove extra space before tab Ioannis Valasakis
2018-11-09 13:54 ` [PATCH v3 13/15] staging: greybus: correct SPDX license identifiers Ioannis Valasakis
2018-11-09 17:48   ` Greg KH
2018-11-09 13:54 ` [PATCH v3 14/15] staging: greybus: remove comparison to BOOL Ioannis Valasakis
2018-11-09 13:55 ` [PATCH v3 15/15] staging: greybus: remove unmatched right bracket Ioannis Valasakis

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.