From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org, Chao Yu <chao.yu@linux.dev> Subject: Re: [RFC NO MERGE] f2fs: extent cache: support unaligned extent Date: Tue, 3 Aug 2021 09:29:34 +0800 [thread overview] Message-ID: <a8291159-f625-c2a0-da73-7c30172f3d9a@kernel.org> (raw) In-Reply-To: <YQia9FBvQIRgr6cm@google.com> On 2021/8/3 9:25, Jaegeuk Kim wrote: > On 08/03, Chao Yu wrote: >> On 2021/8/3 2:03, Jaegeuk Kim wrote: >>> On 08/01, Chao Yu wrote: >>>> On 2021/7/31 3:20, Jaegeuk Kim wrote: >>>>> On 07/07, Chao Yu wrote: >>>>>> Currently, it only works in readonly format f2fs image. >>>> >>>> There wouldn't be any race condition because unaligned extent only works >>>> for ro feature now? >>> >>> Isn't your patch proposing on writable partition? >> >> Please check description in patch message, now it was designed only for > -- > what do you refer "it"? > >> compression case w/ ro feature, let's check and support rw partition later. > > Quite confused the patch description and code changes as well. You added some > change with this as well which is for RW. > > + if (is_inode_flag_set(dn->inode, FI_COMPRESSED_FILE) && > + !f2fs_sb_has_readonly(sbi)) { My bad, I've updated in my dev branch, but forgot to resend it...: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=dev&id=c3a40f6a186ba064f95432b308173d0a8fe375dc Thanks, > >> >> Thanks, >> >>> >>>> >>>>> Is there any race condition between the address in extent_cache and the one in >>>>> dnode? I feel that we could synchronize it by locking its dnode block. >>>> >>>> Thanks,
WARNING: multiple messages have this Message-ID (diff)
From: Chao Yu <chao@kernel.org> To: Jaegeuk Kim <jaegeuk@kernel.org> Cc: Chao Yu <chao.yu@linux.dev>, linux-kernel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net Subject: Re: [f2fs-dev] [RFC NO MERGE] f2fs: extent cache: support unaligned extent Date: Tue, 3 Aug 2021 09:29:34 +0800 [thread overview] Message-ID: <a8291159-f625-c2a0-da73-7c30172f3d9a@kernel.org> (raw) In-Reply-To: <YQia9FBvQIRgr6cm@google.com> On 2021/8/3 9:25, Jaegeuk Kim wrote: > On 08/03, Chao Yu wrote: >> On 2021/8/3 2:03, Jaegeuk Kim wrote: >>> On 08/01, Chao Yu wrote: >>>> On 2021/7/31 3:20, Jaegeuk Kim wrote: >>>>> On 07/07, Chao Yu wrote: >>>>>> Currently, it only works in readonly format f2fs image. >>>> >>>> There wouldn't be any race condition because unaligned extent only works >>>> for ro feature now? >>> >>> Isn't your patch proposing on writable partition? >> >> Please check description in patch message, now it was designed only for > -- > what do you refer "it"? > >> compression case w/ ro feature, let's check and support rw partition later. > > Quite confused the patch description and code changes as well. You added some > change with this as well which is for RW. > > + if (is_inode_flag_set(dn->inode, FI_COMPRESSED_FILE) && > + !f2fs_sb_has_readonly(sbi)) { My bad, I've updated in my dev branch, but forgot to resend it...: https://git.kernel.org/pub/scm/linux/kernel/git/chao/linux.git/commit/?h=dev&id=c3a40f6a186ba064f95432b308173d0a8fe375dc Thanks, > >> >> Thanks, >> >>> >>>> >>>>> Is there any race condition between the address in extent_cache and the one in >>>>> dnode? I feel that we could synchronize it by locking its dnode block. >>>> >>>> Thanks, _______________________________________________ Linux-f2fs-devel mailing list Linux-f2fs-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel
next prev parent reply other threads:[~2021-08-03 1:29 UTC|newest] Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-07-07 1:58 [RFC NO MERGE] f2fs: extent cache: support unaligned extent Chao Yu 2021-07-07 1:58 ` [f2fs-dev] " Chao Yu 2021-07-07 3:46 ` kernel test robot 2021-07-14 2:27 ` Chao Yu 2021-07-14 2:27 ` [f2fs-dev] " Chao Yu 2021-07-19 18:36 ` Jaegeuk Kim 2021-07-19 18:36 ` [f2fs-dev] " Jaegeuk Kim 2021-07-20 0:39 ` Chao Yu 2021-07-20 0:39 ` [f2fs-dev] " Chao Yu 2021-07-29 1:41 ` Chao Yu 2021-07-29 1:41 ` Chao Yu 2021-07-30 19:20 ` Jaegeuk Kim 2021-07-30 19:20 ` [f2fs-dev] " Jaegeuk Kim 2021-08-01 7:03 ` Chao Yu 2021-08-01 7:03 ` [f2fs-dev] " Chao Yu 2021-08-02 18:03 ` Jaegeuk Kim 2021-08-02 18:03 ` [f2fs-dev] " Jaegeuk Kim 2021-08-03 1:07 ` Chao Yu 2021-08-03 1:07 ` [f2fs-dev] " Chao Yu 2021-08-03 1:25 ` Jaegeuk Kim 2021-08-03 1:25 ` [f2fs-dev] " Jaegeuk Kim 2021-08-03 1:29 ` Chao Yu [this message] 2021-08-03 1:29 ` Chao Yu 2021-08-03 1:31 ` Chao Yu 2021-08-03 1:31 ` [f2fs-dev] " Chao Yu
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a8291159-f625-c2a0-da73-7c30172f3d9a@kernel.org \ --to=chao@kernel.org \ --cc=chao.yu@linux.dev \ --cc=jaegeuk@kernel.org \ --cc=linux-f2fs-devel@lists.sourceforge.net \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.