* [PATCH] tests: fix modules-test 'duplicate test case' error
@ 2019-11-13 21:09 Cole Robinson
2019-11-14 6:55 ` Marc-André Lureau
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Cole Robinson @ 2019-11-13 21:09 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Marc-André Lureau, Cole Robinson
./configure --enable-sdl --audio-drv-list=sdl --enable-modules
Will generate two identical test names: /$arch/module/load/sdl
Which generates an error like:
(tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl
Add the subsystem prefix in the name as well, so instead we get:
/$arch/module/load/audio-sdl
/$arch/module/load/ui-sdl
Signed-off-by: Cole Robinson <crobinso@redhat.com>
---
tests/modules-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/modules-test.c b/tests/modules-test.c
index d1a6ace218..88217686e1 100644
--- a/tests/modules-test.c
+++ b/tests/modules-test.c
@@ -64,7 +64,8 @@ int main(int argc, char *argv[])
g_test_init(&argc, &argv, NULL);
for (i = 0; i < G_N_ELEMENTS(modules); i += 2) {
- char *testname = g_strdup_printf("/module/load/%s", modules[i + 1]);
+ char *testname = g_strdup_printf("/module/load/%s%s",
+ modules[i], modules[i + 1]);
qtest_add_data_func(testname, modules + i, test_modules_load);
g_free(testname);
}
--
2.23.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] tests: fix modules-test 'duplicate test case' error
2019-11-13 21:09 [PATCH] tests: fix modules-test 'duplicate test case' error Cole Robinson
@ 2019-11-14 6:55 ` Marc-André Lureau
2019-11-14 11:32 ` Thomas Huth
2019-11-14 13:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Marc-André Lureau @ 2019-11-14 6:55 UTC (permalink / raw)
To: Cole Robinson; +Cc: qemu-trivial, qemu-devel
On Thu, Nov 14, 2019 at 1:09 AM Cole Robinson <crobinso@redhat.com> wrote:
>
> ./configure --enable-sdl --audio-drv-list=sdl --enable-modules
>
> Will generate two identical test names: /$arch/module/load/sdl
> Which generates an error like:
>
> (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl
>
> Add the subsystem prefix in the name as well, so instead we get:
>
> /$arch/module/load/audio-sdl
> /$arch/module/load/ui-sdl
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
> ---
> tests/modules-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index d1a6ace218..88217686e1 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -64,7 +64,8 @@ int main(int argc, char *argv[])
> g_test_init(&argc, &argv, NULL);
>
> for (i = 0; i < G_N_ELEMENTS(modules); i += 2) {
> - char *testname = g_strdup_printf("/module/load/%s", modules[i + 1]);
> + char *testname = g_strdup_printf("/module/load/%s%s",
> + modules[i], modules[i + 1]);
> qtest_add_data_func(testname, modules + i, test_modules_load);
> g_free(testname);
> }
> --
> 2.23.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests: fix modules-test 'duplicate test case' error
2019-11-13 21:09 [PATCH] tests: fix modules-test 'duplicate test case' error Cole Robinson
2019-11-14 6:55 ` Marc-André Lureau
@ 2019-11-14 11:32 ` Thomas Huth
2019-11-14 13:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Huth @ 2019-11-14 11:32 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: qemu-trivial, Marc-André Lureau
On 13/11/2019 22.09, Cole Robinson wrote:
> ./configure --enable-sdl --audio-drv-list=sdl --enable-modules
>
> Will generate two identical test names: /$arch/module/load/sdl
> Which generates an error like:
>
> (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl
>
> Add the subsystem prefix in the name as well, so instead we get:
>
> /$arch/module/load/audio-sdl
> /$arch/module/load/ui-sdl
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> tests/modules-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index d1a6ace218..88217686e1 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -64,7 +64,8 @@ int main(int argc, char *argv[])
> g_test_init(&argc, &argv, NULL);
>
> for (i = 0; i < G_N_ELEMENTS(modules); i += 2) {
> - char *testname = g_strdup_printf("/module/load/%s", modules[i + 1]);
> + char *testname = g_strdup_printf("/module/load/%s%s",
> + modules[i], modules[i + 1]);
> qtest_add_data_func(testname, modules + i, test_modules_load);
> g_free(testname);
> }
>
Reviewed-by: Thomas Huth <thuth@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] tests: fix modules-test 'duplicate test case' error
2019-11-13 21:09 [PATCH] tests: fix modules-test 'duplicate test case' error Cole Robinson
2019-11-14 6:55 ` Marc-André Lureau
2019-11-14 11:32 ` Thomas Huth
@ 2019-11-14 13:40 ` Philippe Mathieu-Daudé
2 siblings, 0 replies; 4+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-11-14 13:40 UTC (permalink / raw)
To: Cole Robinson, qemu-devel; +Cc: qemu-trivial, Marc-André Lureau
On 11/13/19 10:09 PM, Cole Robinson wrote:
> ./configure --enable-sdl --audio-drv-list=sdl --enable-modules
>
> Will generate two identical test names: /$arch/module/load/sdl
> Which generates an error like:
>
> (tests/modules-test:23814): GLib-ERROR **: 18:23:06.359: duplicate test case path: /aarch64//module/load/sdl
>
> Add the subsystem prefix in the name as well, so instead we get:
>
> /$arch/module/load/audio-sdl
> /$arch/module/load/ui-sdl
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> tests/modules-test.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/tests/modules-test.c b/tests/modules-test.c
> index d1a6ace218..88217686e1 100644
> --- a/tests/modules-test.c
> +++ b/tests/modules-test.c
> @@ -64,7 +64,8 @@ int main(int argc, char *argv[])
> g_test_init(&argc, &argv, NULL);
>
> for (i = 0; i < G_N_ELEMENTS(modules); i += 2) {
> - char *testname = g_strdup_printf("/module/load/%s", modules[i + 1]);
> + char *testname = g_strdup_printf("/module/load/%s%s",
> + modules[i], modules[i + 1]);
> qtest_add_data_func(testname, modules + i, test_modules_load);
> g_free(testname);
> }
>
Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-11-14 13:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-13 21:09 [PATCH] tests: fix modules-test 'duplicate test case' error Cole Robinson
2019-11-14 6:55 ` Marc-André Lureau
2019-11-14 11:32 ` Thomas Huth
2019-11-14 13:40 ` Philippe Mathieu-Daudé
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.