All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 14:01 ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 14:01 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: monstr, Josh Cartwright, Steffen Trumtrar, Rob Herring,
	Peter Crosthwaite, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 595 bytes --]

Add missing reference for ADC node.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 772381fe07bb..fc90f47f9c03 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -64,7 +64,7 @@
 		interrupt-parent = <&intc>;
 		ranges;

-		adc@f8007100 {
+		adc: adc@f8007100 {
 			compatible = "xlnx,zynq-xadc-1.00.a";
 			reg = <0xf8007100 0x20>;
 			interrupts = <0 7 4>;
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 14:01 ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

Add missing reference for ADC node.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index 772381fe07bb..fc90f47f9c03 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -64,7 +64,7 @@
 		interrupt-parent = <&intc>;
 		ranges;

-		adc at f8007100 {
+		adc: adc at f8007100 {
 			compatible = "xlnx,zynq-xadc-1.00.a";
 			reg = <0xf8007100 0x20>;
 			interrupts = <0 7 4>;
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140924/ea25650a/attachment.sig>

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller
  2014-09-24 14:01 ` Michal Simek
@ 2014-09-24 14:01   ` Michal Simek
  -1 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 14:01 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: monstr, Josh Cartwright, Steffen Trumtrar, Rob Herring,
	Peter Crosthwaite, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, devicetree, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

Add missing reference for memory-controller.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index fc90f47f9c03..2690e6d01f71 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -145,7 +145,7 @@
 			cache-level = <2>;
 		};

-		memory-controller@f8006000 {
+		mc: memory-controller@f8006000 {
 			compatible = "xlnx,zynq-ddrc-a05";
 			reg = <0xf8006000 0x1000>;
 		} ;
--
1.8.2.3


[-- Attachment #2: Type: application/pgp-signature, Size: 198 bytes --]

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller
@ 2014-09-24 14:01   ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 14:01 UTC (permalink / raw)
  To: linux-arm-kernel

Add missing reference for memory-controller.

Signed-off-by: Michal Simek <michal.simek@xilinx.com>
---

 arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
index fc90f47f9c03..2690e6d01f71 100644
--- a/arch/arm/boot/dts/zynq-7000.dtsi
+++ b/arch/arm/boot/dts/zynq-7000.dtsi
@@ -145,7 +145,7 @@
 			cache-level = <2>;
 		};

-		memory-controller at f8006000 {
+		mc: memory-controller at f8006000 {
 			compatible = "xlnx,zynq-ddrc-a05";
 			reg = <0xf8006000 0x1000>;
 		} ;
--
1.8.2.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140924/c16a8e15/attachment-0001.sig>

^ permalink raw reply related	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
  2014-09-24 14:01 ` Michal Simek
  (?)
@ 2014-09-24 16:18   ` Sören Brinkmann
  -1 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:18 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-arm-kernel, monstr, Josh Cartwright, Steffen Trumtrar,
	Rob Herring, Peter Crosthwaite, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for ADC node.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 772381fe07bb..fc90f47f9c03 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -64,7 +64,7 @@
>  		interrupt-parent = <&intc>;
>  		ranges;
> 
> -		adc@f8007100 {
> +		adc: adc@f8007100 {
I think we enumerated all labels. I.e. 'adc0' is probably better.

	Sören

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 16:18   ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:18 UTC (permalink / raw)
  To: Michal Simek
  Cc: Mark Rutland, Josh Cartwright, monstr, Russell King, Pawel Moll,
	Ian Campbell, Peter Crosthwaite, linux-kernel, devicetree,
	Rob Herring, Kumar Gala, Steffen Trumtrar, linux-arm-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for ADC node.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 772381fe07bb..fc90f47f9c03 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -64,7 +64,7 @@
>  		interrupt-parent = <&intc>;
>  		ranges;
> 
> -		adc@f8007100 {
> +		adc: adc@f8007100 {
I think we enumerated all labels. I.e. 'adc0' is probably better.

	Sören

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 16:18   ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:18 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for ADC node.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index 772381fe07bb..fc90f47f9c03 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -64,7 +64,7 @@
>  		interrupt-parent = <&intc>;
>  		ranges;
> 
> -		adc at f8007100 {
> +		adc: adc at f8007100 {
I think we enumerated all labels. I.e. 'adc0' is probably better.

	S?ren

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller
  2014-09-24 14:01   ` Michal Simek
  (?)
@ 2014-09-24 16:19     ` Sören Brinkmann
  -1 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:19 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-arm-kernel, monstr, Josh Cartwright, Steffen Trumtrar,
	Rob Herring, Peter Crosthwaite, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for memory-controller.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index fc90f47f9c03..2690e6d01f71 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -145,7 +145,7 @@
>  			cache-level = <2>;
>  		};
> 
> -		memory-controller@f8006000 {
> +		mc: memory-controller@f8006000 {
same here. 'mc0', there are definitely options to add more memory
controllers to Zynq in the PL. Also, I'd spell it out instead of
abbreviating the name.

	Sören

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller
@ 2014-09-24 16:19     ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:19 UTC (permalink / raw)
  To: Michal Simek
  Cc: Mark Rutland, Josh Cartwright, monstr, Russell King, Pawel Moll,
	Ian Campbell, Peter Crosthwaite, linux-kernel, devicetree,
	Rob Herring, Kumar Gala, Steffen Trumtrar, linux-arm-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for memory-controller.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index fc90f47f9c03..2690e6d01f71 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -145,7 +145,7 @@
>  			cache-level = <2>;
>  		};
> 
> -		memory-controller@f8006000 {
> +		mc: memory-controller@f8006000 {
same here. 'mc0', there are definitely options to add more memory
controllers to Zynq in the PL. Also, I'd spell it out instead of
abbreviating the name.

	Sören

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller
@ 2014-09-24 16:19     ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 16:19 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> Add missing reference for memory-controller.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
> 
>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> index fc90f47f9c03..2690e6d01f71 100644
> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> @@ -145,7 +145,7 @@
>  			cache-level = <2>;
>  		};
> 
> -		memory-controller at f8006000 {
> +		mc: memory-controller at f8006000 {
same here. 'mc0', there are definitely options to add more memory
controllers to Zynq in the PL. Also, I'd spell it out instead of
abbreviating the name.

	S?ren

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
       [not found] ` <20140924161814.GG13679@xsjandreislx>
  2014-09-24 17:06     ` Michal Simek
@ 2014-09-24 17:06     ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 17:06 UTC (permalink / raw)
  To: Sören Brinkmann, Michal Simek
  Cc: linux-arm-kernel, monstr, Josh Cartwright, Steffen Trumtrar,
	Rob Herring, Peter Crosthwaite, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-kernel

On 09/24/2014 06:18 PM, Sören Brinkmann wrote:
> On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
>> Add missing reference for ADC node.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 772381fe07bb..fc90f47f9c03 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -64,7 +64,7 @@
>>  		interrupt-parent = <&intc>;
>>  		ranges;
>>
>> -		adc@f8007100 {
>> +		adc: adc@f8007100 {
> I think we enumerated all labels. I.e. 'adc0' is probably better.

I was thinking about it and the reason I didn't use that adc0 was
that it is unique and it is just one in PS. Maybe there could be another adc in PL
but it will be probably automated not to use adc key world.
For PL part names was depending on user description.

Anyway logic was not to use enumerated label for unique IPs.

Thanks,
Michal


^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 17:06     ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 17:06 UTC (permalink / raw)
  To: Sören Brinkmann, Michal Simek
  Cc: linux-arm-kernel, monstr, Josh Cartwright, Steffen Trumtrar,
	Rob Herring, Peter Crosthwaite, Rob Herring, Pawel Moll,
	Mark Rutland, Ian Campbell, Kumar Gala, Russell King, devicetree,
	linux-kernel

On 09/24/2014 06:18 PM, Sören Brinkmann wrote:
> On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
>> Add missing reference for ADC node.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 772381fe07bb..fc90f47f9c03 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -64,7 +64,7 @@
>>  		interrupt-parent = <&intc>;
>>  		ranges;
>>
>> -		adc@f8007100 {
>> +		adc: adc@f8007100 {
> I think we enumerated all labels. I.e. 'adc0' is probably better.

I was thinking about it and the reason I didn't use that adc0 was
that it is unique and it is just one in PS. Maybe there could be another adc in PL
but it will be probably automated not to use adc key world.
For PL part names was depending on user description.

Anyway logic was not to use enumerated label for unique IPs.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 17:06     ` Michal Simek
  0 siblings, 0 replies; 16+ messages in thread
From: Michal Simek @ 2014-09-24 17:06 UTC (permalink / raw)
  To: linux-arm-kernel

On 09/24/2014 06:18 PM, S?ren Brinkmann wrote:
> On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
>> Add missing reference for ADC node.
>>
>> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
>> ---
>>
>>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
>> index 772381fe07bb..fc90f47f9c03 100644
>> --- a/arch/arm/boot/dts/zynq-7000.dtsi
>> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
>> @@ -64,7 +64,7 @@
>>  		interrupt-parent = <&intc>;
>>  		ranges;
>>
>> -		adc at f8007100 {
>> +		adc: adc at f8007100 {
> I think we enumerated all labels. I.e. 'adc0' is probably better.

I was thinking about it and the reason I didn't use that adc0 was
that it is unique and it is just one in PS. Maybe there could be another adc in PL
but it will be probably automated not to use adc key world.
For PL part names was depending on user description.

Anyway logic was not to use enumerated label for unique IPs.

Thanks,
Michal

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 17:09       ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 17:09 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-arm-kernel, monstr, Steffen Trumtrar, Rob Herring,
	Peter Crosthwaite, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King, devicetree, linux-kernel

On Wed, 2014-09-24 at 07:06PM +0200, Michal Simek wrote:
> On 09/24/2014 06:18 PM, Sören Brinkmann wrote:
> > On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> >> Add missing reference for ADC node.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 772381fe07bb..fc90f47f9c03 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -64,7 +64,7 @@
> >>  		interrupt-parent = <&intc>;
> >>  		ranges;
> >>
> >> -		adc@f8007100 {
> >> +		adc: adc@f8007100 {
> > I think we enumerated all labels. I.e. 'adc0' is probably better.
> 
> I was thinking about it and the reason I didn't use that adc0 was
> that it is unique and it is just one in PS. Maybe there could be another adc in PL
> but it will be probably automated not to use adc key world.
> For PL part names was depending on user description.
> 
> Anyway logic was not to use enumerated label for unique IPs.
As you said yourself, due to having/being an FPGA and also the
extensibility of the platform via buses (including PCIe), I
would not consider any IP to be unique.

	Sören

^ permalink raw reply	[flat|nested] 16+ messages in thread
* Re: [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 17:09       ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 17:09 UTC (permalink / raw)
  To: Michal Simek
  Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
	monstr-pSz03upnqPeHXe+LvDLADg, Steffen Trumtrar, Rob Herring,
	Peter Crosthwaite, Rob Herring, Pawel Moll, Mark Rutland,
	Ian Campbell, Kumar Gala, Russell King,
	devicetree-u79uwXL29TY76Z2rM5mHXA,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA

On Wed, 2014-09-24 at 07:06PM +0200, Michal Simek wrote:
> On 09/24/2014 06:18 PM, Sören Brinkmann wrote:
> > On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> >> Add missing reference for ADC node.
> >>
> >> Signed-off-by: Michal Simek <michal.simek-gjFFaj9aHVfQT0dZR+AlfA@public.gmane.org>
> >> ---
> >>
> >>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 772381fe07bb..fc90f47f9c03 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -64,7 +64,7 @@
> >>  		interrupt-parent = <&intc>;
> >>  		ranges;
> >>
> >> -		adc@f8007100 {
> >> +		adc: adc@f8007100 {
> > I think we enumerated all labels. I.e. 'adc0' is probably better.
> 
> I was thinking about it and the reason I didn't use that adc0 was
> that it is unique and it is just one in PS. Maybe there could be another adc in PL
> but it will be probably automated not to use adc key world.
> For PL part names was depending on user description.
> 
> Anyway logic was not to use enumerated label for unique IPs.
As you said yourself, due to having/being an FPGA and also the
extensibility of the platform via buses (including PCIe), I
would not consider any IP to be unique.

	Sören
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

^ permalink raw reply	[flat|nested] 16+ messages in thread
* [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC
@ 2014-09-24 17:09       ` Sören Brinkmann
  0 siblings, 0 replies; 16+ messages in thread
From: Sören Brinkmann @ 2014-09-24 17:09 UTC (permalink / raw)
  To: linux-arm-kernel

On Wed, 2014-09-24 at 07:06PM +0200, Michal Simek wrote:
> On 09/24/2014 06:18 PM, S?ren Brinkmann wrote:
> > On Wed, 2014-09-24 at 04:01PM +0200, Michal Simek wrote:
> >> Add missing reference for ADC node.
> >>
> >> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> >> ---
> >>
> >>  arch/arm/boot/dts/zynq-7000.dtsi | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/arch/arm/boot/dts/zynq-7000.dtsi b/arch/arm/boot/dts/zynq-7000.dtsi
> >> index 772381fe07bb..fc90f47f9c03 100644
> >> --- a/arch/arm/boot/dts/zynq-7000.dtsi
> >> +++ b/arch/arm/boot/dts/zynq-7000.dtsi
> >> @@ -64,7 +64,7 @@
> >>  		interrupt-parent = <&intc>;
> >>  		ranges;
> >>
> >> -		adc at f8007100 {
> >> +		adc: adc at f8007100 {
> > I think we enumerated all labels. I.e. 'adc0' is probably better.
> 
> I was thinking about it and the reason I didn't use that adc0 was
> that it is unique and it is just one in PS. Maybe there could be another adc in PL
> but it will be probably automated not to use adc key world.
> For PL part names was depending on user description.
> 
> Anyway logic was not to use enumerated label for unique IPs.
As you said yourself, due to having/being an FPGA and also the
extensibility of the platform via buses (including PCIe), I
would not consider any IP to be unique.

	S?ren

^ permalink raw reply	[flat|nested] 16+ messages in thread
end of thread, other threads:[~2014-09-24 17:09 UTC | newest]

Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-24 14:01 [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC Michal Simek
2014-09-24 14:01 ` Michal Simek
2014-09-24 14:01 ` [PATCH 2/2] ARM: zynq: DT: Add missing reference for memory-controller Michal Simek
2014-09-24 14:01   ` Michal Simek
2014-09-24 16:19   ` Sören Brinkmann
2014-09-24 16:19     ` Sören Brinkmann
2014-09-24 16:19     ` Sören Brinkmann
2014-09-24 16:18 ` [PATCH 1/2] ARM: zynq: DT: Add missing reference for ADC Sören Brinkmann
2014-09-24 16:18   ` Sören Brinkmann
2014-09-24 16:18   ` Sören Brinkmann
     [not found] ` <20140924161814.GG13679@xsjandreislx>
2014-09-24 17:06   ` Michal Simek
2014-09-24 17:06     ` Michal Simek
2014-09-24 17:06     ` Michal Simek
2014-09-24 17:09     ` Sören Brinkmann
2014-09-24 17:09       ` Sören Brinkmann
2014-09-24 17:09       ` Sören Brinkmann

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.