From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Ryan Lee <RyanS.Lee@maximintegrated.com>, Mark Brown <broonie@kernel.org> Cc: "guennadi.liakhovetski@linux.intel.com" <guennadi.liakhovetski@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>, "tiwai@suse.com" <tiwai@suse.com>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "sathya.prakash.m.r@intel.com" <sathya.prakash.m.r@intel.com>, "yung-chuan.liao@linux.intel.com" <yung-chuan.liao@linux.intel.com> Subject: Re: [EXTERNAL] Re: [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Date: Tue, 28 Sep 2021 13:15:31 -0500 [thread overview] Message-ID: <a8d2f176-df63-f81b-e47a-73b1c436b612@linux.intel.com> (raw) In-Reply-To: <SJ0PR11MB56618B8B6DE3922613E83C15E7A89@SJ0PR11MB5661.namprd11.prod.outlook.com> >>>> Instead of changing the suspend sequence, can we please try to modify >>>> the max98373_io_init() routine to unconditionally flag the cache as >>>> dirty, maybe this points to a problem with the management of the >>>> max98373->first_hw_init flag. >>> >>> A quick survey of other drivers suggests that this pattern should be >>> factored out into some helpers as it looks like there's several ways >>> of implementing it that look very similar but not quite the same... >> >> No disagreement here, we tried really hard to enforce a common pattern for >> suspend-resume, but i just noticed that the maxim amp driver is different on >> suspend (resume is consistent with the rest). > > OK. I believe it was similar before. But it looks like 'regcache_mark_dirty' is being > disappeared on suspend function. Not sure what you are trying to say? > static int __maybe_unused rt5682_dev_suspend(struct device *dev) > { > struct rt5682_priv *rt5682 = dev_get_drvdata(dev); > > if (!rt5682->hw_init) > return 0; > > cancel_delayed_work_sync(&rt5682->jack_detect_work); > > regcache_cache_only(rt5682->regmap, true); > regcache_mark_dirty(rt5682->regmap); > > return 0; > } That last line is also not needed. If you look at rt5682-sdw.c, you'll see a regcache_mark_dirty() when the device is re-initialized. But now I am starting to wonder if this is due to Chrome kernel differences and possibly a missing backport patch? I no longer believe in coincidences, these two devices are ONLY used in Chromebooks so far...
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> To: Ryan Lee <RyanS.Lee@maximintegrated.com>, Mark Brown <broonie@kernel.org> Cc: "guennadi.liakhovetski@linux.intel.com" <guennadi.liakhovetski@linux.intel.com>, "alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>, "ryan.lee.maxim@gmail.com" <ryan.lee.maxim@gmail.com>, "lgirdwood@gmail.com" <lgirdwood@gmail.com>, "tiwai@suse.com" <tiwai@suse.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "sathya.prakash.m.r@intel.com" <sathya.prakash.m.r@intel.com>, "yung-chuan.liao@linux.intel.com" <yung-chuan.liao@linux.intel.com> Subject: Re: [EXTERNAL] Re: [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Date: Tue, 28 Sep 2021 13:15:31 -0500 [thread overview] Message-ID: <a8d2f176-df63-f81b-e47a-73b1c436b612@linux.intel.com> (raw) In-Reply-To: <SJ0PR11MB56618B8B6DE3922613E83C15E7A89@SJ0PR11MB5661.namprd11.prod.outlook.com> >>>> Instead of changing the suspend sequence, can we please try to modify >>>> the max98373_io_init() routine to unconditionally flag the cache as >>>> dirty, maybe this points to a problem with the management of the >>>> max98373->first_hw_init flag. >>> >>> A quick survey of other drivers suggests that this pattern should be >>> factored out into some helpers as it looks like there's several ways >>> of implementing it that look very similar but not quite the same... >> >> No disagreement here, we tried really hard to enforce a common pattern for >> suspend-resume, but i just noticed that the maxim amp driver is different on >> suspend (resume is consistent with the rest). > > OK. I believe it was similar before. But it looks like 'regcache_mark_dirty' is being > disappeared on suspend function. Not sure what you are trying to say? > static int __maybe_unused rt5682_dev_suspend(struct device *dev) > { > struct rt5682_priv *rt5682 = dev_get_drvdata(dev); > > if (!rt5682->hw_init) > return 0; > > cancel_delayed_work_sync(&rt5682->jack_detect_work); > > regcache_cache_only(rt5682->regmap, true); > regcache_mark_dirty(rt5682->regmap); > > return 0; > } That last line is also not needed. If you look at rt5682-sdw.c, you'll see a regcache_mark_dirty() when the device is re-initialized. But now I am starting to wonder if this is due to Chrome kernel differences and possibly a missing backport patch? I no longer believe in coincidences, these two devices are ONLY used in Chromebooks so far...
next prev parent reply other threads:[~2021-09-28 18:15 UTC|newest] Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-09-24 22:13 [PATCH] ASoC: max98373: Mark cache dirty before entering sleep Ryan Lee 2021-09-27 14:54 ` Pierre-Louis Bossart 2021-09-27 16:01 ` [EXTERNAL] " Ryan Lee 2021-09-27 16:01 ` Ryan Lee 2021-09-27 16:06 ` Mark Brown 2021-09-27 16:06 ` Mark Brown 2021-09-27 16:48 ` Pierre-Louis Bossart 2021-09-27 16:48 ` Pierre-Louis Bossart 2021-09-27 17:10 ` Mark Brown 2021-09-27 17:10 ` Mark Brown 2021-09-27 17:23 ` Pierre-Louis Bossart 2021-09-27 17:23 ` Pierre-Louis Bossart 2021-09-27 17:29 ` Mark Brown 2021-09-27 17:29 ` Mark Brown 2021-09-28 16:43 ` Ryan Lee 2021-09-28 16:43 ` Ryan Lee 2021-09-28 18:15 ` Pierre-Louis Bossart [this message] 2021-09-28 18:15 ` Pierre-Louis Bossart 2021-09-27 18:44 ` Ryan Lee 2021-09-27 18:44 ` Ryan Lee 2021-09-27 19:34 ` Pierre-Louis Bossart 2021-09-27 19:34 ` Pierre-Louis Bossart 2021-09-27 22:43 ` Ryan Lee 2021-09-27 22:43 ` Ryan Lee 2021-09-30 6:21 ` Ryan Lee 2021-09-30 6:21 ` Ryan Lee 2021-09-30 13:29 ` Pierre-Louis Bossart 2021-09-30 13:29 ` Pierre-Louis Bossart 2021-09-30 23:31 ` Ryan Lee 2021-09-30 23:31 ` Ryan Lee 2021-09-30 23:53 ` Pierre-Louis Bossart 2021-09-30 23:53 ` Pierre-Louis Bossart
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=a8d2f176-df63-f81b-e47a-73b1c436b612@linux.intel.com \ --to=pierre-louis.bossart@linux.intel.com \ --cc=RyanS.Lee@maximintegrated.com \ --cc=alsa-devel@alsa-project.org \ --cc=broonie@kernel.org \ --cc=guennadi.liakhovetski@linux.intel.com \ --cc=lgirdwood@gmail.com \ --cc=linux-kernel@vger.kernel.org \ --cc=ryan.lee.maxim@gmail.com \ --cc=sathya.prakash.m.r@intel.com \ --cc=tiwai@suse.com \ --cc=yung-chuan.liao@linux.intel.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.