Re: Request to Revert 'recipes: rename distro_features_check to features_check' comit on meta-java zeus branch

Re: Request to Revert 'recipes: rename distro_features_check to features_check' comit on meta-java zeus branch

[Alex Kiernan]

On Tue, Mar 31, 2020 at 5:46 AM Geoff Parker
<Geoffrey.Parker@arthrex.com> wrote:
>
> Hi Alex,
>
> We  moved one of our products to the zeus Yocto 3.0 meta layer branches. It recently stopped building due to this commit on the meta-java zeus branch:
>
> commit d2e962a795e8713e5443659669842298453d938f
> Author: Alex Kiernan <alex.kiernan@gmail.com>
> Date:   Sat Dec 7 18:07:38 2019 +0000
>
>    recipes: rename distro_features_check to features_check
>
>    Avoid warning due to the class rename in OE-Core.
>
>    Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
>    Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>
> Although this change is appropriate for the Yocto 3.1 branches, it breaks our build on Yocto 3.0 zeus because the zeus branch of the openembedded-core layer does not have the features_check class.
>
> The following recipes fail to parse:
>
>   openjdk-7_99b00-2.6.5.bb
>   classpath_0.99.bb
>   cacao_2d6fc614daf9.bb
>
> With errors like:
>
> ERROR: ParseError at /home/geoff/yocto-ccu/poky/build/../meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not
> inherit file classes/features_check.bbclass
>
> Can this commit be reverted?
>

@OpenEmbedded Devel List this shouldn't have been pulled into zeus as
it relies on changes in master on oe-core

-- 
Alex Kiernan

Re: [oe] Request to Revert 'recipes: rename distro_features_check to features_check' comit on meta-java zeus branch

[Jacob Kroon]

On 3/31/20 8:17 AM, Alex Kiernan wrote:
> On Tue, Mar 31, 2020 at 5:46 AM Geoff Parker
> <Geoffrey.Parker@arthrex.com> wrote:
>>
>> Hi Alex,
>>
>> We  moved one of our products to the zeus Yocto 3.0 meta layer branches. It recently stopped building due to this commit on the meta-java zeus branch:
>>
>> commit d2e962a795e8713e5443659669842298453d938f
>> Author: Alex Kiernan <alex.kiernan@gmail.com>
>> Date:   Sat Dec 7 18:07:38 2019 +0000
>>
>>     recipes: rename distro_features_check to features_check
>>
>>     Avoid warning due to the class rename in OE-Core.
>>
>>     Signed-off-by: Alex Kiernan <alex.kiernan@gmail.com>
>>     Signed-off-by: Richard Leitner <richard.leitner@skidata.com>
>>
>> Although this change is appropriate for the Yocto 3.1 branches, it breaks our build on Yocto 3.0 zeus because the zeus branch of the openembedded-core layer does not have the features_check class.
>>
>> The following recipes fail to parse:
>>
>>    openjdk-7_99b00-2.6.5.bb
>>    classpath_0.99.bb
>>    cacao_2d6fc614daf9.bb
>>
>> With errors like:
>>
>> ERROR: ParseError at /home/geoff/yocto-ccu/poky/build/../meta-java/recipes-core/openjdk/openjdk-7_99b00-2.6.5.bb:7: Could not
>> inherit file classes/features_check.bbclass
>>
>> Can this commit be reverted?
>>
> 
> @OpenEmbedded Devel List this shouldn't have been pulled into zeus as
> it relies on changes in master on oe-core
> 
> 

I've sent:
https://lists.openembedded.org/g/openembedded-devel/message/83557

Anyone know how I can make the new mailing list archive use a sane font 
when displaying patches ?

/Jacob