From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Mark Brown <broonie@kernel.org>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH] ALSA: core - add more card sysfs entries
Date: Thu, 8 Apr 2021 14:41:54 -0500 [thread overview]
Message-ID: <a8fa564f-4ab5-9847-d041-6c851e48acb4@linux.intel.com> (raw)
In-Reply-To: <73f65944-604e-1ca0-5ba3-dcbec0d9fcd7@perex.cz>
>>> Yes, I'm talking about rules which depends on the sound driver specific sysfs
>>> attributes (you can match the modified /sys/module/*/parameters here).
>>
>> you lost me with 'match the modified parameters' wording. who matches
>> and who modifies those parameters?
>
> You can probably add something like this to the sound-card.rules:
>
> SUBSYSTEMS=="pci",ATTR{device/driver/module}=="snd_soc_sof_sdw",
> ATTR{device/driver/module/../snd_sof_pci/parameters/tplg_path}=="intel/sof-tplg/pdm1",
> DO_SOMETHING_HERE
>
> DO_SOMETHING_HERE may be ATTR{longname}="My Long Name" for example when my change is accepted.
Humm, not sure this can work due to dependencies.
The machine device is neither an ACPI nor PCI one. It's a platform device.
When the PCI device is detected, the PCI core will call the SOF driver
probe, which will first try and boot the firmware, and then create the
platform device. That results in the probe of the machine driver which
creates the card, but that happens *after* booting the firmware.
the DSP firmware is setup starting here:
https://elixir.bootlin.com/linux/latest/source/sound/soc/sof/core.c#L138
and the machine device is created almost last, after registering the
ASoC components.
https://elixir.bootlin.com/linux/latest/source/sound/soc/sof/core.c#L234
when the card is created, it's too late to change the firmware path or
any firmware-related parameters.
next prev parent reply other threads:[~2021-04-08 19:43 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 9:43 [PATCH] ALSA: core - add more card sysfs entries Jaroslav Kysela
2021-04-08 10:38 ` Takashi Sakamoto
2021-04-08 11:05 ` Takashi Iwai
2021-04-08 11:21 ` Jaroslav Kysela
2021-04-08 12:05 ` Mark Brown
2021-04-08 13:18 ` Takashi Iwai
2021-04-08 14:12 ` Pierre-Louis Bossart
2021-04-08 14:47 ` Mark Brown
2021-04-08 15:04 ` Jaroslav Kysela
2021-04-08 15:11 ` Amadeusz Sławiński
2021-04-08 15:01 ` Jaroslav Kysela
2021-04-08 15:32 ` Pierre-Louis Bossart
2021-04-08 16:53 ` Jaroslav Kysela
2021-04-08 18:51 ` Pierre-Louis Bossart
2021-04-08 19:25 ` Jaroslav Kysela
2021-04-08 19:41 ` Pierre-Louis Bossart [this message]
2021-04-08 19:56 ` Curtis Malainey
2021-04-08 20:01 ` Jaroslav Kysela
2021-04-09 16:43 ` Jaroslav Kysela
2021-04-09 7:39 ` Takashi Iwai
2021-04-09 8:34 ` Jaroslav Kysela
2021-04-09 8:55 ` Takashi Iwai
2021-04-09 9:09 ` Amadeusz Sławiński
2021-04-09 13:54 ` Jaroslav Kysela
2021-04-09 15:55 ` Pierre-Louis Bossart
2021-04-09 16:38 ` Takashi Iwai
2021-04-09 18:55 ` Pierre-Louis Bossart
2021-04-09 16:39 ` Mark Brown
2021-04-08 16:22 ` Mark Brown
2021-04-08 16:50 ` Pierre-Louis Bossart
2021-04-08 18:20 ` Mark Brown
2021-04-08 17:20 ` Jaroslav Kysela
2021-04-08 17:47 ` Mark Brown
2021-04-08 11:25 ` Jaroslav Kysela
2021-04-10 19:11 ` Jaroslav Kysela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a8fa564f-4ab5-9847-d041-6c851e48acb4@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.