[PATCH 1/1] cmd: CONFIG_CMD_MMC depends on CONFIG_MMC

[PATCH 1/1] cmd: CONFIG_CMD_MMC depends on CONFIG_MMC

[Heinrich Schuchardt]

Trying to compile with CONFIG_CMD_MMC=y and CONFIG_MMC=n leads to errors:

riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmcops':
cmd/mmc.c:984: undefined reference to `get_mmc_num'
riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmc_setdsr':
cmd/mmc.c:873: undefined reference to `find_mmc_device'

Add missing dependency.

Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
---
 cmd/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/cmd/Kconfig b/cmd/Kconfig
index 0107c0fa3e..3ce223bed0 100644
--- a/cmd/Kconfig
+++ b/cmd/Kconfig
@@ -1052,6 +1052,7 @@ config CMD_MISC

 config CMD_MMC
 	bool "mmc"
+	depends on MMC
 	help
 	  MMC memory mapped support.

--
2.29.2

[PATCH 1/1] cmd: CONFIG_CMD_MMC depends on CONFIG_MMC

[Bin Meng]

On Sat, Mar 27, 2021 at 6:44 PM Heinrich Schuchardt <xypron.glpk@gmx.de> wrote:
>
> Trying to compile with CONFIG_CMD_MMC=y and CONFIG_MMC=n leads to errors:
>
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmcops':
> cmd/mmc.c:984: undefined reference to `get_mmc_num'
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmc_setdsr':
> cmd/mmc.c:873: undefined reference to `find_mmc_device'
>
> Add missing dependency.
>
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

[PATCH 1/1] cmd: CONFIG_CMD_MMC depends on CONFIG_MMC

[Jaehoon Chung]

On 3/27/21 7:43 PM, Heinrich Schuchardt wrote:
> Trying to compile with CONFIG_CMD_MMC=y and CONFIG_MMC=n leads to errors:
> 
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmcops':
> cmd/mmc.c:984: undefined reference to `get_mmc_num'
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmc_setdsr':
> cmd/mmc.c:873: undefined reference to `find_mmc_device'
> 
> Add missing dependency.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Best Regards,
Jaehoon Chung

> ---
>  cmd/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/cmd/Kconfig b/cmd/Kconfig
> index 0107c0fa3e..3ce223bed0 100644
> --- a/cmd/Kconfig
> +++ b/cmd/Kconfig
> @@ -1052,6 +1052,7 @@ config CMD_MISC
> 
>  config CMD_MMC
>  	bool "mmc"
> +	depends on MMC
>  	help
>  	  MMC memory mapped support.
> 
> --
> 2.29.2
> 
> 

[PATCH 1/1] cmd: CONFIG_CMD_MMC depends on CONFIG_MMC

[Tom Rini]

On Sat, Mar 27, 2021 at 11:43:54AM +0100, Heinrich Schuchardt wrote:

> Trying to compile with CONFIG_CMD_MMC=y and CONFIG_MMC=n leads to errors:
> 
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmcops':
> cmd/mmc.c:984: undefined reference to `get_mmc_num'
> riscv64-linux-gnu-ld.bfd: cmd/built-in.o: in function `do_mmc_setdsr':
> cmd/mmc.c:873: undefined reference to `find_mmc_device'
> 
> Add missing dependency.
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
> Reviewed-by: Jaehoon Chung <jh80.chung@samsung.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 659 bytes
Desc: not available
URL: <https://lists.denx.de/pipermail/u-boot/attachments/20210420/cbfa1feb/attachment.sig>