[lustre-devel] [lustre-discuss] Lustre Client on Fedora 23

[lustre-devel] [lustre-discuss] Lustre Client on Fedora 23

[Dilger, Andreas]

This is really more of a topic for lustre-devel, so I've CC'd that list and we can move future conversation over there.

This particular issue looks related to changes made by Andreas Gruenbacher (xattr maintainer) that went upstream.  Probably best to follow the commits in "git log drivers/staging/lustre/lustre/llite" and port those patches back to master.

Cheers, Andreas
-- 
Andreas Dilger

Lustre Principal Architect
Intel High Performance Data Division

On 2016/10/03, 11:25, "lustre-discuss on behalf of Michael Watters" <lustre-discuss-bounces at lists.lustre.org on behalf of wattersm@watters.ws> wrote:
>
> Thanks.  It looks like the checkpatch.pl script has already been updated 
> however I did have to change the lustre/osd-ldiskfs/osd_io.c 
> b/lustre/osd-ldiskfs/osd_io.c file which contained two references to the 
> old function names.
>   
> make is now failing with a different error as shown below.
>   
>   CC [M] lustre-release-build/lustre/llite/file.o
>   lustre-release-build/lustre/llite/file.c:3841:14: 
>   error: initialization from incompatible pointer type 
>   [-Werror=incompatible-pointer-types]
>      .setxattr = ll_setxattr,
>                  ^
>   lustre-release-build/lustre/llite/file.c:3841:14: 
>   note: (near initialization for ?ll_file_inode_operations.setxattr?)
>   lustre-release-build/lustre/llite/file.c:3842:14: 
>   error: initialization from incompatible pointer type 
>   [-Werror=incompatible-pointer-types]
>      .getxattr = ll_getxattr,
>                  ^
>   lustre-release-build/lustre/llite/file.c:3842:14: 
>   note: (near initialization for ?ll_file_inode_operations.getxattr?)
>   cc1: all warnings being treated as errors
>   scripts/Makefile.build:289: recipe for target 
>   'lustre-release-build/lustre/llite/file.o' failed
>   
> Any idea how to fix this?
>   
>   
>On 09/30/2016 09:51 PM, Dilger, Andreas wrote:
>> The current Lustre hasn't been updated to the 4.7 kernel yet.  As you
>> see the newer kernel replaced PAGE_CACHE_* with PAGE_*.  A patch to
>> fix that (basically simple search and replace) would be welcome.  You
>> should also add PAGE_CACHE_SHIFT and PAGE_CACHE_SIZE into
>> contrib/scripts/checkpatch.pl::dep_functions so that any future patches
>> trying to add them will be flagged.
>>
>> See http://wiki.lustre.org/Submitting_Changes for details.  I've filed
>> LU-8661 to track patches needed for Linux 4.7 kernels so you can use
>> that for your patch submissions.
>>
>> Cheers, Andreas

[lustre-devel] [lustre-discuss] Lustre Client on Fedora 23

[Michael Watters]

Thanks.  I'm using the latest commit from master but unfortunately it 
doesn't compile properly.

make[3]: Entering directory '/usr/src/kernels/4.7.3-100.fc23.x86_64'
   CC [M] /home/projects/lustre-release-build/lustre/fid/fid_request.o
   CC [M] /home/projects/lustre-release-build/lustre/fid/lproc_fid.o
   LD [M]  /home/projects/lustre-release-build/lustre/fid/fid.o
   CC [M] /home/projects/lustre-release-build/lustre/fld/fld_request.o
   CC [M] /home/projects/lustre-release-build/lustre/fld/fld_cache.o
   CC [M] /home/projects/lustre-release-build/lustre/fld/lproc_fld.o
   LD [M]  /home/projects/lustre-release-build/lustre/fld/fld.o
   CC [M] /home/projects/lustre-release-build/lustre/llite/dcache.o
   CC [M]  /home/projects/lustre-release-build/lustre/llite/dir.o
   CC [M]  /home/projects/lustre-release-build/lustre/llite/file.o
/home/projects/lustre-release-build/lustre/llite/file.c:3841:14: error: 
initialization from incompatible pointer type 
[-Werror=incompatible-pointer-types]
   .setxattr = ll_setxattr,
               ^
/home/projects/lustre-release-build/lustre/llite/file.c:3841:14: note: 
(near initialization for ?ll_file_inode_operations.setxattr?)
/home/projects/lustre-release-build/lustre/llite/file.c:3842:14: error: 
initialization from incompatible pointer type 
[-Werror=incompatible-pointer-types]
   .getxattr = ll_getxattr,
               ^
/home/projects/lustre-release-build/lustre/llite/file.c:3842:14: note: 
(near initialization for ?ll_file_inode_operations.getxattr?)
cc1: all warnings being treated as errors

I'm not a C developer so I don't really know how to fix this but it 
looks like ll_setxattr is defined in xattr.c.


On 10/03/2016 04:42 PM, Dilger, Andreas wrote:
> This is really more of a topic for lustre-devel, so I've CC'd that list and we can move future conversation over there.
>
> This particular issue looks related to changes made by Andreas Gruenbacher (xattr maintainer) that went upstream.  Probably best to follow the commits in "git log drivers/staging/lustre/lustre/llite" and port those patches back to master.
>
> Cheers, Andreas