From: Hans Verkuil <hverkuil@xs4all.nl>
To: Mauro Carvalho Chehab <mchehab@s-opensource.com>
Cc: linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Subject: Re: [PATCHv4 04/15] v4l: vsp1: Add histogram support
Date: Tue, 11 Apr 2017 15:27:12 +0200 [thread overview]
Message-ID: <a95e3ae3-de87-5ce4-cc68-4cda449d2fe3@xs4all.nl> (raw)
In-Reply-To: <20170411081728.4df93852@vento.lan>
On 04/11/17 13:17, Mauro Carvalho Chehab wrote:
> Em Mon, 10 Apr 2017 21:26:40 +0200
> Hans Verkuil <hverkuil@xs4all.nl> escreveu:
>
>> From: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>>
>> The histogram common code will be used to implement support for both the
>> HGO and HGT histogram computation engines.
>>
>> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
>> ---
>> drivers/media/platform/Kconfig | 1 +
>> drivers/media/platform/vsp1/Makefile | 1 +
>> drivers/media/platform/vsp1/vsp1_histo.c | 646 +++++++++++++++++++++++++++++++
>> drivers/media/platform/vsp1/vsp1_histo.h | 84 ++++
>> 4 files changed, 732 insertions(+)
>> create mode 100644 drivers/media/platform/vsp1/vsp1_histo.c
>> create mode 100644 drivers/media/platform/vsp1/vsp1_histo.h
>
>> diff --git a/drivers/media/platform/vsp1/vsp1_histo.c b/drivers/media/platform/vsp1/vsp1_histo.c
>> new file mode 100644
>> index 000000000000..afab77cf4fa5
>> --- /dev/null
>> +++ b/drivers/media/platform/vsp1/vsp1_histo.c
>
> ...
>
>> + crop = vsp1_entity_get_pad_selection(&histo->entity, config, sel->pad,
>> + V4L2_SEL_TGT_CROP);
>> +
>> + /*
>> + * Clamp the width and height to acceptable values first and then
>> + * compute the closest rounded dividing ratio.
>> + *
>> + * Ratio Rounded ratio
>> + * --------------------------
>> + * [1.0 1.5[ 1
>
> Nitpick:
>
> 1.0 1.5] 1
No, the notation [a b[ means the range 'a to, but not including, b'.
So this is correct.
I'm used to writing this as [a b), but according to wikipedia both notations
are allowed.
Regards,
Hans
>
> Thanks,
> Mauro
>
next prev parent reply other threads:[~2017-04-11 13:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-10 19:26 [PATCHv4 00/15] R-Car VSP1 Histogram Support Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 01/15] v4l: Clearly document interactions between formats, controls and buffers Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 02/15] v4l: vsp1: wpf: Implement rotation support Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 03/15] v4l: Add metadata buffer type and format Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 04/15] v4l: vsp1: Add histogram support Hans Verkuil
2017-04-11 11:17 ` Mauro Carvalho Chehab
2017-04-11 13:27 ` Hans Verkuil [this message]
2017-04-11 13:34 ` Mauro Carvalho Chehab
2017-04-10 19:26 ` [PATCHv4 05/15] v4l: vsp1: Support histogram generators in pipeline configuration Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 06/15] v4l: vsp1: Fix HGO and HGT routing register addresses Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 07/15] v4l: Define a pixel format for the R-Car VSP1 1-D histogram engine Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 08/15] v4l: vsp1: Add HGO support Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 09/15] v4l: Define a pixel format for the R-Car VSP1 2-D histogram engine Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 10/15] v4l: vsp1: Add HGT support Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 11/15] vidioc-queryctrl.rst: document V4L2_CTRL_FLAG_MODIFY_LAYOUT Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 12/15] videodev.h: add V4L2_CTRL_FLAG_MODIFY_LAYOUT Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 13/15] v4l2-ctrls.c: set V4L2_CTRL_FLAG_MODIFY_LAYOUT for ROTATE Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 14/15] buffer.rst: clarify how V4L2_CTRL_FLAG_MODIFY_LAYOUT/GRABBER are used Hans Verkuil
2017-04-10 19:26 ` [PATCHv4 15/15] vsp1: set V4L2_CTRL_FLAG_MODIFY_LAYOUT for histogram controls Hans Verkuil
2017-04-11 11:39 ` [PATCHv4 00/15] R-Car VSP1 Histogram Support Mauro Carvalho Chehab
2017-04-11 12:19 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a95e3ae3-de87-5ce4-cc68-4cda449d2fe3@xs4all.nl \
--to=hverkuil@xs4all.nl \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@s-opensource.com \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.