All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomasz Nowicki <tnowicki@caviumnetworks.com>
To: Eric Auger <eric.auger@redhat.com>, <eric.auger.pro@gmail.com>,
	<christoffer.dall@linaro.org>, <marc.zyngier@arm.com>,
	<robin.murphy@arm.com>, <alex.williamson@redhat.com>,
	<will.deacon@arm.com>, <joro@8bytes.org>, <tglx@linutronix.de>,
	<jason@lakedaemon.net>, <linux-arm-kernel@lists.infradead.org>
Cc: <drjones@redhat.com>, <kvm@vger.kernel.org>,
	<punit.agrawal@arm.com>, <linux-kernel@vger.kernel.org>,
	<geethasowjanya.akula@gmail.com>, <diana.craciun@nxp.com>,
	<iommu@lists.linux-foundation.org>,
	<pranav.sawargaonkar@gmail.com>, <bharat.bhushan@nxp.com>,
	<shankerd@codeaurora.org>, <gpkulkarni@gmail.com>
Subject: Re: [PATCH v8 05/18] iommu: Only map direct mapped regions
Date: Tue, 17 Jan 2017 13:13:18 +0100	[thread overview]
Message-ID: <a9618d26-44a8-3453-8b98-f5c46b2e8fa6@caviumnetworks.com> (raw)
In-Reply-To: <1484127714-3263-6-git-send-email-eric.auger@redhat.com>

On 11.01.2017 10:41, Eric Auger wrote:
> As we introduced new reserved region types which do not require
> mapping, let's make sure we only map direct mapped regions.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>

Reviewed-by: Tomasz Nowicki <tomasz.nowicki@caviumnetworks.com>

Thanks,
Tomasz

>
> ---
>
> v3 -> v4:
> - use region's type and reword commit message and title
> ---
>  drivers/iommu/iommu.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 927878d..41c1906 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group,
>  		start = ALIGN(entry->start, pg_size);
>  		end   = ALIGN(entry->start + entry->length, pg_size);
>
> +		if (entry->type != IOMMU_RESV_DIRECT)
> +			continue;
> +
>  		for (addr = start; addr < end; addr += pg_size) {
>  			phys_addr_t phys_addr;
>
>

WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Nowicki <tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	<eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	<christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>,
	<marc.zyngier-5wv7dgnIgG8@public.gmane.org>,
	<robin.murphy-5wv7dgnIgG8@public.gmane.org>,
	<alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	<will.deacon-5wv7dgnIgG8@public.gmane.org>,
	<joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org>,
	<tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>,
	<jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v8 05/18] iommu: Only map direct mapped regions
Date: Tue, 17 Jan 2017 13:13:18 +0100	[thread overview]
Message-ID: <a9618d26-44a8-3453-8b98-f5c46b2e8fa6@caviumnetworks.com> (raw)
In-Reply-To: <1484127714-3263-6-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 11.01.2017 10:41, Eric Auger wrote:
> As we introduced new reserved region types which do not require
> mapping, let's make sure we only map direct mapped regions.
>
> Signed-off-by: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Reviewed-by: Tomasz Nowicki <tomasz.nowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>

Thanks,
Tomasz

>
> ---
>
> v3 -> v4:
> - use region's type and reword commit message and title
> ---
>  drivers/iommu/iommu.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 927878d..41c1906 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group,
>  		start = ALIGN(entry->start, pg_size);
>  		end   = ALIGN(entry->start + entry->length, pg_size);
>
> +		if (entry->type != IOMMU_RESV_DIRECT)
> +			continue;
> +
>  		for (addr = start; addr < end; addr += pg_size) {
>  			phys_addr_t phys_addr;
>
>

WARNING: multiple messages have this Message-ID (diff)
From: Tomasz Nowicki <tnowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>
To: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
	eric.auger.pro-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	christoffer.dall-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
	marc.zyngier-5wv7dgnIgG8@public.gmane.org,
	robin.murphy-5wv7dgnIgG8@public.gmane.org,
	alex.williamson-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	will.deacon-5wv7dgnIgG8@public.gmane.org,
	joro-zLv9SwRftAIdnm+yROfE0A@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
Cc: drjones-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	punit.agrawal-5wv7dgnIgG8@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	geethasowjanya.akula-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	pranav.sawargaonkar-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
	shankerd-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
	gpkulkarni-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
Subject: Re: [PATCH v8 05/18] iommu: Only map direct mapped regions
Date: Tue, 17 Jan 2017 13:13:18 +0100	[thread overview]
Message-ID: <a9618d26-44a8-3453-8b98-f5c46b2e8fa6@caviumnetworks.com> (raw)
In-Reply-To: <1484127714-3263-6-git-send-email-eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

On 11.01.2017 10:41, Eric Auger wrote:
> As we introduced new reserved region types which do not require
> mapping, let's make sure we only map direct mapped regions.
>
> Signed-off-by: Eric Auger <eric.auger-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Reviewed-by: Tomasz Nowicki <tomasz.nowicki-M3mlKVOIwJVv6pq1l3V1OdBPR1lH4CV8@public.gmane.org>

Thanks,
Tomasz

>
> ---
>
> v3 -> v4:
> - use region's type and reword commit message and title
> ---
>  drivers/iommu/iommu.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 927878d..41c1906 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group,
>  		start = ALIGN(entry->start, pg_size);
>  		end   = ALIGN(entry->start + entry->length, pg_size);
>
> +		if (entry->type != IOMMU_RESV_DIRECT)
> +			continue;
> +
>  		for (addr = start; addr < end; addr += pg_size) {
>  			phys_addr_t phys_addr;
>
>

WARNING: multiple messages have this Message-ID (diff)
From: tnowicki@caviumnetworks.com (Tomasz Nowicki)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v8 05/18] iommu: Only map direct mapped regions
Date: Tue, 17 Jan 2017 13:13:18 +0100	[thread overview]
Message-ID: <a9618d26-44a8-3453-8b98-f5c46b2e8fa6@caviumnetworks.com> (raw)
In-Reply-To: <1484127714-3263-6-git-send-email-eric.auger@redhat.com>

On 11.01.2017 10:41, Eric Auger wrote:
> As we introduced new reserved region types which do not require
> mapping, let's make sure we only map direct mapped regions.
>
> Signed-off-by: Eric Auger <eric.auger@redhat.com>

Reviewed-by: Tomasz Nowicki <tomasz.nowicki@caviumnetworks.com>

Thanks,
Tomasz

>
> ---
>
> v3 -> v4:
> - use region's type and reword commit message and title
> ---
>  drivers/iommu/iommu.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
> index 927878d..41c1906 100644
> --- a/drivers/iommu/iommu.c
> +++ b/drivers/iommu/iommu.c
> @@ -343,6 +343,9 @@ static int iommu_group_create_direct_mappings(struct iommu_group *group,
>  		start = ALIGN(entry->start, pg_size);
>  		end   = ALIGN(entry->start + entry->length, pg_size);
>
> +		if (entry->type != IOMMU_RESV_DIRECT)
> +			continue;
> +
>  		for (addr = start; addr < end; addr += pg_size) {
>  			phys_addr_t phys_addr;
>
>

  reply	other threads:[~2017-01-17 12:29 UTC|newest]

Thread overview: 125+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11  9:41 [PATCH v8 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Eric Auger
2017-01-11  9:41 ` Eric Auger
2017-01-11  9:41 ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 01/18] iommu/dma: Allow MSI-only cookies Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 11:59   ` Tomasz Nowicki
2017-01-17 11:59     ` Tomasz Nowicki
2017-01-17 11:59     ` Tomasz Nowicki
2017-01-17 11:59     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 02/18] iommu: Rename iommu_dm_regions into iommu_resv_regions Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 12:08   ` Tomasz Nowicki
2017-01-17 12:08     ` Tomasz Nowicki
2017-01-17 12:08     ` Tomasz Nowicki
2017-01-17 12:08     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 03/18] iommu: Add a new type field in iommu_resv_region Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 04/18] iommu: iommu_alloc_resv_region Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 12:12   ` Tomasz Nowicki
2017-01-17 12:12     ` Tomasz Nowicki
2017-01-17 12:12     ` Tomasz Nowicki
2017-01-17 12:12     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 05/18] iommu: Only map direct mapped regions Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 12:13   ` Tomasz Nowicki [this message]
2017-01-17 12:13     ` Tomasz Nowicki
2017-01-17 12:13     ` Tomasz Nowicki
2017-01-17 12:13     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 06/18] iommu: iommu_get_group_resv_regions Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 12:14   ` Tomasz Nowicki
2017-01-17 12:14     ` Tomasz Nowicki
2017-01-17 12:14     ` Tomasz Nowicki
2017-01-17 12:14     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 07/18] iommu: Implement reserved_regions iommu-group sysfs file Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 08/18] iommu/vt-d: Implement reserved region get/put callbacks Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 09/18] iommu/amd: Declare MSI and HT regions as reserved IOVA regions Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 10/18] iommu/arm-smmu: Implement reserved region get/put callbacks Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 13:20   ` Tomasz Nowicki
2017-01-17 13:20     ` Tomasz Nowicki
2017-01-17 13:20     ` Tomasz Nowicki
2017-01-17 13:20     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 11/18] iommu/arm-smmu-v3: " Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 14:13   ` Tomasz Nowicki
2017-01-17 14:13     ` Tomasz Nowicki
2017-01-17 14:13     ` Tomasz Nowicki
2017-01-17 14:13     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 12/18] irqdomain: Add irq domain MSI and MSI_REMAP flags Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-18  8:35   ` Tomasz Nowicki
2017-01-18  8:35     ` Tomasz Nowicki
2017-01-18  8:35     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 13/18] genirq/msi: Set IRQ_DOMAIN_FLAG_MSI on MSI domain creation Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-18  8:36   ` Tomasz Nowicki
2017-01-18  8:36     ` Tomasz Nowicki
2017-01-18  8:36     ` Tomasz Nowicki
2017-01-18  8:36     ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 14/18] irqdomain: irq_domain_check_msi_remap Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-17 13:40   ` Tomasz Nowicki
2017-01-17 13:40     ` Tomasz Nowicki
2017-01-17 13:40     ` Tomasz Nowicki
2017-01-17 13:53     ` Auger Eric
2017-01-17 13:53       ` Auger Eric
2017-01-17 14:06       ` Tomasz Nowicki
2017-01-17 14:06         ` Tomasz Nowicki
2017-01-17 14:06         ` Tomasz Nowicki
2017-01-17 14:06         ` Tomasz Nowicki
2017-01-18  8:40         ` Tomasz Nowicki
2017-01-18  8:40           ` Tomasz Nowicki
2017-01-18  8:40           ` Tomasz Nowicki
2017-01-11  9:41 ` [PATCH v8 15/18] irqchip/gicv3-its: Sets IRQ_DOMAIN_FLAG_MSI_REMAP Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41 ` [PATCH v8 16/18] vfio/type1: Allow transparent MSI IOVA allocation Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-13 23:04   ` Alex Williamson
2017-01-13 23:04     ` Alex Williamson
2017-01-13 23:04     ` Alex Williamson
2017-01-11  9:41 ` [PATCH v8 17/18] vfio/type1: Check MSI remapping at irq domain level Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-13 23:04   ` Alex Williamson
2017-01-13 23:04     ` Alex Williamson
2017-01-13 23:04     ` Alex Williamson
2017-01-11  9:41 ` [PATCH v8 18/18] iommu/arm-smmu: Do not advertise IOMMU_CAP_INTR_REMAP anymore Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-11  9:41   ` Eric Auger
2017-01-18 11:46   ` Tomasz Nowicki
2017-01-18 11:46     ` Tomasz Nowicki
2017-01-12  3:59 ` [PATCH v8 00/18] KVM PCIe/MSI passthrough on ARM/ARM64 and IOVA reserved regions Bharat Bhushan
2017-01-12  3:59   ` Bharat Bhushan
2017-01-12  3:59   ` Bharat Bhushan
2017-01-12  7:40   ` Auger Eric
2017-01-12  7:40     ` Auger Eric
2017-01-12  7:40     ` Auger Eric
2017-01-13 13:59 ` Tomasz Nowicki
2017-01-13 13:59   ` Tomasz Nowicki
2017-01-13 13:59   ` Tomasz Nowicki
2017-01-16  9:07   ` Auger Eric
2017-01-16  9:07     ` Auger Eric
2017-01-16  9:07     ` Auger Eric
2017-01-18 13:02   ` Auger Eric
2017-01-18 13:02     ` Auger Eric
2017-01-18 13:02     ` Auger Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a9618d26-44a8-3453-8b98-f5c46b2e8fa6@caviumnetworks.com \
    --to=tnowicki@caviumnetworks.com \
    --cc=alex.williamson@redhat.com \
    --cc=bharat.bhushan@nxp.com \
    --cc=christoffer.dall@linaro.org \
    --cc=diana.craciun@nxp.com \
    --cc=drjones@redhat.com \
    --cc=eric.auger.pro@gmail.com \
    --cc=eric.auger@redhat.com \
    --cc=geethasowjanya.akula@gmail.com \
    --cc=gpkulkarni@gmail.com \
    --cc=iommu@lists.linux-foundation.org \
    --cc=jason@lakedaemon.net \
    --cc=joro@8bytes.org \
    --cc=kvm@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marc.zyngier@arm.com \
    --cc=pranav.sawargaonkar@gmail.com \
    --cc=punit.agrawal@arm.com \
    --cc=robin.murphy@arm.com \
    --cc=shankerd@codeaurora.org \
    --cc=tglx@linutronix.de \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.