All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robin Murphy <robin.murphy@arm.com>
To: Andre Przywara <andre.przywara@arm.com>,
	Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/16] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards"
Date: Tue, 5 May 2020 19:10:23 +0100	[thread overview]
Message-ID: <a96c83b3-dc58-e1da-de52-d36bdfc0533f@arm.com> (raw)
In-Reply-To: <20200505165212.76466-2-andre.przywara@arm.com>

On 2020-05-05 5:51 pm, Andre Przywara wrote:
> Date: Mon, 4 May 2020 12:41:55 +0100
> Subject: [PATCH 01/16] dt-bindings: mali-midgard: Allow dma-coherent
> 
> Add the boolean dma-coherent property to the list of allowed properties,
> since some boards (Arm Juno) integrate the GPU this way.

The same comment as for "iommus" applies to some degree here too. 
There's a bit more likelihood that the device itself does want to know 
whether it's integrated coherently, so that it can choose what memory 
attributes to use (as is the case here), but with protocols like 
ACE-lite it's possible to hard-wire any old dumb device to behave 
coherently without even realising. Thus this is another property that 
could legitimately turn up more or less anywhere.

Robin.

> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>   Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> index 0407e45eb8c4..5d7165385e1f 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> @@ -87,6 +87,8 @@ properties:
>     "#cooling-cells":
>       const: 2
>   
> +  dma-coherent: true
> +
>   required:
>     - compatible
>     - reg
> 

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Andre Przywara <andre.przywara@arm.com>,
	Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org, Daniel Vetter <daniel@ffwll.ch>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/16] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards"
Date: Tue, 5 May 2020 19:10:23 +0100	[thread overview]
Message-ID: <a96c83b3-dc58-e1da-de52-d36bdfc0533f@arm.com> (raw)
In-Reply-To: <20200505165212.76466-2-andre.przywara@arm.com>

On 2020-05-05 5:51 pm, Andre Przywara wrote:
> Date: Mon, 4 May 2020 12:41:55 +0100
> Subject: [PATCH 01/16] dt-bindings: mali-midgard: Allow dma-coherent
> 
> Add the boolean dma-coherent property to the list of allowed properties,
> since some boards (Arm Juno) integrate the GPU this way.

The same comment as for "iommus" applies to some degree here too. 
There's a bit more likelihood that the device itself does want to know 
whether it's integrated coherently, so that it can choose what memory 
attributes to use (as is the case here), but with protocols like 
ACE-lite it's possible to hard-wire any old dumb device to behave 
coherently without even realising. Thus this is another property that 
could legitimately turn up more or less anywhere.

Robin.

> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>   Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> index 0407e45eb8c4..5d7165385e1f 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> @@ -87,6 +87,8 @@ properties:
>     "#cooling-cells":
>       const: 2
>   
> +  dma-coherent: true
> +
>   required:
>     - compatible
>     - reg
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Robin Murphy <robin.murphy@arm.com>
To: Andre Przywara <andre.przywara@arm.com>,
	Rob Herring <robh@kernel.org>, Liviu Dudau <liviu.dudau@arm.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, David Airlie <airlied@linux.ie>,
	dri-devel@lists.freedesktop.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 00/16] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards"
Date: Tue, 5 May 2020 19:10:23 +0100	[thread overview]
Message-ID: <a96c83b3-dc58-e1da-de52-d36bdfc0533f@arm.com> (raw)
In-Reply-To: <20200505165212.76466-2-andre.przywara@arm.com>

On 2020-05-05 5:51 pm, Andre Przywara wrote:
> Date: Mon, 4 May 2020 12:41:55 +0100
> Subject: [PATCH 01/16] dt-bindings: mali-midgard: Allow dma-coherent
> 
> Add the boolean dma-coherent property to the list of allowed properties,
> since some boards (Arm Juno) integrate the GPU this way.

The same comment as for "iommus" applies to some degree here too. 
There's a bit more likelihood that the device itself does want to know 
whether it's integrated coherently, so that it can choose what memory 
attributes to use (as is the case here), but with protocols like 
ACE-lite it's possible to hard-wire any old dumb device to behave 
coherently without even realising. Thus this is another property that 
could legitimately turn up more or less anywhere.

Robin.

> Signed-off-by: Andre Przywara <andre.przywara@arm.com>
> ---
>   Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> index 0407e45eb8c4..5d7165385e1f 100644
> --- a/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> +++ b/Documentation/devicetree/bindings/gpu/arm,mali-midgard.yaml
> @@ -87,6 +87,8 @@ properties:
>     "#cooling-cells":
>       const: 2
>   
> +  dma-coherent: true
> +
>   required:
>     - compatible
>     - reg
> 
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

  reply	other threads:[~2020-05-05 18:10 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-05 16:51 [PATCH 00/16] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Andre Przywara
2020-05-05 16:51 ` Andre Przywara
2020-05-05 16:51 ` Andre Przywara
2020-05-05 16:51   ` Andre Przywara
2020-05-05 16:51   ` Andre Przywara
2020-05-05 18:10   ` Robin Murphy [this message]
2020-05-05 18:10     ` Robin Murphy
2020-05-05 18:10     ` Robin Murphy
2020-05-05 16:51 ` Andre Przywara
2020-05-05 16:51   ` Andre Przywara
2020-05-05 16:51   ` Andre Przywara
2020-05-05 17:06   ` Robin Murphy
2020-05-05 17:06     ` Robin Murphy
2020-05-05 17:06     ` Robin Murphy
2020-05-05 17:13     ` André Przywara
2020-05-05 17:13       ` André Przywara
2020-05-05 17:13       ` André Przywara
2020-05-05 16:51 ` Andre Przywara
2020-05-05 16:51   ` Andre Przywara
2020-05-05 17:38   ` Greg Kroah-Hartman
2020-05-05 17:38     ` Greg Kroah-Hartman
2020-05-05 17:51   ` Robin Murphy
2020-05-05 17:51     ` Robin Murphy
2020-05-05 18:01     ` [PATCH 03/16] dt-bindings: ehci/ohci: Allow iommus property (fixed subject line) André Przywara
2020-05-05 18:01       ` André Przywara
2020-05-05 22:31     ` [PATCH 00/16] dts/dt-bindings: Fix Arm Ltd. ARMv8 "boards" Rob Herring
2020-05-05 22:31       ` Rob Herring
2020-05-05 16:52 ` [PATCH 04/16] arm64: dts: arm: Fix node address fields Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 17:18   ` Robin Murphy
2020-05-05 17:18     ` Robin Murphy
2020-05-21 14:40     ` Liviu Dudau
2020-05-21 14:40       ` Liviu Dudau
2020-05-22  9:25       ` André Przywara
2020-05-22  9:25         ` André Przywara
2020-05-05 16:52 ` [PATCH 05/16] arm64: dts: arm: FVP: Fix motherboard .dtsi Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 06/16] arm64: dts: juno: Fix mem-timer Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 07/16] arm64: dts: arm: Fix GIC compatible names Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 18:25   ` Marc Zyngier
2020-05-05 18:25     ` Marc Zyngier
2020-05-06  8:45     ` André Przywara
2020-05-06  8:45       ` André Przywara
2020-05-06  9:16       ` Marc Zyngier
2020-05-06  9:16         ` Marc Zyngier
2020-05-06 10:00         ` André Przywara
2020-05-06 10:00           ` André Przywara
2020-05-06 10:11           ` Marc Zyngier
2020-05-06 10:11             ` Marc Zyngier
2020-05-05 16:52 ` [PATCH 08/16] arm64: dts: arm: Fix GIC child nodes Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 09/16] arm64: dts: arm: Fix ITS node names and #msi-cells Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 10/16] arm64: dts: juno: usb: Use proper DT node name Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 11/16] arm64: dts: arm: Fix serial node names Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 12/16] arm64: dts: fvp: Fix SMMU DT node Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 13/16] arm64: dts: arm: Fix bus node names Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 14/16] arm64: dts: juno: Fix GPU interrupt order Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 15/16] arm64: dts: arm: Fix VExpress LED names Andre Przywara
2020-05-05 16:52   ` Andre Przywara
2020-05-05 16:52 ` [PATCH 16/16] arm64: dts: juno: Fix SCPI shared mem node name Andre Przywara
2020-05-05 16:52   ` Andre Przywara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a96c83b3-dc58-e1da-de52-d36bdfc0533f@arm.com \
    --to=robin.murphy@arm.com \
    --cc=airlied@linux.ie \
    --cc=andre.przywara@arm.com \
    --cc=daniel@ffwll.ch \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=liviu.dudau@arm.com \
    --cc=lorenzo.pieralisi@arm.com \
    --cc=mark.rutland@arm.com \
    --cc=robh@kernel.org \
    --cc=sudeep.holla@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.