* [PATCH] KVM/ARM: vgic: Delete the redundant lines of code
@ 2021-07-12 12:49 John Gong
2021-07-12 14:16 ` Marc Zyngier
0 siblings, 1 reply; 2+ messages in thread
From: John Gong @ 2021-07-12 12:49 UTC (permalink / raw)
To: maz; +Cc: John Gong, kvmarm
delete redundant lines of code
Signed-off-by: John Gong <johngong0791@163.com>
---
arch/arm64/kvm/vgic/vgic-mmio.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c b/arch/arm64/kvm/vgic/vgic-mmio.c
index 48c6067fc5ec..19cf661c451e 100644
--- a/arch/arm64/kvm/vgic/vgic-mmio.c
+++ b/arch/arm64/kvm/vgic/vgic-mmio.c
@@ -1004,8 +1004,6 @@ static int dispatch_mmio_read(struct kvm_vcpu *vcpu, struct kvm_io_device *dev,
switch (iodev->iodev_type) {
case IODEV_CPUIF:
- data = region->read(vcpu, addr, len);
- break;
case IODEV_DIST:
data = region->read(vcpu, addr, len);
break;
--
2.25.1
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM/ARM: vgic: Delete the redundant lines of code
2021-07-12 12:49 [PATCH] KVM/ARM: vgic: Delete the redundant lines of code John Gong
@ 2021-07-12 14:16 ` Marc Zyngier
0 siblings, 0 replies; 2+ messages in thread
From: Marc Zyngier @ 2021-07-12 14:16 UTC (permalink / raw)
To: John Gong; +Cc: kvmarm
On 2021-07-12 13:49, John Gong wrote:
> delete redundant lines of code
>
> Signed-off-by: John Gong <johngong0791@163.com>
> ---
> arch/arm64/kvm/vgic/vgic-mmio.c | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/kvm/vgic/vgic-mmio.c
> b/arch/arm64/kvm/vgic/vgic-mmio.c
> index 48c6067fc5ec..19cf661c451e 100644
> --- a/arch/arm64/kvm/vgic/vgic-mmio.c
> +++ b/arch/arm64/kvm/vgic/vgic-mmio.c
> @@ -1004,8 +1004,6 @@ static int dispatch_mmio_read(struct kvm_vcpu
> *vcpu, struct kvm_io_device *dev,
>
> switch (iodev->iodev_type) {
> case IODEV_CPUIF:
> - data = region->read(vcpu, addr, len);
> - break;
> case IODEV_DIST:
> data = region->read(vcpu, addr, len);
> break;
I'm not overly keen on this. Why isn't the write path treated the same
way?
M.
--
Jazz is not dead. It just smells funny...
_______________________________________________
kvmarm mailing list
kvmarm@lists.cs.columbia.edu
https://lists.cs.columbia.edu/mailman/listinfo/kvmarm
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-07-12 14:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-07-12 12:49 [PATCH] KVM/ARM: vgic: Delete the redundant lines of code John Gong
2021-07-12 14:16 ` Marc Zyngier
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.