* [PATCH] ath10k: sdio: remove unused struct member
@ 2017-08-19 14:36 ` Erik Stromdahl
0 siblings, 0 replies; 4+ messages in thread
From: Erik Stromdahl @ 2017-08-19 14:36 UTC (permalink / raw)
To: kvalo, linux-wireless, ath10k; +Cc: Erik Stromdahl
irq_wq in struct ath10k_sdio is a remnant from an earlier
version of the sdio patchset.
It's use was removed as a result of Kalle's review, but somehow
the struct member survived.
It is not used and can therefore safely be removed.
Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
---
drivers/net/wireless/ath/ath10k/sdio.c | 4 ----
drivers/net/wireless/ath/ath10k/sdio.h | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
index 48268f0..03a69e5 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func)
sdio_claim_host(ar_sdio->func);
- wake_up(&ar_sdio->irq_wq);
-
if (ret && ret != -ECANCELED)
ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n",
ret);
@@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func,
goto err_free_bmi_buf;
}
- init_waitqueue_head(&ar_sdio->irq_wq);
-
for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++)
ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]);
diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h
index 3f61c67..4ff7b54 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.h
+++ b/drivers/net/wireless/ath/ath10k/sdio.h
@@ -210,8 +210,6 @@ struct ath10k_sdio {
/* temporary buffer for BMI requests */
u8 *bmi_buf;
- wait_queue_head_t irq_wq;
-
bool is_disabled;
struct workqueue_struct *workqueue;
--
2.7.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH] ath10k: sdio: remove unused struct member
@ 2017-08-19 14:36 ` Erik Stromdahl
0 siblings, 0 replies; 4+ messages in thread
From: Erik Stromdahl @ 2017-08-19 14:36 UTC (permalink / raw)
To: kvalo, linux-wireless, ath10k; +Cc: Erik Stromdahl
irq_wq in struct ath10k_sdio is a remnant from an earlier
version of the sdio patchset.
It's use was removed as a result of Kalle's review, but somehow
the struct member survived.
It is not used and can therefore safely be removed.
Signed-off-by: Erik Stromdahl <erik.stromdahl@gmail.com>
---
drivers/net/wireless/ath/ath10k/sdio.c | 4 ----
drivers/net/wireless/ath/ath10k/sdio.h | 2 --
2 files changed, 6 deletions(-)
diff --git a/drivers/net/wireless/ath/ath10k/sdio.c b/drivers/net/wireless/ath/ath10k/sdio.c
index 48268f0..03a69e5 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.c
+++ b/drivers/net/wireless/ath/ath10k/sdio.c
@@ -1344,8 +1344,6 @@ static void ath10k_sdio_irq_handler(struct sdio_func *func)
sdio_claim_host(ar_sdio->func);
- wake_up(&ar_sdio->irq_wq);
-
if (ret && ret != -ECANCELED)
ath10k_warn(ar, "failed to process pending SDIO interrupts: %d\n",
ret);
@@ -2000,8 +1998,6 @@ static int ath10k_sdio_probe(struct sdio_func *func,
goto err_free_bmi_buf;
}
- init_waitqueue_head(&ar_sdio->irq_wq);
-
for (i = 0; i < ATH10K_SDIO_BUS_REQUEST_MAX_NUM; i++)
ath10k_sdio_free_bus_req(ar, &ar_sdio->bus_req[i]);
diff --git a/drivers/net/wireless/ath/ath10k/sdio.h b/drivers/net/wireless/ath/ath10k/sdio.h
index 3f61c67..4ff7b54 100644
--- a/drivers/net/wireless/ath/ath10k/sdio.h
+++ b/drivers/net/wireless/ath/ath10k/sdio.h
@@ -210,8 +210,6 @@ struct ath10k_sdio {
/* temporary buffer for BMI requests */
u8 *bmi_buf;
- wait_queue_head_t irq_wq;
-
bool is_disabled;
struct workqueue_struct *workqueue;
--
2.7.4
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: sdio: remove unused struct member
2017-08-19 14:36 ` Erik Stromdahl
(?)
@ 2017-08-22 0:18 ` Ryan Hsu
2017-08-22 17:00 ` Erik Stromdahl
-1 siblings, 1 reply; 4+ messages in thread
From: Ryan Hsu @ 2017-08-22 0:18 UTC (permalink / raw)
To: Erik Stromdahl, ath10k
On 08/19/2017 07:36 AM, Erik Stromdahl wrote:
> irq_wq in struct ath10k_sdio is a remnant from an earlier
> version of the sdio patchset.
>
> It's use was removed as a result of Kalle's review, but somehow
Its?
--
Ryan Hsu
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath10k: sdio: remove unused struct member
2017-08-22 0:18 ` Ryan Hsu
@ 2017-08-22 17:00 ` Erik Stromdahl
0 siblings, 0 replies; 4+ messages in thread
From: Erik Stromdahl @ 2017-08-22 17:00 UTC (permalink / raw)
To: Ryan Hsu, ath10k
On 2017-08-22 02:18, Ryan Hsu wrote:
> On 08/19/2017 07:36 AM, Erik Stromdahl wrote:
>
>> irq_wq in struct ath10k_sdio is a remnant from an earlier
>> version of the sdio patchset.
>>
>> It's use was removed as a result of Kalle's review, but somehow
>
> Its?
>
Aah, of course.
It's of course supposed to be its:)
I'll fix it in v2.
--
Erik
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-08-22 17:00 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-08-19 14:36 [PATCH] ath10k: sdio: remove unused struct member Erik Stromdahl
2017-08-19 14:36 ` Erik Stromdahl
2017-08-22 0:18 ` Ryan Hsu
2017-08-22 17:00 ` Erik Stromdahl
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.