* [Intel-gfx] [PATCH] drm/i915: Set fence_work.ops before dma_fence_init
@ 2019-12-12 15:42 Chris Wilson
2019-12-12 15:59 ` Matthew Auld
2019-12-12 19:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
0 siblings, 2 replies; 3+ messages in thread
From: Chris Wilson @ 2019-12-12 15:42 UTC (permalink / raw)
To: intel-gfx; +Cc: Vince Weaver, Matthew Auld
Since dma_fence_init may call ops (because of a meaningless
trace_dma_fence), we need to set the worker ops prior to that call.
Reported-by: Vince Weaver <vincent.weaver@maine.edu>
Fixes: 8e458fe2ee05 ("drm/i915: Generalise the clflush dma-worker")
Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Matthew Auld <matthew.auld@intel.com>
Cc: Vince Weaver <vincent.weaver@maine.edu>
---
drivers/gpu/drm/i915/i915_sw_fence_work.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_sw_fence_work.c b/drivers/gpu/drm/i915/i915_sw_fence_work.c
index 07552cd544f2..8538ee7a521d 100644
--- a/drivers/gpu/drm/i915/i915_sw_fence_work.c
+++ b/drivers/gpu/drm/i915/i915_sw_fence_work.c
@@ -78,12 +78,11 @@ static const struct dma_fence_ops fence_ops = {
void dma_fence_work_init(struct dma_fence_work *f,
const struct dma_fence_work_ops *ops)
{
+ f->ops = ops;
spin_lock_init(&f->lock);
dma_fence_init(&f->dma, &fence_ops, &f->lock, 0, 0);
i915_sw_fence_init(&f->chain, fence_notify);
INIT_WORK(&f->work, fence_work);
-
- f->ops = ops;
}
int dma_fence_work_chain(struct dma_fence_work *f, struct dma_fence *signal)
--
2.24.0
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Intel-gfx] [PATCH] drm/i915: Set fence_work.ops before dma_fence_init
2019-12-12 15:42 [Intel-gfx] [PATCH] drm/i915: Set fence_work.ops before dma_fence_init Chris Wilson
@ 2019-12-12 15:59 ` Matthew Auld
2019-12-12 19:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Matthew Auld @ 2019-12-12 15:59 UTC (permalink / raw)
To: Chris Wilson, intel-gfx; +Cc: Vince Weaver
On 12/12/2019 15:42, Chris Wilson wrote:
> Since dma_fence_init may call ops (because of a meaningless
> trace_dma_fence), we need to set the worker ops prior to that call.
>
> Reported-by: Vince Weaver <vincent.weaver@maine.edu>
> Fixes: 8e458fe2ee05 ("drm/i915: Generalise the clflush dma-worker")
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Matthew Auld <matthew.auld@intel.com>
> Cc: Vince Weaver <vincent.weaver@maine.edu>
Reviewed-by: Matthew Auld <matthew.auld@intel.com>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Set fence_work.ops before dma_fence_init
2019-12-12 15:42 [Intel-gfx] [PATCH] drm/i915: Set fence_work.ops before dma_fence_init Chris Wilson
2019-12-12 15:59 ` Matthew Auld
@ 2019-12-12 19:39 ` Patchwork
1 sibling, 0 replies; 3+ messages in thread
From: Patchwork @ 2019-12-12 19:39 UTC (permalink / raw)
To: Chris Wilson; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Set fence_work.ops before dma_fence_init
URL : https://patchwork.freedesktop.org/series/70837/
State : failure
== Summary ==
Applying: drm/i915: Set fence_work.ops before dma_fence_init
Using index info to reconstruct a base tree...
M drivers/gpu/drm/i915/i915_sw_fence_work.c
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-12-12 19:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-12 15:42 [Intel-gfx] [PATCH] drm/i915: Set fence_work.ops before dma_fence_init Chris Wilson
2019-12-12 15:59 ` Matthew Auld
2019-12-12 19:39 ` [Intel-gfx] ✗ Fi.CI.BAT: failure for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.