* [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper
@ 2019-06-06 20:30 Roman Gushchin
2019-06-06 21:51 ` Martin Lau
2019-06-07 0:00 ` Daniel Borkmann
0 siblings, 2 replies; 4+ messages in thread
From: Roman Gushchin @ 2019-06-06 20:30 UTC (permalink / raw)
To: Daniel Borkmann, bpf
Cc: Alexei Starovoitov, kernel-team, linux-kernel, Roman Gushchin,
Yonghong Song
Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
programs. An attempt to load such a program generates an error
like this:
libbpf:
0: (b7) r6 = 0
...
9: (85) call bpf_skb_cgroup_id#79
unknown func bpf_skb_cgroup_id#79
There are no particular reasons for denying it, and we have some
use cases where it might be useful.
So let's add it to the list of allowed helpers.
Signed-off-by: Roman Gushchin <guro@fb.com>
Cc: Yonghong Song <yhs@fb.com>
Cc: Alexei Starovoitov <ast@kernel.org>
Cc: Daniel Borkmann <daniel@iogearbox.net>
---
net/core/filter.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/net/core/filter.c b/net/core/filter.c
index 55bfc941d17a..f2777dc0b624 100644
--- a/net/core/filter.c
+++ b/net/core/filter.c
@@ -5919,6 +5919,10 @@ cg_skb_func_proto(enum bpf_func_id func_id, const struct bpf_prog *prog)
return &bpf_sk_storage_get_proto;
case BPF_FUNC_sk_storage_delete:
return &bpf_sk_storage_delete_proto;
+#ifdef CONFIG_SOCK_CGROUP_DATA
+ case BPF_FUNC_skb_cgroup_id:
+ return &bpf_skb_cgroup_id_proto;
+#endif
#ifdef CONFIG_INET
case BPF_FUNC_tcp_sock:
return &bpf_tcp_sock_proto;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper
2019-06-06 20:30 [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper Roman Gushchin
@ 2019-06-06 21:51 ` Martin Lau
2019-06-07 0:00 ` Daniel Borkmann
1 sibling, 0 replies; 4+ messages in thread
From: Martin Lau @ 2019-06-06 21:51 UTC (permalink / raw)
To: Roman Gushchin
Cc: Daniel Borkmann, bpf, Alexei Starovoitov, Kernel Team,
linux-kernel, Yonghong Song
On Thu, Jun 06, 2019 at 01:30:12PM -0700, Roman Gushchin wrote:
> Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> programs. An attempt to load such a program generates an error
> like this:
>
> libbpf:
> 0: (b7) r6 = 0
> ...
> 9: (85) call bpf_skb_cgroup_id#79
> unknown func bpf_skb_cgroup_id#79
>
> There are no particular reasons for denying it, and we have some
> use cases where it might be useful.
>
> So let's add it to the list of allowed helpers.
Acked-by: Martin KaFai Lau <kafai@fb.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper
2019-06-06 20:30 [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper Roman Gushchin
2019-06-06 21:51 ` Martin Lau
@ 2019-06-07 0:00 ` Daniel Borkmann
2019-06-07 0:09 ` Roman Gushchin
1 sibling, 1 reply; 4+ messages in thread
From: Daniel Borkmann @ 2019-06-07 0:00 UTC (permalink / raw)
To: Roman Gushchin, bpf
Cc: Alexei Starovoitov, kernel-team, linux-kernel, Yonghong Song
On 06/06/2019 10:30 PM, Roman Gushchin wrote:
> Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> programs. An attempt to load such a program generates an error
> like this:
>
> libbpf:
> 0: (b7) r6 = 0
> ...
> 9: (85) call bpf_skb_cgroup_id#79
> unknown func bpf_skb_cgroup_id#79
>
> There are no particular reasons for denying it, and we have some
> use cases where it might be useful.
>
> So let's add it to the list of allowed helpers.
>
> Signed-off-by: Roman Gushchin <guro@fb.com>
> Cc: Yonghong Song <yhs@fb.com>
> Cc: Alexei Starovoitov <ast@kernel.org>
> Cc: Daniel Borkmann <daniel@iogearbox.net>
Applied, thanks!
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper
2019-06-07 0:00 ` Daniel Borkmann
@ 2019-06-07 0:09 ` Roman Gushchin
0 siblings, 0 replies; 4+ messages in thread
From: Roman Gushchin @ 2019-06-07 0:09 UTC (permalink / raw)
To: Daniel Borkmann
Cc: bpf, Alexei Starovoitov, Kernel Team, linux-kernel, Yonghong Song
On Fri, Jun 07, 2019 at 02:00:20AM +0200, Daniel Borkmann wrote:
> On 06/06/2019 10:30 PM, Roman Gushchin wrote:
> > Currently bpf_skb_cgroup_id() is not supported for CGROUP_SKB
> > programs. An attempt to load such a program generates an error
> > like this:
> >
> > libbpf:
> > 0: (b7) r6 = 0
> > ...
> > 9: (85) call bpf_skb_cgroup_id#79
> > unknown func bpf_skb_cgroup_id#79
> >
> > There are no particular reasons for denying it, and we have some
> > use cases where it might be useful.
> >
> > So let's add it to the list of allowed helpers.
> >
> > Signed-off-by: Roman Gushchin <guro@fb.com>
> > Cc: Yonghong Song <yhs@fb.com>
> > Cc: Alexei Starovoitov <ast@kernel.org>
> > Cc: Daniel Borkmann <daniel@iogearbox.net>
>
> Applied, thanks!
Thank you, Daniel!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-07 0:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-06 20:30 [PATCH bpf-next] bpf: allow CGROUP_SKB programs to use bpf_skb_cgroup_id() helper Roman Gushchin
2019-06-06 21:51 ` Martin Lau
2019-06-07 0:00 ` Daniel Borkmann
2019-06-07 0:09 ` Roman Gushchin
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.