* [PATCH] drm/msm: Use div64_ul instead of do_div
@ 2022-04-26 13:21 Wan Jiabing
2022-06-15 12:48 ` Dmitry Baryshkov
2022-06-21 17:29 ` Abhinav Kumar
0 siblings, 2 replies; 3+ messages in thread
From: Wan Jiabing @ 2022-04-26 13:21 UTC (permalink / raw)
To: Rob Clark, Sean Paul, Abhinav Kumar, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno, linux-kernel
Cc: Wan Jiabing
Fix following coccicheck warning:
drivers/gpu/drm/msm/msm_gpu_devfreq.c:72:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.
Use div64_ul instead of do_div to avoid a possible truncation.
Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
---
drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
index d2539ca78c29..c2ea978c8921 100644
--- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
+++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
@@ -69,7 +69,7 @@ static void get_raw_dev_status(struct msm_gpu *gpu,
df->time = time;
busy_time *= USEC_PER_SEC;
- do_div(busy_time, sample_rate);
+ busy_time = div64_ul(busy_time, sample_rate);
if (WARN_ON(busy_time > ~0LU))
busy_time = ~0LU;
--
2.35.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Use div64_ul instead of do_div
2022-04-26 13:21 [PATCH] drm/msm: Use div64_ul instead of do_div Wan Jiabing
@ 2022-06-15 12:48 ` Dmitry Baryshkov
2022-06-21 17:29 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Baryshkov @ 2022-06-15 12:48 UTC (permalink / raw)
To: Wan Jiabing, Rob Clark, Sean Paul, Abhinav Kumar, David Airlie,
Daniel Vetter, linux-arm-msm, dri-devel, freedreno, linux-kernel
On 26/04/2022 16:21, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/gpu/drm/msm/msm_gpu_devfreq.c:72:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.
>
> Use div64_ul instead of do_div to avoid a possible truncation.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index d2539ca78c29..c2ea978c8921 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -69,7 +69,7 @@ static void get_raw_dev_status(struct msm_gpu *gpu,
> df->time = time;
>
> busy_time *= USEC_PER_SEC;
> - do_div(busy_time, sample_rate);
> + busy_time = div64_ul(busy_time, sample_rate);
> if (WARN_ON(busy_time > ~0LU))
> busy_time = ~0LU;
>
--
With best wishes
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/msm: Use div64_ul instead of do_div
2022-04-26 13:21 [PATCH] drm/msm: Use div64_ul instead of do_div Wan Jiabing
2022-06-15 12:48 ` Dmitry Baryshkov
@ 2022-06-21 17:29 ` Abhinav Kumar
1 sibling, 0 replies; 3+ messages in thread
From: Abhinav Kumar @ 2022-06-21 17:29 UTC (permalink / raw)
To: Wan Jiabing, Rob Clark, Sean Paul, David Airlie, Daniel Vetter,
linux-arm-msm, dri-devel, freedreno, linux-kernel
On 4/26/2022 6:21 AM, Wan Jiabing wrote:
> Fix following coccicheck warning:
> drivers/gpu/drm/msm/msm_gpu_devfreq.c:72:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_ul instead.
>
> Use div64_ul instead of do_div to avoid a possible truncation.
>
> Signed-off-by: Wan Jiabing <wanjiabing@vivo.com>
Reviewed-by: Abhinav Kumar <quic_abhinavk@quicinc.com>
> ---
> drivers/gpu/drm/msm/msm_gpu_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/msm_gpu_devfreq.c b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> index d2539ca78c29..c2ea978c8921 100644
> --- a/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> +++ b/drivers/gpu/drm/msm/msm_gpu_devfreq.c
> @@ -69,7 +69,7 @@ static void get_raw_dev_status(struct msm_gpu *gpu,
> df->time = time;
>
> busy_time *= USEC_PER_SEC;
> - do_div(busy_time, sample_rate);
> + busy_time = div64_ul(busy_time, sample_rate);
> if (WARN_ON(busy_time > ~0LU))
> busy_time = ~0LU;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-06-21 17:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-04-26 13:21 [PATCH] drm/msm: Use div64_ul instead of do_div Wan Jiabing
2022-06-15 12:48 ` Dmitry Baryshkov
2022-06-21 17:29 ` Abhinav Kumar
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.