From: Eric Blake <eblake@redhat.com>
To: Max Reitz <mreitz@redhat.com>, qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [PATCH] iotests/147: Fix drive parameters
Date: Thu, 6 Feb 2020 08:00:08 -0600 [thread overview]
Message-ID: <a9d9e3e2-5edc-6873-2e1c-6a8dbac35eb1@redhat.com> (raw)
In-Reply-To: <20200206130812.612960-1-mreitz@redhat.com>
On 2/6/20 7:08 AM, Max Reitz wrote:
> 8dff69b94 added an aio parameter to the drive parameter but forgot to
> add a comma before, thus breaking the test. Fix it again.
>
> Fixes: 8dff69b9415b4287e900358744b732195e1ab2e2
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/147 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Aha - that's what my bisect just landed on. And what's worse, the
breakage leaves behind orphaned qemu processes (four per failed test).
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
(I would have included it in my NBD pull request, except I sent that
just minutes before this email arrived, and I'm not sure when my next
pull request will be...)
>
> diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
> index 2b6f859a09..30782b8924 100755
> --- a/tests/qemu-iotests/147
> +++ b/tests/qemu-iotests/147
> @@ -134,7 +134,7 @@ class BuiltinNBD(NBDBlockdevAddBase):
> self.server.add_drive_raw('if=none,id=nbd-export,' +
> 'file=%s,' % test_img +
> 'format=%s,' % imgfmt +
> - 'cache=%s' % cachemode +
> + 'cache=%s,' % cachemode +
> 'aio=%s' % aiomode)
> self.server.launch()
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
next prev parent reply other threads:[~2020-02-06 14:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-06 13:08 [PATCH] iotests/147: Fix drive parameters Max Reitz
2020-02-06 14:00 ` Eric Blake [this message]
2020-02-06 17:38 ` Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a9d9e3e2-5edc-6873-2e1c-6a8dbac35eb1@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.