* [PATCH] iotests/147: Fix drive parameters
@ 2020-02-06 13:08 Max Reitz
2020-02-06 14:00 ` Eric Blake
2020-02-06 17:38 ` Max Reitz
0 siblings, 2 replies; 3+ messages in thread
From: Max Reitz @ 2020-02-06 13:08 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi, Max Reitz
8dff69b94 added an aio parameter to the drive parameter but forgot to
add a comma before, thus breaking the test. Fix it again.
Fixes: 8dff69b9415b4287e900358744b732195e1ab2e2
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/qemu-iotests/147 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
index 2b6f859a09..30782b8924 100755
--- a/tests/qemu-iotests/147
+++ b/tests/qemu-iotests/147
@@ -134,7 +134,7 @@ class BuiltinNBD(NBDBlockdevAddBase):
self.server.add_drive_raw('if=none,id=nbd-export,' +
'file=%s,' % test_img +
'format=%s,' % imgfmt +
- 'cache=%s' % cachemode +
+ 'cache=%s,' % cachemode +
'aio=%s' % aiomode)
self.server.launch()
--
2.24.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests/147: Fix drive parameters
2020-02-06 13:08 [PATCH] iotests/147: Fix drive parameters Max Reitz
@ 2020-02-06 14:00 ` Eric Blake
2020-02-06 17:38 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Eric Blake @ 2020-02-06 14:00 UTC (permalink / raw)
To: Max Reitz, qemu-block; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
On 2/6/20 7:08 AM, Max Reitz wrote:
> 8dff69b94 added an aio parameter to the drive parameter but forgot to
> add a comma before, thus breaking the test. Fix it again.
>
> Fixes: 8dff69b9415b4287e900358744b732195e1ab2e2
> Signed-off-by: Max Reitz <mreitz@redhat.com>
> ---
> tests/qemu-iotests/147 | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Aha - that's what my bisect just landed on. And what's worse, the
breakage leaves behind orphaned qemu processes (four per failed test).
Reviewed-by: Eric Blake <eblake@redhat.com>
Tested-by: Eric Blake <eblake@redhat.com>
(I would have included it in my NBD pull request, except I sent that
just minutes before this email arrived, and I'm not sure when my next
pull request will be...)
>
> diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
> index 2b6f859a09..30782b8924 100755
> --- a/tests/qemu-iotests/147
> +++ b/tests/qemu-iotests/147
> @@ -134,7 +134,7 @@ class BuiltinNBD(NBDBlockdevAddBase):
> self.server.add_drive_raw('if=none,id=nbd-export,' +
> 'file=%s,' % test_img +
> 'format=%s,' % imgfmt +
> - 'cache=%s' % cachemode +
> + 'cache=%s,' % cachemode +
> 'aio=%s' % aiomode)
> self.server.launch()
>
>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3226
Virtualization: qemu.org | libvirt.org
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] iotests/147: Fix drive parameters
2020-02-06 13:08 [PATCH] iotests/147: Fix drive parameters Max Reitz
2020-02-06 14:00 ` Eric Blake
@ 2020-02-06 17:38 ` Max Reitz
1 sibling, 0 replies; 3+ messages in thread
From: Max Reitz @ 2020-02-06 17:38 UTC (permalink / raw)
To: qemu-block; +Cc: Kevin Wolf, qemu-devel, Stefan Hajnoczi
[-- Attachment #1.1: Type: text/plain, Size: 315 bytes --]
On 06.02.20 14:08, Max Reitz wrote:
> 8dff69b94 added an aio parameter to the drive parameter but forgot to
> add a comma before, thus breaking the test. Fix it again.
>
> Fixes: 8dff69b9415b4287e900358744b732195e1ab2e2
> Signed-off-by: Max Reitz <mreitz@redhat.com>
Applied to my block branch.
Max
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-02-06 17:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 13:08 [PATCH] iotests/147: Fix drive parameters Max Reitz
2020-02-06 14:00 ` Eric Blake
2020-02-06 17:38 ` Max Reitz
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.