All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: Luis Pires <luis.pires@eldorado.org.br>, qemu-devel@nongnu.org
Cc: matheus.ferst@eldorado.org.br, qemu-ppc@nongnu.org,
	groug@kaod.org, david@gibson.dropbear.id.au
Subject: Re: [PATCH] target/ppc: fix single-step exception regression
Date: Tue, 1 Jun 2021 13:27:20 -0700	[thread overview]
Message-ID: <aa0c8f49-38d3-4ca0-89b8-0807cb57558f@linaro.org> (raw)
In-Reply-To: <20210601180237.296402-1-luis.pires@eldorado.org.br>

On 6/1/21 11:02 AM, Luis Pires wrote:
> +            if (is_jmp == DISAS_EXIT || is_jmp == DISAS_CHAIN) {
> +                /* We have not updated nip yet, so do it now */
> +                gen_update_nip(ctx, nip);
> +            }

This is incorrect.  Both EXIT and CHAIN *have* updated nip, but to something 
that isn't the next instruction.  E.g. return from interrupt.


r~


  reply	other threads:[~2021-06-01 20:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-01 18:02 [PATCH] target/ppc: fix single-step exception regression Luis Pires
2021-06-01 20:27 ` Richard Henderson [this message]
2021-06-02  8:55   ` David Gibson
2021-06-02 15:50     ` Richard Henderson
2021-06-02 17:13       ` Luis Fernando Fujita Pires

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa0c8f49-38d3-4ca0-89b8-0807cb57558f@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=david@gibson.dropbear.id.au \
    --cc=groug@kaod.org \
    --cc=luis.pires@eldorado.org.br \
    --cc=matheus.ferst@eldorado.org.br \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.