Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver

From: Hanjun Guo <guohanjun@huawei.com>
To: "lipeng (Y)" <lipeng321@huawei.com>, David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<linuxarm@huawei.com>, <salil.mehta@huawei.com>,
	<qumingguang@huawei.com>
Subject: Re: [PATCH V3 net-next 00/17] add some features and fix some bugs for HNS3 driver
Date: Thu, 21 Dec 2017 10:43:07 +0800	[thread overview]
Message-ID: <aa616fc0-0b35-12c4-bb63-d088ef417735@huawei.com> (raw)
In-Reply-To: <5619d233-a0bc-3bd9-daf4-cffb5486b396@huawei.com>

On 2017/12/21 10:27, lipeng (Y) wrote:
> 
> 
> On 2017/12/21 3:28, David Miller wrote:
>> From: Lipeng <lipeng321@huawei.com>
>> Date: Wed, 20 Dec 2017 16:43:02 +0800
>>
>>> This patchset adds some new feature support and fixes some bugs:
>>> [Patch 1/17 - 5/17] add the support to modify/query the tqp number
>>> through ethtool -L/l command, and also fix some related bugs for
>>> change tqp number.
>>> [Patch 6/17 - 9-17] add support vlan tag offload on tx&&rx direction
>>> for pf, and fix some related bugs.
>>> [patch 10/17 - 11/17] fix bugs for auto negotiation.
>>> [patch 12/17] adds support for ethtool command set_pauseparam.
>>> [patch 13/17 - 14/17] add support to update flow control settings after
>>> autoneg.
>>> [patch 15/17 - 17/17] fix some other bugs in net-next.
>> In your From: email field, as well as you and your colleagues signoffs
>> you are not using your full, real, name:
>>
>> ====================
>> From: Lipeng <lipeng321@huawei.com>
> 
> My first name is 'Peng' and Surname is 'Li'.
> But it is usually spelled as 'Lipeng' in one go when referring.
> This is quite usual convention with full names originating from
> China. Surnames comes first, followed by the first name and they
> both are inseparable while they are written as well.
> "Lipeng" is my full real name,  and my sign-off's appear like above.
> 
> 
> The name "lipeng"  is very common in china, many guys in HuaWei have the
> same name "lipeng",
> So my email is lipeng321@huawei.com,  to Distinguish from others.
> 
> other guys who named "lipeng" in huawei ,  their email have an id too,
> such as lipengxxx@huawei.com.
> 
> Wish the explanation is clear.

I think David was expecting two fixes here:

- The first one is that the Author of the patch
  needs to match the first Signed-off-by in
  the patch. In your patches, lots of them show
  that you are the Author but qumingguang is
  in the first Signed-off-by.

- It's better to use first name + last name:
  Peng Li <lipeng321@huawei.com>
  Mingguang Qu <qumingguang@huawei.com>

Thanks
Hanjun