* linux-next: build failure after merge of the watchdog tree
@ 2020-12-14 5:23 Stephen Rothwell
2020-12-14 6:09 ` Guenter Roeck
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2020-12-14 5:23 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: Enrico Weigelt, metux IT consult, Guenter Roeck,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 903 bytes --]
Hi all,
After merging the watchdog tree, today's linux-next build (x86_64
allmodconfig) failed like this:
In file included from include/linux/device.h:15,
from include/linux/acpi.h:15,
from drivers/watchdog/iTCO_wdt.c:48:
drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
| ^~
include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
| ^~~
Caused by commit
9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
I have used the wtchdog tree from next-20201211 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2020-12-14 5:23 linux-next: build failure after merge of the watchdog tree Stephen Rothwell
@ 2020-12-14 6:09 ` Guenter Roeck
2020-12-16 2:56 ` Stephen Rothwell
0 siblings, 1 reply; 22+ messages in thread
From: Guenter Roeck @ 2020-12-14 6:09 UTC (permalink / raw)
To: Stephen Rothwell, Wim Van Sebroeck
Cc: Enrico Weigelt, metux IT consult, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 1064 bytes --]
On 12/13/20 9:23 PM, Stephen Rothwell wrote:
> Hi all,
>
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> In file included from include/linux/device.h:15,
> from include/linux/acpi.h:15,
> from drivers/watchdog/iTCO_wdt.c:48:
> drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
> drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
> 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
> | ^~
Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
Guenter
> include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
> 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
> | ^~~
>
> Caused by commit
>
> 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
>
> I have used the wtchdog tree from next-20201211 for today.
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2020-12-14 6:09 ` Guenter Roeck
@ 2020-12-16 2:56 ` Stephen Rothwell
2020-12-16 4:11 ` Guenter Roeck
2020-12-16 15:27 ` Wim Van Sebroeck
0 siblings, 2 replies; 22+ messages in thread
From: Stephen Rothwell @ 2020-12-16 2:56 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: Guenter Roeck, Enrico Weigelt, metux IT consult,
Linux Kernel Mailing List, Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 1274 bytes --]
Hi all,
On Sun, 13 Dec 2020 22:09:55 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 12/13/20 9:23 PM, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the watchdog tree, today's linux-next build (x86_64
> > allmodconfig) failed like this:
> >
> > In file included from include/linux/device.h:15,
> > from include/linux/acpi.h:15,
> > from drivers/watchdog/iTCO_wdt.c:48:
> > drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
> > drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
> > 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
> > | ^~
>
> Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
>
> Guenter
>
> > include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
> > 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
> > | ^~~
> >
> > Caused by commit
> >
> > 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
>
> > I have used the wtchdog tree from next-20201211 for today.
I am still getting this build failure.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2020-12-16 2:56 ` Stephen Rothwell
@ 2020-12-16 4:11 ` Guenter Roeck
2020-12-16 15:27 ` Wim Van Sebroeck
1 sibling, 0 replies; 22+ messages in thread
From: Guenter Roeck @ 2020-12-16 4:11 UTC (permalink / raw)
To: Stephen Rothwell, Wim Van Sebroeck
Cc: Enrico Weigelt, metux IT consult, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1.1: Type: text/plain, Size: 1387 bytes --]
On 12/15/20 6:56 PM, Stephen Rothwell wrote:
> Hi all,
>
> On Sun, 13 Dec 2020 22:09:55 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 12/13/20 9:23 PM, Stephen Rothwell wrote:
>>> Hi all,
>>>
>>> After merging the watchdog tree, today's linux-next build (x86_64
>>> allmodconfig) failed like this:
>>>
>>> In file included from include/linux/device.h:15,
>>> from include/linux/acpi.h:15,
>>> from drivers/watchdog/iTCO_wdt.c:48:
>>> drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
>>> drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
>>> 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
>>> | ^~
>>
>> Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
>>
>> Guenter
>>
>>> include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
>>> 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
>>> | ^~~
>>>
>>> Caused by commit
>>>
>>> 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
>>
>>> I have used the wtchdog tree from next-20201211 for today.
>
> I am still getting this build failure.
>
Yes, we'll have to wait for Wim to either drop the patch or fix it up.
Guenter
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2020-12-16 2:56 ` Stephen Rothwell
2020-12-16 4:11 ` Guenter Roeck
@ 2020-12-16 15:27 ` Wim Van Sebroeck
2020-12-17 7:04 ` Wim Van Sebroeck
1 sibling, 1 reply; 22+ messages in thread
From: Wim Van Sebroeck @ 2020-12-16 15:27 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Enrico Weigelt, metux IT consult,
Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
It's on my todo list for today.
Kind ergards,
Wim.
> Hi all,
>
> On Sun, 13 Dec 2020 22:09:55 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
> >
> > On 12/13/20 9:23 PM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > After merging the watchdog tree, today's linux-next build (x86_64
> > > allmodconfig) failed like this:
> > >
> > > In file included from include/linux/device.h:15,
> > > from include/linux/acpi.h:15,
> > > from drivers/watchdog/iTCO_wdt.c:48:
> > > drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
> > > drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
> > > 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
> > > | ^~
> >
> > Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
> >
> > Guenter
> >
> > > include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
> > > 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
> > > | ^~~
> > >
> > > Caused by commit
> > >
> > > 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
> >
> > > I have used the wtchdog tree from next-20201211 for today.
>
> I am still getting this build failure.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2020-12-16 15:27 ` Wim Van Sebroeck
@ 2020-12-17 7:04 ` Wim Van Sebroeck
0 siblings, 0 replies; 22+ messages in thread
From: Wim Van Sebroeck @ 2020-12-17 7:04 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Enrico Weigelt, metux IT consult,
Linux Kernel Mailing List, Linux Next Mailing List
Hi Stephen,
Some operational work-related issues broke my planning yesterday.
I just made the changes to the watchdog tree.
My apologies,
Wim.
> Hi Stephen,
>
> It's on my todo list for today.
>
> Kind ergards,
> Wim.
>
> > Hi all,
> >
> > On Sun, 13 Dec 2020 22:09:55 -0800 Guenter Roeck <linux@roeck-us.net> wrote:
> > >
> > > On 12/13/20 9:23 PM, Stephen Rothwell wrote:
> > > > Hi all,
> > > >
> > > > After merging the watchdog tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >
> > > > In file included from include/linux/device.h:15,
> > > > from include/linux/acpi.h:15,
> > > > from drivers/watchdog/iTCO_wdt.c:48:
> > > > drivers/watchdog/iTCO_wdt.c: In function 'iTCO_wdt_start':
> > > > drivers/watchdog/iTCO_wdt.c:280:17: error: 'struct watchdog_device' has no member named 'dev'
> > > > 280 | dev_err(wd_dev->dev, "failed to reset NO_REBOOT flag, reboot disabled by hardware/BIOS\n");
> > > > | ^~
> > >
> > > Yes, that should have been wd_dev->parent. Sorry I didn't notice that earlier.
> > >
> > > Guenter
> > >
> > > > include/linux/dev_printk.h:112:11: note: in definition of macro 'dev_err'
> > > > 112 | _dev_err(dev, dev_fmt(fmt), ##__VA_ARGS__)
> > > > | ^~~
> > > >
> > > > Caused by commit
> > > >
> > > > 9c612b338fdf ("watchdog: iTCO_wdt: use dev_*() instead of pr_*() for logging")
> > >
> > > > I have used the wtchdog tree from next-20201211 for today.
> >
> > I am still getting this build failure.
> >
> > --
> > Cheers,
> > Stephen Rothwell
>
>
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build failure after merge of the watchdog tree
@ 2021-06-21 5:38 Stephen Rothwell
2021-06-21 8:08 ` Wim Van Sebroeck
2021-06-22 15:27 ` Vaittinen, Matti
0 siblings, 2 replies; 22+ messages in thread
From: Stephen Rothwell @ 2021-06-21 5:38 UTC (permalink / raw)
To: Wim Van Sebroeck
Cc: Guenter Roeck, Matti Vaittinen, Linux Kernel Mailing List,
Linux Next Mailing List
[-- Attachment #1: Type: text/plain, Size: 520 bytes --]
Hi all,
After merging the watchdog tree, today's linux-next build (x86_64
allmodconfig) failed like this:
ERROR: modpost: "bd70528_wdt_unlock" [drivers/rtc/rtc-bd70528.ko] undefined!
ERROR: modpost: "bd70528_wdt_lock" [drivers/rtc/rtc-bd70528.ko] undefined!
ERROR: modpost: "bd70528_wdt_set" [drivers/rtc/rtc-bd70528.ko] undefined!
Caused by commit
f2a5178b0b9f ("watchdog: bd70528 drop bd70528 support")
I have used the watchdog tree from next-20210618 for today.
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2021-06-21 5:38 Stephen Rothwell
@ 2021-06-21 8:08 ` Wim Van Sebroeck
2021-06-22 15:27 ` Vaittinen, Matti
1 sibling, 0 replies; 22+ messages in thread
From: Wim Van Sebroeck @ 2021-06-21 8:08 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Guenter Roeck, Matti Vaittinen, Linux Kernel Mailing List,
Linux Next Mailing List
Hi Stephen,
Fixed for tomorrow's pull.
Kind regards,
Wim.
> Hi all,
>
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: "bd70528_wdt_unlock" [drivers/rtc/rtc-bd70528.ko] undefined!
> ERROR: modpost: "bd70528_wdt_lock" [drivers/rtc/rtc-bd70528.ko] undefined!
> ERROR: modpost: "bd70528_wdt_set" [drivers/rtc/rtc-bd70528.ko] undefined!
>
> Caused by commit
>
> f2a5178b0b9f ("watchdog: bd70528 drop bd70528 support")
>
> I have used the watchdog tree from next-20210618 for today.
>
> --
> Cheers,
> Stephen Rothwell
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2021-06-21 5:38 Stephen Rothwell
2021-06-21 8:08 ` Wim Van Sebroeck
@ 2021-06-22 15:27 ` Vaittinen, Matti
1 sibling, 0 replies; 22+ messages in thread
From: Vaittinen, Matti @ 2021-06-22 15:27 UTC (permalink / raw)
To: sfr, wim; +Cc: linux, linux-next, linux-kernel, alexandre.belloni
Hi Guenter, Stephen, All,
On Mon, 2021-06-21 at 15:38 +1000, Stephen Rothwell wrote:
> Hi all,
>
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: modpost: "bd70528_wdt_unlock" [drivers/rtc/rtc-bd70528.ko]
> undefined!
> ERROR: modpost: "bd70528_wdt_lock" [drivers/rtc/rtc-bd70528.ko]
> undefined!
> ERROR: modpost: "bd70528_wdt_set" [drivers/rtc/rtc-bd70528.ko]
> undefined!
>
> Caused by commit
>
> f2a5178b0b9f ("watchdog: bd70528 drop bd70528 support")
This one requires the RTC change which was applied by Alexandre here:
https://lore.kernel.org/lkml/162422069731.1088764.12978660660257938127.b4-ty@bootlin.com/
This is my bad. I completely missed this dependency. I am really sorry!
The RTC change should get in prior the WDG change.
By the way, I am having a vacation and try to keep my computer turned
off so responses may be delayed.
Best Regards
Matti Vaittinen
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build failure after merge of the watchdog tree
@ 2014-09-26 5:40 Stephen Rothwell
2014-09-26 5:51 ` Guenter Roeck
2014-09-26 5:56 ` Pramod Gurav
0 siblings, 2 replies; 22+ messages in thread
From: Stephen Rothwell @ 2014-09-26 5:40 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-next, linux-kernel, Carlo Caione, Guenter Roeck
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
Hi Wim,
After merging the watchdog tree, today's linux-next build (arm
multi_v7_defconfig) failed like this:
drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
err = register_restart_handler(&meson_wdt->restart_handler);
^
drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
unregister_restart_handler(&meson_wdt->restart_handler);
^
Caused by commit 575f4153957b ("ARM: meson: add watchdog driver").
I have reverted that commit for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 5:40 Stephen Rothwell
@ 2014-09-26 5:51 ` Guenter Roeck
2014-09-26 6:29 ` Stephen Rothwell
2014-09-26 5:56 ` Pramod Gurav
1 sibling, 1 reply; 22+ messages in thread
From: Guenter Roeck @ 2014-09-26 5:51 UTC (permalink / raw)
To: Stephen Rothwell, Wim Van Sebroeck; +Cc: linux-next, linux-kernel, Carlo Caione
On 09/25/2014 10:40 PM, Stephen Rothwell wrote:
> Hi Wim,
>
> After merging the watchdog tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
>
> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
> drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
> err = register_restart_handler(&meson_wdt->restart_handler);
> ^
> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
> drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
> unregister_restart_handler(&meson_wdt->restart_handler);
> ^
>
> Caused by commit 575f4153957b ("ARM: meson: add watchdog driver").
>
> I have reverted that commit for today.
>
Those functions are defined by patches which reside in Andrew's tree.
Is that merged later ?
Guenter
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 5:51 ` Guenter Roeck
@ 2014-09-26 6:29 ` Stephen Rothwell
2014-09-26 6:49 ` Guenter Roeck
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2014-09-26 6:29 UTC (permalink / raw)
To: Guenter Roeck
Cc: Wim Van Sebroeck, linux-next, linux-kernel, Carlo Caione, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]
Hi Guenter,
On Thu, 25 Sep 2014 22:51:28 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> On 09/25/2014 10:40 PM, Stephen Rothwell wrote:
> > Hi Wim,
> >
> > After merging the watchdog tree, today's linux-next build (arm
> > multi_v7_defconfig) failed like this:
> >
> >
> > drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
> > drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
> > err = register_restart_handler(&meson_wdt->restart_handler);
> > ^
> > drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
> > drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
> > unregister_restart_handler(&meson_wdt->restart_handler);
> > ^
> >
> > Caused by commit 575f4153957b ("ARM: meson: add watchdog driver").
> >
> > I have reverted that commit for today.
> >
>
> Those functions are defined by patches which reside in Andrew's tree.
> Is that merged later ?
Yes, Andrew's tree is merged last and part of it depends on linux-next
itself ...
We really don't want these inter tree dependencies (especially with
Andrew's tree).
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 6:29 ` Stephen Rothwell
@ 2014-09-26 6:49 ` Guenter Roeck
0 siblings, 0 replies; 22+ messages in thread
From: Guenter Roeck @ 2014-09-26 6:49 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wim Van Sebroeck, linux-next, linux-kernel, Carlo Caione, Andrew Morton
On 09/25/2014 11:29 PM, Stephen Rothwell wrote:
> Hi Guenter,
>
> On Thu, 25 Sep 2014 22:51:28 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> On 09/25/2014 10:40 PM, Stephen Rothwell wrote:
>>> Hi Wim,
>>>
>>> After merging the watchdog tree, today's linux-next build (arm
>>> multi_v7_defconfig) failed like this:
>>>
>>>
>>> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
>>> drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
>>> err = register_restart_handler(&meson_wdt->restart_handler);
>>> ^
>>> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
>>> drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
>>> unregister_restart_handler(&meson_wdt->restart_handler);
>>> ^
>>>
>>> Caused by commit 575f4153957b ("ARM: meson: add watchdog driver").
>>>
>>> I have reverted that commit for today.
>>>
>>
>> Those functions are defined by patches which reside in Andrew's tree.
>> Is that merged later ?
>
> Yes, Andrew's tree is merged last and part of it depends on linux-next
> itself ...
>
> We really don't want these inter tree dependencies (especially with
> Andrew's tree).
>
Me not either. Question was how to get the restart handler patch set upstream.
Pushing it indirectly through merges of an immutable branch sounds like a good
idea, especially since there are by now patches in at least three subsystems
pending which depend on it.
Guenter
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 5:40 Stephen Rothwell
2014-09-26 5:51 ` Guenter Roeck
@ 2014-09-26 5:56 ` Pramod Gurav
2014-09-26 6:12 ` Guenter Roeck
1 sibling, 1 reply; 22+ messages in thread
From: Pramod Gurav @ 2014-09-26 5:56 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Wim Van Sebroeck, linux-next, linux-kernel, Carlo Caione, Guenter Roeck
On Friday 26 September 2014 11:10 AM, Stephen Rothwell wrote:
> Hi Wim,
>
> After merging the watchdog tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
>
> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
> drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
> err = register_restart_handler(&meson_wdt->restart_handler);
> ^
> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
> drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
> unregister_restart_handler(&meson_wdt->restart_handler);
> ^
>
This is because Guenter Roeck's restart_notifier mechanism [1] has not
yet made it to linux-next.
Oh yes, I checked it now its already pulled in master branch of linux-next.
> Caused by commit 575f4153957b ("ARM: meson: add watchdog driver").
>
> I have reverted that commit for today.
>
[1]: https://patchwork.kernel.org/patch/4746721/
Thanks
Pramod
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 5:56 ` Pramod Gurav
@ 2014-09-26 6:12 ` Guenter Roeck
2014-09-26 6:34 ` Stephen Rothwell
0 siblings, 1 reply; 22+ messages in thread
From: Guenter Roeck @ 2014-09-26 6:12 UTC (permalink / raw)
To: Pramod Gurav, Stephen Rothwell
Cc: Wim Van Sebroeck, linux-next, linux-kernel, Carlo Caione, Andrew Morton
On 09/25/2014 10:56 PM, Pramod Gurav wrote:
> On Friday 26 September 2014 11:10 AM, Stephen Rothwell wrote:
>> Hi Wim,
>>
>> After merging the watchdog tree, today's linux-next build (arm
>> multi_v7_defconfig) failed like this:
>>
>>
>> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_probe':
>> drivers/watchdog/meson_wdt.c:178:2: error: implicit declaration of function 'register_restart_handler' [-Werror=implicit-function-declaration]
>> err = register_restart_handler(&meson_wdt->restart_handler);
>> ^
>> drivers/watchdog/meson_wdt.c: In function 'meson_wdt_remove':
>> drivers/watchdog/meson_wdt.c:193:2: error: implicit declaration of function 'unregister_restart_handler' [-Werror=implicit-function-declaration]
>> unregister_restart_handler(&meson_wdt->restart_handler);
>> ^
>>
> This is because Guenter Roeck's restart_notifier mechanism [1] has not
> yet made it to linux-next.
>
No, that isn't it; it is there, coming from Andrew Morton's tree.
I think the problem is that the functions are not in Wim's tree,
and neither is ARCH_MESON. For this reason, the driver does not
build in Wim's tree, nor in my tree, which in turn explains why
we don't see the error. Maybe Stephen merges Andrew's tree after the
watchdog tree, and builds the watchdog code immediately after pulling it.
If the MESON code is already merged at that time we would see that error.
Question is how to handle that kind of situation. An idea, anyone ?
Someone suggested that I should create an immutable tree with the
restart handler patchset, which everyone using the restart handlers
could merge. Is that an option ? I could technically do that,
but I would want to pick the patches from Andrew's tree to retain
his sign-off. Andrew, any thoughts/comments ?
Thanks,
Guenter
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 6:12 ` Guenter Roeck
@ 2014-09-26 6:34 ` Stephen Rothwell
2014-09-26 6:47 ` Guenter Roeck
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2014-09-26 6:34 UTC (permalink / raw)
To: Guenter Roeck
Cc: Pramod Gurav, Wim Van Sebroeck, linux-next, linux-kernel,
Carlo Caione, Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 532 bytes --]
Hi Guenter,
On Thu, 25 Sep 2014 23:12:01 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>
> Someone suggested that I should create an immutable tree with the
> restart handler patchset, which everyone using the restart handlers
> could merge. Is that an option ? I could technically do that,
> but I would want to pick the patches from Andrew's tree to retain
> his sign-off. Andrew, any thoughts/comments ?
That is exactly what you should do.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: linux-next: build failure after merge of the watchdog tree
2014-09-26 6:34 ` Stephen Rothwell
@ 2014-09-26 6:47 ` Guenter Roeck
0 siblings, 0 replies; 22+ messages in thread
From: Guenter Roeck @ 2014-09-26 6:47 UTC (permalink / raw)
To: Stephen Rothwell
Cc: Pramod Gurav, Wim Van Sebroeck, linux-next, linux-kernel,
Carlo Caione, Andrew Morton
On 09/25/2014 11:34 PM, Stephen Rothwell wrote:
> Hi Guenter,
>
> On Thu, 25 Sep 2014 23:12:01 -0700 Guenter Roeck <linux@roeck-us.net> wrote:
>>
>> Someone suggested that I should create an immutable tree with the
>> restart handler patchset, which everyone using the restart handlers
>> could merge. Is that an option ? I could technically do that,
>> but I would want to pick the patches from Andrew's tree to retain
>> his sign-off. Andrew, any thoughts/comments ?
>
> That is exactly what you should do.
>
Ok, I'll do that first thing tomorrow morning.
Guenter
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build failure after merge of the watchdog tree
@ 2011-11-01 5:37 Stephen Rothwell
2011-11-01 12:02 ` Mark Brown
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2011-11-01 5:37 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-next, linux-kernel, Mark Brown
[-- Attachment #1: Type: text/plain, Size: 1298 bytes --]
Hi Wim,
After merging the watchdog tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_start':
drivers/watchdog/wm831x_wdt.c:56:40: error: 'struct watchdog_device' has no member named 'priv'
drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_stop':
drivers/watchdog/wm831x_wdt.c:79:40: error: 'struct watchdog_device' has no member named 'priv'
drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_ping':
drivers/watchdog/wm831x_wdt.c:102:40: error: 'struct watchdog_device' has no member named 'priv'
drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_set_timeout':
drivers/watchdog/wm831x_wdt.c:144:40: error: 'struct watchdog_device' has no member named 'priv'
drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_probe':
drivers/watchdog/wm831x_wdt.c:215:12: error: 'struct watchdog_device' has no member named 'parent'
drivers/watchdog/wm831x_wdt.c:216:12: error: 'struct watchdog_device' has no member named 'priv'
Caused by commit 5b04099edc42 ("watchdog: Convert wm831x driver to
watchdog core").
I have used the version of the watchdog tree from next-20111025 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2011-11-01 5:37 Stephen Rothwell
@ 2011-11-01 12:02 ` Mark Brown
2011-11-02 16:43 ` Wim Van Sebroeck
0 siblings, 1 reply; 22+ messages in thread
From: Mark Brown @ 2011-11-01 12:02 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: Wim Van Sebroeck, linux-next, linux-kernel
On Tue, Nov 01, 2011 at 04:37:48PM +1100, Stephen Rothwell wrote:
> drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_start':
> drivers/watchdog/wm831x_wdt.c:56:40: error: 'struct watchdog_device' has no member named 'priv'
> drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_stop':
Wim, it looks from this error like you've applied the original version of
this I sent on 20th July against the then current API, not the updated
version I sent on 25th July (which was resent on 4th October) after you
revised the API.
^ permalink raw reply [flat|nested] 22+ messages in thread
* Re: linux-next: build failure after merge of the watchdog tree
2011-11-01 12:02 ` Mark Brown
@ 2011-11-02 16:43 ` Wim Van Sebroeck
0 siblings, 0 replies; 22+ messages in thread
From: Wim Van Sebroeck @ 2011-11-02 16:43 UTC (permalink / raw)
To: Mark Brown, Stephen Rothwell; +Cc: linux-next, linux-kernel
Hi Marc, Stephen,
> On Tue, Nov 01, 2011 at 04:37:48PM +1100, Stephen Rothwell wrote:
>
> > drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_start':
> > drivers/watchdog/wm831x_wdt.c:56:40: error: 'struct watchdog_device' has no member named 'priv'
> > drivers/watchdog/wm831x_wdt.c: In function 'wm831x_wdt_stop':
>
> Wim, it looks from this error like you've applied the original version of
> this I sent on 20th July against the then current API, not the updated
> version I sent on 25th July (which was resent on 4th October) after you
> revised the API.
Yes indeed. I know I compile tested your second patch, but with all the changing of systems I screwed up and indeed used the first patch :-(.
Anyway, I corrected it.
Thanks,
Wim.
^ permalink raw reply [flat|nested] 22+ messages in thread
* linux-next: build failure after merge of the watchdog tree
@ 2011-01-10 3:12 Stephen Rothwell
2011-01-10 7:27 ` Wim Van Sebroeck
0 siblings, 1 reply; 22+ messages in thread
From: Stephen Rothwell @ 2011-01-10 3:12 UTC (permalink / raw)
To: Wim Van Sebroeck; +Cc: linux-next, linux-kernel, Philippe De Muyter
[-- Attachment #1: Type: text/plain, Size: 3405 bytes --]
Hi Wim,
After merging the watchdog tree, today's linux-next build (x86_64
allmodconfig) failed like this:
drivers/watchdog/m548x_wdt.c:31:26: error: asm/coldfire.h: No such file or directory
drivers/watchdog/m548x_wdt.c:32:26: error: asm/m548xsim.h: No such file or directory
drivers/watchdog/m548x_wdt.c:33:26: error: asm/m548xgpt.h: No such file or directory
drivers/watchdog/m548x_wdt.c: In function 'wdt_enable':
drivers/watchdog/m548x_wdt.c:47: error: implicit declaration of function '__raw_readl'
drivers/watchdog/m548x_wdt.c:47: error: 'MCF_MBAR' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:47: error: (Each undeclared identifier is reported only once
drivers/watchdog/m548x_wdt.c:47: error: for each function it appears in.)
drivers/watchdog/m548x_wdt.c:47: error: 'MCF_GPT_GMS0' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:48: error: 'MCF_GPT_GMS_TMS_GPIO' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:49: error: 'MCF_GPT_GMS_GPIO_MASK' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:50: error: 'MCF_GPT_GMS_OD' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:53: error: implicit declaration of function '__raw_writel'
drivers/watchdog/m548x_wdt.c:54: error: implicit declaration of function 'MCF_GPT_GCIR_PRE'
drivers/watchdog/m548x_wdt.c:54: error: 'MCF_BUSCLK' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:55: error: implicit declaration of function 'MCF_GPT_GCIR_CNT'
drivers/watchdog/m548x_wdt.c:55: error: 'MCF_GPT_GCIR0' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:56: error: implicit declaration of function 'MCF_GPT_GMS_OCPW'
drivers/watchdog/m548x_wdt.c:56: error: 'MCF_GPT_GMS_WDEN' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:56: error: 'MCF_GPT_GMS_CE' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c: In function 'wdt_disable':
drivers/watchdog/m548x_wdt.c:65: error: 'MCF_MBAR' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:65: error: 'MCF_GPT_GMS0' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:66: error: 'MCF_GPT_GMS_WDEN' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:66: error: 'MCF_GPT_GMS_CE' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c: In function 'wdt_keepalive':
drivers/watchdog/m548x_wdt.c:74: error: 'MCF_MBAR' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:74: error: 'MCF_GPT_GMS0' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c: In function 'm548x_wdt_init':
drivers/watchdog/m548x_wdt.c:197: error: 'MCF_MBAR' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:197: error: 'MCF_GPT_GCIR0' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c: In function 'm548x_wdt_exit':
drivers/watchdog/m548x_wdt.c:211: error: 'MCF_MBAR' undeclared (first use in this function)
drivers/watchdog/m548x_wdt.c:211: error: 'MCF_GPT_GCIR0' undeclared (first use in this function)
Caused by commit 91bb5dc5d42f400e18766f32a84ae585f61553a9 ("watchdog: Add
MCF548x watchdog driver").
I have used the watchdog tree from next-20110107 for today.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]
^ permalink raw reply [flat|nested] 22+ messages in thread* Re: linux-next: build failure after merge of the watchdog tree
2011-01-10 3:12 Stephen Rothwell
@ 2011-01-10 7:27 ` Wim Van Sebroeck
0 siblings, 0 replies; 22+ messages in thread
From: Wim Van Sebroeck @ 2011-01-10 7:27 UTC (permalink / raw)
To: Stephen Rothwell; +Cc: linux-next, linux-kernel, Philippe De Muyter
Hi Stephen,
> After merging the watchdog tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
This driver is for the m68K architecture. I apparently missed checking
the dependancy in Kconfig. I'll fix it today.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 22+ messages in thread
end of thread, other threads:[~2021-06-22 15:27 UTC | newest]
Thread overview: 22+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-12-14 5:23 linux-next: build failure after merge of the watchdog tree Stephen Rothwell
2020-12-14 6:09 ` Guenter Roeck
2020-12-16 2:56 ` Stephen Rothwell
2020-12-16 4:11 ` Guenter Roeck
2020-12-16 15:27 ` Wim Van Sebroeck
2020-12-17 7:04 ` Wim Van Sebroeck
-- strict thread matches above, loose matches on Subject: below --
2021-06-21 5:38 Stephen Rothwell
2021-06-21 8:08 ` Wim Van Sebroeck
2021-06-22 15:27 ` Vaittinen, Matti
2014-09-26 5:40 Stephen Rothwell
2014-09-26 5:51 ` Guenter Roeck
2014-09-26 6:29 ` Stephen Rothwell
2014-09-26 6:49 ` Guenter Roeck
2014-09-26 5:56 ` Pramod Gurav
2014-09-26 6:12 ` Guenter Roeck
2014-09-26 6:34 ` Stephen Rothwell
2014-09-26 6:47 ` Guenter Roeck
2011-11-01 5:37 Stephen Rothwell
2011-11-01 12:02 ` Mark Brown
2011-11-02 16:43 ` Wim Van Sebroeck
2011-01-10 3:12 Stephen Rothwell
2011-01-10 7:27 ` Wim Van Sebroeck
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.