From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Li Yang <leoyang.li@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()
Date: Fri, 10 Apr 2020 10:30:11 +0200 [thread overview]
Message-ID: <aa7006c9-8b83-5f30-86a6-8d60d290f824@web.de> (raw)
In-Reply-To: <0b718268-d330-dfc1-aca3-3dd3203363d7@cmss.chinamobile.com>
> Hardware experiments show that the negative return value is not just "-EPROBE_DEFER".
How much will this specific error code influence our understanding
of the discussed software situation?
>>> + ret = udc_controller->irq ? : -ENODEV;
>> Will it be clearer to specify values for all cases in such a conditional operator
>> (instead of leaving one case empty)?
>
> I don't know what you mean of "instead of leaving one case empty".
I suggest to reconsider also the proposed specification “… ? : …”.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Li Yang <leoyang.li@nxp.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Felipe Balbi <balbi@kernel.org>,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org
Subject: Re: usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()
Date: Fri, 10 Apr 2020 08:30:11 +0000 [thread overview]
Message-ID: <aa7006c9-8b83-5f30-86a6-8d60d290f824@web.de> (raw)
In-Reply-To: <0b718268-d330-dfc1-aca3-3dd3203363d7@cmss.chinamobile.com>
> Hardware experiments show that the negative return value is not just "-EPROBE_DEFER".
How much will this specific error code influence our understanding
of the discussed software situation?
>>> + ret = udc_controller->irq ? : -ENODEV;
>> Will it be clearer to specify values for all cases in such a conditional operator
>> (instead of leaving one case empty)?
>
> I don't know what you mean of "instead of leaving one case empty".
I suggest to reconsider also the proposed specification “… ? : …”.
Regards,
Markus
WARNING: multiple messages have this Message-ID (diff)
From: Markus Elfring <Markus.Elfring@web.de>
To: Tang Bin <tangbin@cmss.chinamobile.com>,
linux-usb@vger.kernel.org, linuxppc-dev@lists.ozlabs.org
Cc: Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Li Yang <leoyang.li@nxp.com>,
Shengju Zhang <zhangshengju@cmss.chinamobile.com>
Subject: Re: usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe()
Date: Fri, 10 Apr 2020 10:30:11 +0200 [thread overview]
Message-ID: <aa7006c9-8b83-5f30-86a6-8d60d290f824@web.de> (raw)
In-Reply-To: <0b718268-d330-dfc1-aca3-3dd3203363d7@cmss.chinamobile.com>
> Hardware experiments show that the negative return value is not just "-EPROBE_DEFER".
How much will this specific error code influence our understanding
of the discussed software situation?
>>> + ret = udc_controller->irq ? : -ENODEV;
>> Will it be clearer to specify values for all cases in such a conditional operator
>> (instead of leaving one case empty)?
>
> I don't know what you mean of "instead of leaving one case empty".
I suggest to reconsider also the proposed specification “… ? : …”.
Regards,
Markus
next prev parent reply other threads:[~2020-04-10 8:30 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 1:58 [PATCH] usb: gadget: fsl: Fix a wrong judgment in fsl_udc_probe() Tang Bin
2020-04-10 1:58 ` Tang Bin
2020-04-10 7:33 ` Markus Elfring
2020-04-10 7:33 ` Markus Elfring
2020-04-10 7:33 ` Markus Elfring
2020-04-10 8:05 ` Tang Bin
2020-04-10 8:05 ` Tang Bin
2020-04-10 8:05 ` Tang Bin
2020-04-10 8:30 ` Markus Elfring [this message]
2020-04-10 8:30 ` Markus Elfring
2020-04-10 8:30 ` Markus Elfring
2020-04-10 9:15 ` Tang Bin
2020-04-10 9:15 ` Tang Bin
2020-04-10 9:15 ` Tang Bin
2020-04-14 8:30 ` [PATCH] " Dan Carpenter
2020-04-14 8:30 ` Dan Carpenter
2020-04-14 8:30 ` Dan Carpenter
2020-04-14 9:13 ` Tang Bin
2020-04-14 9:13 ` Tang Bin
2020-04-14 9:13 ` Tang Bin
2020-05-22 22:40 ` Li Yang
2020-05-22 22:40 ` Li Yang
2020-05-22 22:40 ` Li Yang
2020-04-10 9:36 ` Sergei Shtylyov
2020-04-10 9:36 ` Sergei Shtylyov
2020-04-10 9:47 ` Sergei Shtylyov
2020-04-10 9:47 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aa7006c9-8b83-5f30-86a6-8d60d290f824@web.de \
--to=markus.elfring@web.de \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=leoyang.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=tangbin@cmss.chinamobile.com \
--cc=zhangshengju@cmss.chinamobile.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.