* [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
@ 2019-10-31 9:07 Felipe Balbi
2019-10-31 9:15 ` Pavel Hofman
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2019-10-31 9:07 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Linux USB, Felipe Balbi, Roger Quadros
When disabling an endpoint which has cancelled requests, we should
make sure to giveback requests that are currently pending in the
cancelled list, otherwise we may fall into a situation where command
completion interrupt fires after endpoint has been disabled, therefore
causing a splat.
Fixes: fec9095bdef4 "usb: dwc3: gadget: remove wait_end_transfer"
Reported-by: Roger Quadros <rogerq@ti.com>
Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com>
---
Greg,
please apply this as a patch, if it's not too much to ask. Otherwise I
can add this to my pull request for the next merge window.
cheers
drivers/usb/dwc3/gadget.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/drivers/usb/dwc3/gadget.c b/drivers/usb/dwc3/gadget.c
index 86dc1db788a9..a9aba716bf80 100644
--- a/drivers/usb/dwc3/gadget.c
+++ b/drivers/usb/dwc3/gadget.c
@@ -707,6 +707,12 @@ static void dwc3_remove_requests(struct dwc3 *dwc, struct dwc3_ep *dep)
dwc3_gadget_giveback(dep, req, -ESHUTDOWN);
}
+
+ while (!list_empty(&dep->cancelled_list)) {
+ req = next_request(&dep->cancelled_list);
+
+ dwc3_gadget_giveback(dep, req, -ESHUTDOWN);
+ }
}
/**
--
2.23.0
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
2019-10-31 9:07 [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers Felipe Balbi
@ 2019-10-31 9:15 ` Pavel Hofman
2019-10-31 9:23 ` Felipe Balbi
0 siblings, 1 reply; 6+ messages in thread
From: Pavel Hofman @ 2019-10-31 9:15 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Linux USB, Roger Quadros
Hi,
Dne 31. 10. 19 v 10:07 Felipe Balbi napsal(a):
> When disabling an endpoint which has cancelled requests, we should
> make sure to giveback requests that are currently pending in the
> cancelled list, otherwise we may fall into a situation where command
> completion interrupt fires after endpoint has been disabled, therefore
> causing a splat.
>
Please is this problem (and its solution) also applicable to dwc2 (i.e.
e.g. RPi4)?
Thanks a lot,
Pavel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
2019-10-31 9:15 ` Pavel Hofman
@ 2019-10-31 9:23 ` Felipe Balbi
2019-10-31 10:11 ` Pavel Hofman
0 siblings, 1 reply; 6+ messages in thread
From: Felipe Balbi @ 2019-10-31 9:23 UTC (permalink / raw)
To: Pavel Hofman; +Cc: Linux USB, Roger Quadros
Hi,
Pavel Hofman <pavel.hofman@ivitera.com> writes:
> Hi,
>
> Dne 31. 10. 19 v 10:07 Felipe Balbi napsal(a):
>> When disabling an endpoint which has cancelled requests, we should
>> make sure to giveback requests that are currently pending in the
>> cancelled list, otherwise we may fall into a situation where command
>> completion interrupt fires after endpoint has been disabled, therefore
>> causing a splat.
>>
>
> Please is this problem (and its solution) also applicable to dwc2 (i.e.
> e.g. RPi4)?
different driver, so no.
--
balbi
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
2019-10-31 9:23 ` Felipe Balbi
@ 2019-10-31 10:11 ` Pavel Hofman
2019-10-31 10:47 ` Roger Quadros
2019-10-31 10:57 ` Felipe Balbi
0 siblings, 2 replies; 6+ messages in thread
From: Pavel Hofman @ 2019-10-31 10:11 UTC (permalink / raw)
To: Felipe Balbi; +Cc: Linux USB, Roger Quadros
Dne 31. 10. 19 v 10:23 Felipe Balbi napsal(a):
>
>>>
>>
>> Please is this problem (and its solution) also applicable to dwc2 (i.e.
>> e.g. RPi4)?
>
> different driver, so no.
Yes the driver is different, but I was wondering if such situation can
occur in dwc2 too and (if so) whether it is already taken care of.
Disconnecting the USB device is a standard operation.
Thanks a lot. Regards,
Pavel.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
2019-10-31 10:11 ` Pavel Hofman
@ 2019-10-31 10:47 ` Roger Quadros
2019-10-31 10:57 ` Felipe Balbi
1 sibling, 0 replies; 6+ messages in thread
From: Roger Quadros @ 2019-10-31 10:47 UTC (permalink / raw)
To: Pavel Hofman, Felipe Balbi; +Cc: Linux USB
Hi,
On 31/10/2019 12:11, Pavel Hofman wrote:
> Dne 31. 10. 19 v 10:23 Felipe Balbi napsal(a):
>>
>>>>
>>>
>>> Please is this problem (and its solution) also applicable to dwc2 (i.e.
>>> e.g. RPi4)?
>>
>> different driver, so no.
>
> Yes the driver is different, but I was wondering if such situation can occur in dwc2 too and (if so) whether it is already taken care of. Disconnecting the USB device is a standard operation.
I discovered this problem on dwc3 while using g_audio gadget. see here:
https://www.spinics.net/lists/linux-usb/msg187244.html
You might want to do a similar test with dwc2?
>
> Thanks a lot. Regards,
>
> Pavel.
--
cheers,
-roger
Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers
2019-10-31 10:11 ` Pavel Hofman
2019-10-31 10:47 ` Roger Quadros
@ 2019-10-31 10:57 ` Felipe Balbi
1 sibling, 0 replies; 6+ messages in thread
From: Felipe Balbi @ 2019-10-31 10:57 UTC (permalink / raw)
To: Pavel Hofman; +Cc: Linux USB, Roger Quadros
Hi,
Pavel Hofman <pavel.hofman@ivitera.com> writes:
> Dne 31. 10. 19 v 10:23 Felipe Balbi napsal(a):
>>
>>>>
>>>
>>> Please is this problem (and its solution) also applicable to dwc2 (i.e.
>>> e.g. RPi4)?
>>
>> different driver, so no.
>
> Yes the driver is different, but I was wondering if such situation can
> occur in dwc2 too and (if so) whether it is already taken care of.
> Disconnecting the USB device is a standard operation.
technically, it can. But I don't remember of any such bug report for
dwc2. Have you faced something like this?
--
balbi
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-31 10:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-31 9:07 [PATCH] usb: dwc3: gadget: fix race when disabling ep with cancelled xfers Felipe Balbi
2019-10-31 9:15 ` Pavel Hofman
2019-10-31 9:23 ` Felipe Balbi
2019-10-31 10:11 ` Pavel Hofman
2019-10-31 10:47 ` Roger Quadros
2019-10-31 10:57 ` Felipe Balbi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.