All of lore.kernel.org
 help / color / mirror / Atom feed
From: "yukuai (C)" <yukuai3@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: <axboe@kernel.dk>, <tj@kernel.org>, <linux-block@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <cgroups@vger.kernel.org>,
	<yi.zhang@huawei.com>
Subject: Re: [PATCH 4/4] block: cancel all throttled bios in blk_cleanup_queue()
Date: Thu, 23 Sep 2021 21:31:37 +0800	[thread overview]
Message-ID: <aab71a7e-830b-ac48-67f1-83be4e8e364f@huawei.com> (raw)
In-Reply-To: <YUs/CcSKqNoIIXoW@infradead.org>

On 2021/09/22 22:34, Christoph Hellwig wrote:
> On Wed, Sep 22, 2021 at 08:51:15PM +0800, Yu Kuai wrote:
>> Throttled bios can't be issued after queue is dying in
>> blk_cleanup_queue(), thus it's better to cancel them immediately
>> rather than waiting for throttle is done.
>>
>> For example, if user thread is throttled with low bps while is
>> issuing large io, and the device is deleted. The user thread will
>> wait for a long time for io to return.
> 
> blk_cleanup_queue is too late, this will need to go into del_gendisk
> and on top of my "tear down file system I/O in del_gendisk" series.
> .
> 

Hi,

I see what your series is trying to do, it semms not easy to
collaborate. I'll wait for your series to applied if you don't mind,
or you can take over this series.

Thanks,
Kuai

WARNING: multiple messages have this Message-ID (diff)
From: "yukuai (C)" <yukuai3@huawei.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: axboe@kernel.dk, tj@kernel.org, linux-block@vger.kernel.org,
	linux-kernel@vger.kernel.org, cgroups@vger.kernel.org,
	yi.zhang@huawei.com
Subject: Re: [PATCH 4/4] block: cancel all throttled bios in blk_cleanup_queue()
Date: Thu, 23 Sep 2021 21:31:37 +0800	[thread overview]
Message-ID: <aab71a7e-830b-ac48-67f1-83be4e8e364f@huawei.com> (raw)
In-Reply-To: <YUs/CcSKqNoIIXoW@infradead.org>

On 2021/09/22 22:34, Christoph Hellwig wrote:
> On Wed, Sep 22, 2021 at 08:51:15PM +0800, Yu Kuai wrote:
>> Throttled bios can't be issued after queue is dying in
>> blk_cleanup_queue(), thus it's better to cancel them immediately
>> rather than waiting for throttle is done.
>>
>> For example, if user thread is throttled with low bps while is
>> issuing large io, and the device is deleted. The user thread will
>> wait for a long time for io to return.
> 
> blk_cleanup_queue is too late, this will need to go into del_gendisk
> and on top of my "tear down file system I/O in del_gendisk" series.
> .
> 

Hi,

I see what your series is trying to do, it semms not easy to
collaborate. I'll wait for your series to applied if you don't mind,
or you can take over this series.

Thanks,
Kuai

  reply	other threads:[~2021-09-23 13:31 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-22 12:51 [PATCH 0/4] cancel all throttled bios in blk_cleanup_queue() Yu Kuai
2021-09-22 12:51 ` Yu Kuai
2021-09-22 12:51 ` [PATCH 1/4] Revert "blk-throttle: remove tg_drain_bios" Yu Kuai
2021-09-22 12:51   ` Yu Kuai
2021-09-22 12:51 ` [PATCH 2/4] blk-throtl: don't warn in tg_drain_bios() Yu Kuai
2021-09-22 12:51   ` Yu Kuai
2021-09-22 12:51 ` [PATCH 3/4] blk-throtl: introduce blk_throtl_cancel_bios() Yu Kuai
2021-09-22 12:51   ` Yu Kuai
2021-09-22 12:51 ` [PATCH 4/4] block: cancel all throttled bios in blk_cleanup_queue() Yu Kuai
2021-09-22 12:51   ` Yu Kuai
2021-09-22 14:34   ` Christoph Hellwig
2021-09-23 13:31     ` yukuai (C) [this message]
2021-09-23 13:31       ` yukuai (C)

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aab71a7e-830b-ac48-67f1-83be4e8e364f@huawei.com \
    --to=yukuai3@huawei.com \
    --cc=axboe@kernel.dk \
    --cc=cgroups@vger.kernel.org \
    --cc=hch@infradead.org \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tj@kernel.org \
    --cc=yi.zhang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.