All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
	JBeulich@suse.com, Stefano Stabellini <stefanos@xilinx.com>
Subject: Re: [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability
Date: Sun, 21 Apr 2019 18:14:26 +0100	[thread overview]
Message-ID: <aad78004-8aec-edc3-13b6-20baff39c9e5@arm.com> (raw)
In-Reply-To: <alpine.DEB.2.10.1904191618390.1370@sstabellini-ThinkPad-X260>

Hi Stefano,

On 4/20/19 12:20 AM, Stefano Stabellini wrote:
> On Wed, 27 Feb 2019, Julien Grall wrote:
>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>>> index 30cfb01..5b8fcc5 100644
>>> --- a/xen/arch/arm/p2m.c
>>> +++ b/xen/arch/arm/p2m.c
>>> @@ -1068,9 +1068,24 @@ int unmap_regions_p2mt(struct domain *d,
>>>    int map_mmio_regions(struct domain *d,
>>>                         gfn_t start_gfn,
>>>                         unsigned long nr,
>>> -                     mfn_t mfn)
>>> +                     mfn_t mfn,
>>> +                     uint32_t cache_policy)
>>
>> Rather than extending map_mmio_regions, I would prefer if we kill this
>> function (and unmap_mmio_mmio_regions) and instead use map_regions_p2mt.
>>
>> This means the conversation to p2mt should be done in the DOMCTL handling.
> 
> map_regions_p2mt is an arm specific function. map_mmio_regions is the
> common function across x86 and arm, called from common code.

I really dislike the idea to have two functions doing exactly the same 
but have different parameters.

If map_regions_p2mt can't be used in the common code, then I would like 
that map_mmio_regions to be renamed to arch_domctl_map_mmio_regions (or 
something similar). So it is pretty clear it should be not used in other 
places.

All the other callers of map_mmio_regions should be replaced with 
map_regions_p2mt.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

WARNING: multiple messages have this Message-ID (diff)
From: Julien Grall <julien.grall@arm.com>
To: Stefano Stabellini <sstabellini@kernel.org>
Cc: xen-devel@lists.xenproject.org, andrew.cooper3@citrix.com,
	JBeulich@suse.com, Stefano Stabellini <stefanos@xilinx.com>
Subject: Re: [Xen-devel] [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability
Date: Sun, 21 Apr 2019 18:14:26 +0100	[thread overview]
Message-ID: <aad78004-8aec-edc3-13b6-20baff39c9e5@arm.com> (raw)
Message-ID: <20190421171426.yVTbNNYq4qAhxWFJQFwKRH7CKsx0DfxsMcZoU7X4b1g@z> (raw)
In-Reply-To: <alpine.DEB.2.10.1904191618390.1370@sstabellini-ThinkPad-X260>

Hi Stefano,

On 4/20/19 12:20 AM, Stefano Stabellini wrote:
> On Wed, 27 Feb 2019, Julien Grall wrote:
>>> diff --git a/xen/arch/arm/p2m.c b/xen/arch/arm/p2m.c
>>> index 30cfb01..5b8fcc5 100644
>>> --- a/xen/arch/arm/p2m.c
>>> +++ b/xen/arch/arm/p2m.c
>>> @@ -1068,9 +1068,24 @@ int unmap_regions_p2mt(struct domain *d,
>>>    int map_mmio_regions(struct domain *d,
>>>                         gfn_t start_gfn,
>>>                         unsigned long nr,
>>> -                     mfn_t mfn)
>>> +                     mfn_t mfn,
>>> +                     uint32_t cache_policy)
>>
>> Rather than extending map_mmio_regions, I would prefer if we kill this
>> function (and unmap_mmio_mmio_regions) and instead use map_regions_p2mt.
>>
>> This means the conversation to p2mt should be done in the DOMCTL handling.
> 
> map_regions_p2mt is an arm specific function. map_mmio_regions is the
> common function across x86 and arm, called from common code.

I really dislike the idea to have two functions doing exactly the same 
but have different parameters.

If map_regions_p2mt can't be used in the common code, then I would like 
that map_mmio_regions to be renamed to arch_domctl_map_mmio_regions (or 
something similar). So it is pretty clear it should be not used in other 
places.

All the other callers of map_mmio_regions should be replaced with 
map_regions_p2mt.

Cheers,

-- 
Julien Grall

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xenproject.org
https://lists.xenproject.org/mailman/listinfo/xen-devel

  reply	other threads:[~2019-04-21 17:14 UTC|newest]

Thread overview: 67+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-26 23:06 [PATCH 0/6] iomem cacheability Stefano Stabellini
2019-02-26 23:07 ` [PATCH 1/6] xen: extend XEN_DOMCTL_memory_mapping to handle cacheability Stefano Stabellini
2019-02-26 23:18   ` Julien Grall
2019-04-20  0:02     ` Stefano Stabellini
2019-04-20  0:02       ` [Xen-devel] " Stefano Stabellini
2019-04-21 17:32       ` Julien Grall
2019-04-21 17:32         ` [Xen-devel] " Julien Grall
2019-04-22 21:59         ` Stefano Stabellini
2019-04-22 21:59           ` [Xen-devel] " Stefano Stabellini
2019-04-24 10:42           ` Julien Grall
2019-04-24 10:42             ` [Xen-devel] " Julien Grall
2019-02-27 10:34   ` Jan Beulich
2019-04-17 21:12     ` Stefano Stabellini
2019-04-17 21:12       ` [Xen-devel] " Stefano Stabellini
2019-04-17 21:25       ` Julien Grall
2019-04-17 21:25         ` [Xen-devel] " Julien Grall
2019-04-17 21:55         ` Stefano Stabellini
2019-04-17 21:55           ` [Xen-devel] " Stefano Stabellini
2019-04-25 10:41       ` Jan Beulich
2019-04-25 10:41         ` [Xen-devel] " Jan Beulich
2019-04-25 22:31         ` Stefano Stabellini
2019-04-25 22:31           ` [Xen-devel] " Stefano Stabellini
2019-04-26  7:12           ` Jan Beulich
2019-04-26  7:12             ` [Xen-devel] " Jan Beulich
2019-02-27 19:28   ` Julien Grall
2019-04-19 23:20     ` Stefano Stabellini
2019-04-19 23:20       ` [Xen-devel] " Stefano Stabellini
2019-04-21 17:14       ` Julien Grall [this message]
2019-04-21 17:14         ` Julien Grall
2019-04-22 17:33         ` Stefano Stabellini
2019-04-22 17:33           ` [Xen-devel] " Stefano Stabellini
2019-04-22 17:42           ` Julien Grall
2019-04-22 17:42             ` [Xen-devel] " Julien Grall
2019-02-27 21:02   ` Julien Grall
2019-02-26 23:07 ` [PATCH 2/6] libxc: xc_domain_memory_mapping, " Stefano Stabellini
2019-02-26 23:07 ` [PATCH 3/6] libxl/xl: add cacheability option to iomem Stefano Stabellini
2019-02-27 20:02   ` Julien Grall
2019-04-19 23:13     ` Stefano Stabellini
2019-04-19 23:13       ` [Xen-devel] " Stefano Stabellini
2019-02-26 23:07 ` [PATCH 4/6] xen/arm: keep track of reserved-memory regions Stefano Stabellini
2019-02-28 14:38   ` Julien Grall
2019-02-26 23:07 ` [PATCH 5/6] xen/arm: map reserved-memory regions as normal memory in dom0 Stefano Stabellini
2019-02-26 23:45   ` Julien Grall
2019-04-22 22:42     ` Stefano Stabellini
2019-04-22 22:42       ` [Xen-devel] " Stefano Stabellini
2019-04-23  8:09       ` Julien Grall
2019-04-23  8:09         ` [Xen-devel] " Julien Grall
2019-04-23 17:32         ` Stefano Stabellini
2019-04-23 17:32           ` [Xen-devel] " Stefano Stabellini
2019-04-23 18:37           ` Julien Grall
2019-04-23 18:37             ` [Xen-devel] " Julien Grall
2019-04-23 21:34             ` Stefano Stabellini
2019-04-23 21:34               ` [Xen-devel] " Stefano Stabellini
2019-02-26 23:07 ` [PATCH 6/6] xen/docs: how to map a page between dom0 and domU using iomem Stefano Stabellini
2019-03-03 17:20 ` [PATCH 0/6] iomem cacheability Amit Tomer
2019-03-05 21:22   ` Stefano Stabellini
2019-03-05 22:45     ` Julien Grall
2019-03-06 11:46       ` Amit Tomer
2019-03-06 22:42         ` Stefano Stabellini
2019-03-06 22:59           ` Julien Grall
2019-03-07  8:42             ` Amit Tomer
2019-03-07 10:04               ` Julien Grall
2019-03-07 21:24                 ` Stefano Stabellini
2019-03-08 10:10                   ` Amit Tomer
2019-03-08 16:37                     ` Julien Grall
2019-03-08 17:44                       ` Amit Tomer
2019-03-06 11:30     ` Amit Tomer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aad78004-8aec-edc3-13b6-20baff39c9e5@arm.com \
    --to=julien.grall@arm.com \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=sstabellini@kernel.org \
    --cc=stefanos@xilinx.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.