* checkpatch error
@ 2019-10-08 4:02 Zhenzhong Duan
2019-10-08 7:31 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Zhenzhong Duan @ 2019-10-08 4:02 UTC (permalink / raw)
To: LKML; +Cc: apw, joe
Hi,
When I run checkpatch.pl with a patch doing reverting operation, it
reports a false positive error, Should I ignore the error or it's a bug?
0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch
---------------------------------------------------------------
ERROR: Please use git commit description style 'commit <12+ chars of
sha1> ("<title line>")' - ie: 'commit 090d54bcbc54 ("Revert
"x86/paravirt: Set up the v'
#14:
The similar change for XEN is in commit 090d54bcbc54 ("Revert
total: 1 errors, 0 warnings, 31 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or
--fix-inplace.
# cat 0001-Revert-KVM-X86-Fix-setup-the-virt_spin_lock_key-befo.patch
From 5d90690ba0476cab223f5e1d13955858b9c91623 Mon Sep 17 00:00:00 2001
From: Zhenzhong Duan <zhenzhong.duan@oracle.com>
Date: Mon, 7 Oct 2019 09:20:58 +0800
Subject: [PATCH v5 1/5] Revert "KVM: X86: Fix setup the virt_spin_lock_key
before static key get initialized"
This reverts commit 34226b6b70980a8f81fff3c09a2c889f77edeeff.
Commit 8990cac6e5ea ("x86/jump_label: Initialize static branching
early") adds jump_label_init() call in setup_arch() to make static
keys initialized early, so we could use the original simpler code
again.
The similar change for XEN is in commit 090d54bcbc54 ("Revert
"x86/paravirt: Set up the virt_spin_lock_key after static keys get
initialized"")
...
Thanks
Zhenzhong
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: checkpatch error
2019-10-08 4:02 checkpatch error Zhenzhong Duan
@ 2019-10-08 7:31 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2019-10-08 7:31 UTC (permalink / raw)
To: Zhenzhong Duan, LKML; +Cc: apw
On Tue, 2019-10-08 at 12:02 +0800, Zhenzhong Duan wrote:
> Hi,
>
> When I run checkpatch.pl with a patch doing reverting operation, it
> reports a false positive error, Should I ignore the error or it's a bug?
Ignore it.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-10-08 7:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-10-08 4:02 checkpatch error Zhenzhong Duan
2019-10-08 7:31 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.