* [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces
@ 2021-06-15 10:02 Ross Burton
2021-06-15 12:28 ` [OE-core] " Bruce Ashfield
2021-06-15 17:57 ` Khem Raj
0 siblings, 2 replies; 4+ messages in thread
From: Ross Burton @ 2021-06-15 10:02 UTC (permalink / raw)
To: openembedded-core
From: Matt Spencer <matt.spencer@arm.com>
We need to prevent systemd-network from managing veth interface when
using platforms like k3s as they control creation and management of the
interfaces.
Signed-off-by: Matt Spencer <matt.spencer@arm.com>
Signed-off-by: Ross Burton <ross.burton@arm.com>
---
meta/recipes-core/systemd/systemd-conf/wired.network | 1 +
1 file changed, 1 insertion(+)
diff --git a/meta/recipes-core/systemd/systemd-conf/wired.network b/meta/recipes-core/systemd/systemd-conf/wired.network
index e7b69970d6..7406287248 100644
--- a/meta/recipes-core/systemd/systemd-conf/wired.network
+++ b/meta/recipes-core/systemd/systemd-conf/wired.network
@@ -1,5 +1,6 @@
[Match]
Type=ether
+Name=!veth*
KernelCommandLine=!nfsroot
KernelCommandLine=!ip
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces
2021-06-15 10:02 [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces Ross Burton
@ 2021-06-15 12:28 ` Bruce Ashfield
2021-06-15 18:35 ` Scott Murray
2021-06-15 17:57 ` Khem Raj
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Ashfield @ 2021-06-15 12:28 UTC (permalink / raw)
To: Ross Burton; +Cc: Patches and discussions about the oe-core layer
On Tue, Jun 15, 2021 at 6:02 AM Ross Burton <ross@burtonini.com> wrote:
>
> From: Matt Spencer <matt.spencer@arm.com>
>
> We need to prevent systemd-network from managing veth interface when
> using platforms like k3s as they control creation and management of the
> interfaces.
FWIW, I think this may surprise/break people in other use cases. I had
mentioned this to matt directly as well.
The situation is not as clear as that commit message implies. networkd
*can* cause issues with veth devices, but not always.
Not trying to stop the patch, but I wanted my concerns to be archived :D
Bruce
>
> Signed-off-by: Matt Spencer <matt.spencer@arm.com>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta/recipes-core/systemd/systemd-conf/wired.network | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd-conf/wired.network b/meta/recipes-core/systemd/systemd-conf/wired.network
> index e7b69970d6..7406287248 100644
> --- a/meta/recipes-core/systemd/systemd-conf/wired.network
> +++ b/meta/recipes-core/systemd/systemd-conf/wired.network
> @@ -1,5 +1,6 @@
> [Match]
> Type=ether
> +Name=!veth*
> KernelCommandLine=!nfsroot
> KernelCommandLine=!ip
>
> --
> 2.25.1
>
>
>
>
--
- Thou shalt not follow the NULL pointer, for chaos and madness await
thee at its end
- "Use the force Harry" - Gandalf, Star Trek II
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces
2021-06-15 10:02 [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces Ross Burton
2021-06-15 12:28 ` [OE-core] " Bruce Ashfield
@ 2021-06-15 17:57 ` Khem Raj
1 sibling, 0 replies; 4+ messages in thread
From: Khem Raj @ 2021-06-15 17:57 UTC (permalink / raw)
To: Ross Burton, openembedded-core
On 6/15/21 3:02 AM, Ross Burton wrote:
> From: Matt Spencer <matt.spencer@arm.com>
>
> We need to prevent systemd-network from managing veth interface when
> using platforms like k3s as they control creation and management of the
> interfaces.
perhaps it may be an option to override wired.network or use a fragment
to drop-in just this change via own layer
>
> Signed-off-by: Matt Spencer <matt.spencer@arm.com>
> Signed-off-by: Ross Burton <ross.burton@arm.com>
> ---
> meta/recipes-core/systemd/systemd-conf/wired.network | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/meta/recipes-core/systemd/systemd-conf/wired.network b/meta/recipes-core/systemd/systemd-conf/wired.network
> index e7b69970d6..7406287248 100644
> --- a/meta/recipes-core/systemd/systemd-conf/wired.network
> +++ b/meta/recipes-core/systemd/systemd-conf/wired.network
> @@ -1,5 +1,6 @@
> [Match]
> Type=ether
> +Name=!veth*
> KernelCommandLine=!nfsroot
> KernelCommandLine=!ip
>
>
>
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [OE-core] [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces
2021-06-15 12:28 ` [OE-core] " Bruce Ashfield
@ 2021-06-15 18:35 ` Scott Murray
0 siblings, 0 replies; 4+ messages in thread
From: Scott Murray @ 2021-06-15 18:35 UTC (permalink / raw)
To: Bruce Ashfield
Cc: Ross Burton, Patches and discussions about the oe-core layer
On Tue, 15 Jun 2021, Bruce Ashfield wrote:
> On Tue, Jun 15, 2021 at 6:02 AM Ross Burton <ross@burtonini.com> wrote:
> >
> > From: Matt Spencer <matt.spencer@arm.com>
> >
> > We need to prevent systemd-network from managing veth interface when
> > using platforms like k3s as they control creation and management of the
> > interfaces.
>
> FWIW, I think this may surprise/break people in other use cases. I had
> mentioned this to matt directly as well.
>
> The situation is not as clear as that commit message implies. networkd
> *can* cause issues with veth devices, but not always.
>
> Not trying to stop the patch, but I wanted my concerns to be archived :D
I second this concern, a default config change like this might bite
systemd-nspawn users, as it has its own options to set up private
networking with veth interfaces. Maybe adding a drop-in conf file
to do this when k3s or the like is installed would be better?
Scott
> >
> > Signed-off-by: Matt Spencer <matt.spencer@arm.com>
> > Signed-off-by: Ross Burton <ross.burton@arm.com>
> > ---
> > meta/recipes-core/systemd/systemd-conf/wired.network | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/meta/recipes-core/systemd/systemd-conf/wired.network b/meta/recipes-core/systemd/systemd-conf/wired.network
> > index e7b69970d6..7406287248 100644
> > --- a/meta/recipes-core/systemd/systemd-conf/wired.network
> > +++ b/meta/recipes-core/systemd/systemd-conf/wired.network
> > @@ -1,5 +1,6 @@
> > [Match]
> > Type=ether
> > +Name=!veth*
> > KernelCommandLine=!nfsroot
> > KernelCommandLine=!ip
> >
> > --
> > 2.25.1
> >
> >
> >
> >
>
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-06-15 18:35 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-15 10:02 [PATCH] systemd-conf: Prevent systemd-network from managing veth interfaces Ross Burton
2021-06-15 12:28 ` [OE-core] " Bruce Ashfield
2021-06-15 18:35 ` Scott Murray
2021-06-15 17:57 ` Khem Raj
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.