All of lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, vkoul@kernel.org
Cc: yung-chuan.liao@linux.intel.com, sanyog.r.kale@intel.com,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 8/9] soundwire: qcom: add auto enumeration support
Date: Mon, 8 Mar 2021 09:56:35 -0600	[thread overview]
Message-ID: <ab00438b-dbb9-e6c6-019a-d50494e5dee1@linux.intel.com> (raw)
In-Reply-To: <20210308134957.16024-9-srinivas.kandagatla@linaro.org>


> +static int qcom_swrm_enumerate(struct sdw_bus *bus)
> +{
> +	struct qcom_swrm_ctrl *ctrl = to_qcom_sdw(bus);
> +	struct sdw_slave *slave, *_s;
> +	struct sdw_slave_id id;
> +	u32 val1, val2;
> +	bool found;
> +	u64 addr;
> +	int i;
> +	char *buf1 = (char *)&val1, *buf2 = (char *)&val2;
> +
> +	for (i = 1; i <= SDW_MAX_DEVICES; i++) {
> +		/*SCP_Devid5 - Devid 4*/
> +		ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_1(i), &val1);
> +
> +		/*SCP_Devid3 - DevId 2 Devid 1 Devid 0*/
> +		ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_2(i), &val2);
> +
> +		if (!val1 && !val2)
> +			break;
> +
> +		addr = buf2[1] | (buf2[0] << 8) | (buf1[3] << 16) |
> +			((u64)buf1[2] << 24) | ((u64)buf1[1] << 32) |
> +			((u64)buf1[0] << 40);
> +
> +		sdw_extract_slave_id(bus, addr, &id);
> +		found = false;
> +		/* Now compare with entries */
> +		list_for_each_entry_safe(slave, _s, &bus->slaves, node) {
> +			if (sdw_compare_devid(slave, id) == 0) {
> +				u32 status = qcom_swrm_get_n_device_status(ctrl, i);
> +
> +				found = true;
> +				if (status == SDW_SLAVE_ATTACHED) {
> +					slave->dev_num = i;
> +					mutex_lock(&bus->bus_lock);
> +					set_bit(i, bus->assigned);
> +					mutex_unlock(&bus->bus_lock);
> +
> +				}

you haven't changed that part, if the device is not in DT we should 
still set bus->assigned::i


WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, vkoul@kernel.org
Cc: sanyog.r.kale@intel.com, yung-chuan.liao@linux.intel.com,
	linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org
Subject: Re: [PATCH v3 8/9] soundwire: qcom: add auto enumeration support
Date: Mon, 8 Mar 2021 09:56:35 -0600	[thread overview]
Message-ID: <ab00438b-dbb9-e6c6-019a-d50494e5dee1@linux.intel.com> (raw)
In-Reply-To: <20210308134957.16024-9-srinivas.kandagatla@linaro.org>


> +static int qcom_swrm_enumerate(struct sdw_bus *bus)
> +{
> +	struct qcom_swrm_ctrl *ctrl = to_qcom_sdw(bus);
> +	struct sdw_slave *slave, *_s;
> +	struct sdw_slave_id id;
> +	u32 val1, val2;
> +	bool found;
> +	u64 addr;
> +	int i;
> +	char *buf1 = (char *)&val1, *buf2 = (char *)&val2;
> +
> +	for (i = 1; i <= SDW_MAX_DEVICES; i++) {
> +		/*SCP_Devid5 - Devid 4*/
> +		ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_1(i), &val1);
> +
> +		/*SCP_Devid3 - DevId 2 Devid 1 Devid 0*/
> +		ctrl->reg_read(ctrl, SWRM_ENUMERATOR_SLAVE_DEV_ID_2(i), &val2);
> +
> +		if (!val1 && !val2)
> +			break;
> +
> +		addr = buf2[1] | (buf2[0] << 8) | (buf1[3] << 16) |
> +			((u64)buf1[2] << 24) | ((u64)buf1[1] << 32) |
> +			((u64)buf1[0] << 40);
> +
> +		sdw_extract_slave_id(bus, addr, &id);
> +		found = false;
> +		/* Now compare with entries */
> +		list_for_each_entry_safe(slave, _s, &bus->slaves, node) {
> +			if (sdw_compare_devid(slave, id) == 0) {
> +				u32 status = qcom_swrm_get_n_device_status(ctrl, i);
> +
> +				found = true;
> +				if (status == SDW_SLAVE_ATTACHED) {
> +					slave->dev_num = i;
> +					mutex_lock(&bus->bus_lock);
> +					set_bit(i, bus->assigned);
> +					mutex_unlock(&bus->bus_lock);
> +
> +				}

you haven't changed that part, if the device is not in DT we should 
still set bus->assigned::i


  reply	other threads:[~2021-03-08 16:09 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-03-08 13:49 [PATCH v3 0/9] soundwire: qcom: various improvements Srinivas Kandagatla
2021-03-08 13:49 ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 1/9] dt-bindings: soundwire: qcom: clarify data port bus parameters Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 2/9] soundwire: qcom: add support to missing transport params Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 3/9] soundwire: qcom: set continue execution flag for ignored commands Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 4/9] soundwire: qcom: start the clock during initialization Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 5/9] soundwire: qcom: update register read/write routine Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 6/9] soundwire: qcom: add support to new interrupts Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 7/9] soundwire: export sdw_compare_devid() and sdw_extract_slave_id() Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 8/9] soundwire: qcom: add auto enumeration support Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla
2021-03-08 15:56   ` Pierre-Louis Bossart [this message]
2021-03-08 15:56     ` Pierre-Louis Bossart
2021-03-08 16:16     ` Srinivas Kandagatla
2021-03-08 16:16       ` Srinivas Kandagatla
2021-03-08 13:49 ` [PATCH v3 9/9] soundwire: qcom: wait for enumeration to be complete in probe Srinivas Kandagatla
2021-03-08 13:49   ` Srinivas Kandagatla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ab00438b-dbb9-e6c6-019a-d50494e5dee1@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sanyog.r.kale@intel.com \
    --cc=srinivas.kandagatla@linaro.org \
    --cc=vkoul@kernel.org \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.