[PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[California Sullivan]

Kernel v4.14 and newer contain the following in their Makefile:

HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)

This breaks our menuconfig, because it can no longer find ncurses if its
not on the host machine. This can be seen in linux-yocto-dev, for
example:

[clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig

  GEN     ./Makefile
  HOSTLD  scripts/kconfig/mconf
/home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
/home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
collect2: error: ld returned 1 exit status
make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
make[2]: *** [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: menuconfig] Error 2
make[1]: *** [Makefile:146: sub-make] Error 2
make: *** [Makefile:24: __sub-make] Error 2
Command failed.
Press any key to continue...

Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
'make menuconfig' command.

Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
---
 meta/classes/kernel.bbclass | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
index 2f6eca382e9..e4df1531c19 100644
--- a/meta/classes/kernel.bbclass
+++ b/meta/classes/kernel.bbclass
@@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
 
 inherit cml1
 
+KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
+
 EXPORT_FUNCTIONS do_compile do_install do_configure
 
 # kernel-base becomes kernel-${KERNEL_VERSION}
-- 
2.14.3

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Bruce Ashfield]

On 01/24/2018 10:12 PM, California Sullivan wrote:
> Kernel v4.14 and newer contain the following in their Makefile:
> 
> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
> 
> This breaks our menuconfig, because it can no longer find ncurses if its
> not on the host machine. This can be seen in linux-yocto-dev, for
> example:
> 
> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
> 
>    GEN     ./Makefile
>    HOSTLD  scripts/kconfig/mconf
> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
> collect2: error: ld returned 1 exit status
> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
> make[2]: *** [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: menuconfig] Error 2
> make[1]: *** [Makefile:146: sub-make] Error 2
> make: *** [Makefile:24: __sub-make] Error 2
> Command failed.
> Press any key to continue...

Does this fix still require a kernel patch ? I was trying to test
it out here, and may have messed up the steps.

If I remove ncurses-dev from my builder, I'm not able to get a
working menuconfig no matter what combination of this patch
applied (or not) or my menuconfig patch applied (or not).

I can say that having this applied didn't break my menuconfig,
but I wasn't able to fully test.

Should I expect a builder without ncurses-dev + just this patch
to be able to run menuconfig ?

Bruce

> 
> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
> 'make menuconfig' command.
> 
> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
> ---
>   meta/classes/kernel.bbclass | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 2f6eca382e9..e4df1531c19 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>   
>   inherit cml1
>   
> +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
> +
>   EXPORT_FUNCTIONS do_compile do_install do_configure
>   
>   # kernel-base becomes kernel-${KERNEL_VERSION}
> 

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

On 01/25/2018 06:21 AM, Bruce Ashfield wrote:
> On 01/24/2018 10:12 PM, California Sullivan wrote:
>> Kernel v4.14 and newer contain the following in their Makefile:
>>
>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>
>> This breaks our menuconfig, because it can no longer find ncurses if its
>> not on the host machine. This can be seen in linux-yocto-dev, for
>> example:
>>
>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>
>>    GEN     ./Makefile
>>    HOSTLD  scripts/kconfig/mconf
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>> collect2: error: ld returned 1 exit status
>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>> make[2]: *** 
>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>> menuconfig] Error 2
>> make[1]: *** [Makefile:146: sub-make] Error 2
>> make: *** [Makefile:24: __sub-make] Error 2
>> Command failed.
>> Press any key to continue...
>
> Does this fix still require a kernel patch ? I was trying to test
> it out here, and may have messed up the steps.
>
> If I remove ncurses-dev from my builder, I'm not able to get a
> working menuconfig no matter what combination of this patch
> applied (or not) or my menuconfig patch applied (or not).
>
> I can say that having this applied didn't break my menuconfig,
> but I wasn't able to fully test.
>
> Should I expect a builder without ncurses-dev + just this patch
> to be able to run menuconfig ?
We still need the patch "menuconfig,check-lxdiaglog.sh: Allow 
specification of ncurses location", as seen here: 
https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-dev/commit/?h=standard/base&id=26911f4ada6374ff3f0b7f98364b7a93756a180b

Two separate fixes in the same area unfortunately.

Locally I am doing 'bitbake linux-yocto-dev -c menuconfig' and I am 
getting a working menuconfig with my patch, and no ncurses-dev(el) 
installed on my host machine. If you're not, I worry that there might be 
more host contamination that we haven't discovered.

Could you share the errors you're hitting?

Thanks,
Cal

>
> Bruce
>
>>
>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>> 'make menuconfig' command.
>>
>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 2f6eca382e9..e4df1531c19 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>     inherit cml1
>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>> +
>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>
>

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Bruce Ashfield]

On 2018-01-25 3:26 PM, Cal Sullivan wrote:
> 
> 
> On 01/25/2018 06:21 AM, Bruce Ashfield wrote:
>> On 01/24/2018 10:12 PM, California Sullivan wrote:
>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>
>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>
>>> This breaks our menuconfig, because it can no longer find ncurses if its
>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>> example:
>>>
>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>
>>>    GEN     ./Makefile
>>>    HOSTLD  scripts/kconfig/mconf
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>> collect2: error: ld returned 1 exit status
>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>> make[2]: *** 
>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>>> menuconfig] Error 2
>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>> make: *** [Makefile:24: __sub-make] Error 2
>>> Command failed.
>>> Press any key to continue...
>>
>> Does this fix still require a kernel patch ? I was trying to test
>> it out here, and may have messed up the steps.
>>
>> If I remove ncurses-dev from my builder, I'm not able to get a
>> working menuconfig no matter what combination of this patch
>> applied (or not) or my menuconfig patch applied (or not).
>>
>> I can say that having this applied didn't break my menuconfig,
>> but I wasn't able to fully test.
>>
>> Should I expect a builder without ncurses-dev + just this patch
>> to be able to run menuconfig ?
> We still need the patch "menuconfig,check-lxdiaglog.sh: Allow 
> specification of ncurses location", as seen here: 
> https://git.yoctoproject.org/cgit/cgit.cgi/linux-yocto-dev/commit/?h=standard/base&id=26911f4ada6374ff3f0b7f98364b7a93756a180b 
> 
> 
> Two separate fixes in the same area unfortunately.
> 
> Locally I am doing 'bitbake linux-yocto-dev -c menuconfig' and I am 
> getting a working menuconfig with my patch, and no ncurses-dev(el) 
> installed on my host machine. If you're not, I worry that there might be 
> more host contamination that we haven't discovered.
> 
> Could you share the errors you're hitting?

I retested this morning, since I was doing a lot of different things
yesterday .. and I wanted to be sure that I had things right.

During my new tests, I can get menuconfig to launch with ncurses-dev
removed on my builder, if I have your patch + the one I carry in
linux-yocto.

It was my revert of the kernel patch that was getting me into the
"never able to build menuconfig" loop.

So no issues with this change, it doesn't break anything and definitely
lets me launch menuconfig when ncurses-dev isn't present on the builder.

I'll resend that kernel patch upstream.

Bruce

> 
> Thanks,
> Cal
> 
>>
>> Bruce
>>
>>>
>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>> 'make menuconfig' command.
>>>
>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>> ---
>>>   meta/classes/kernel.bbclass | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index 2f6eca382e9..e4df1531c19 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>     inherit cml1
>>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>>> +
>>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>>
>>
> 

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

Ping. This is still an issue and it looks like this patch fell through 
the cracks!

Thanks,
Cal

On 01/24/2018 07:12 PM, California Sullivan wrote:
> Kernel v4.14 and newer contain the following in their Makefile:
>
> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>
> This breaks our menuconfig, because it can no longer find ncurses if its
> not on the host machine. This can be seen in linux-yocto-dev, for
> example:
>
> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>
>    GEN     ./Makefile
>    HOSTLD  scripts/kconfig/mconf
> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
> collect2: error: ld returned 1 exit status
> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
> make[2]: *** [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: menuconfig] Error 2
> make[1]: *** [Makefile:146: sub-make] Error 2
> make: *** [Makefile:24: __sub-make] Error 2
> Command failed.
> Press any key to continue...
>
> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
> 'make menuconfig' command.
>
> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
> ---
>   meta/classes/kernel.bbclass | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
> index 2f6eca382e9..e4df1531c19 100644
> --- a/meta/classes/kernel.bbclass
> +++ b/meta/classes/kernel.bbclass
> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>   
>   inherit cml1
>   
> +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
> +
>   EXPORT_FUNCTIONS do_compile do_install do_configure
>   
>   # kernel-base becomes kernel-${KERNEL_VERSION}

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

Woops, +Ross to CC.

---
Cal

On 03/15/2018 12:42 PM, Cal Sullivan wrote:
> Ping. This is still an issue and it looks like this patch fell through 
> the cracks!
>
> Thanks,
> Cal
>
> On 01/24/2018 07:12 PM, California Sullivan wrote:
>> Kernel v4.14 and newer contain the following in their Makefile:
>>
>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>
>> This breaks our menuconfig, because it can no longer find ncurses if its
>> not on the host machine. This can be seen in linux-yocto-dev, for
>> example:
>>
>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>
>>    GEN     ./Makefile
>>    HOSTLD  scripts/kconfig/mconf
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>> collect2: error: ld returned 1 exit status
>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>> make[2]: *** 
>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>> menuconfig] Error 2
>> make[1]: *** [Makefile:146: sub-make] Error 2
>> make: *** [Makefile:24: __sub-make] Error 2
>> Command failed.
>> Press any key to continue...
>>
>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>> 'make menuconfig' command.
>>
>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 2f6eca382e9..e4df1531c19 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>     inherit cml1
>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>> +
>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Randy MacLeod]

On 2018-03-15 03:53 PM, Cal Sullivan wrote:
> Woops, +Ross to CC.
Maybe you used BCC? Anyway +Ross to CC for reals now. :)
../Randy
> 
> ---
> Cal
> 
> On 03/15/2018 12:42 PM, Cal Sullivan wrote:
>> Ping. This is still an issue and it looks like this patch fell through 
>> the cracks!
>>
>> Thanks,
>> Cal
>>
>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>
>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>
>>> This breaks our menuconfig, because it can no longer find ncurses if its
>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>> example:
>>>
>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>
>>>    GEN     ./Makefile
>>>    HOSTLD  scripts/kconfig/mconf
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>> collect2: error: ld returned 1 exit status
>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>> make[2]: *** 
>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>>> menuconfig] Error 2
>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>> make: *** [Makefile:24: __sub-make] Error 2
>>> Command failed.
>>> Press any key to continue...
>>>
>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>> 'make menuconfig' command.
>>>
>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>> ---
>>>   meta/classes/kernel.bbclass | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index 2f6eca382e9..e4df1531c19 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>     inherit cml1
>>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>>> +
>>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>
> 


-- 
# Randy MacLeod.  WR Linux
# Wind River an Intel Company

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

Yeah I'm confused. My outbox says Ross is CC'd, my inbox does not. My 
mail client is borked somehow.

---
Cal

On 03/15/2018 01:30 PM, Randy MacLeod wrote:
> On 2018-03-15 03:53 PM, Cal Sullivan wrote:
>> Woops, +Ross to CC.
> Maybe you used BCC? Anyway +Ross to CC for reals now. :)
> ../Randy
>>
>> ---
>> Cal
>>
>> On 03/15/2018 12:42 PM, Cal Sullivan wrote:
>>> Ping. This is still an issue and it looks like this patch fell 
>>> through the cracks!
>>>
>>> Thanks,
>>> Cal
>>>
>>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>>
>>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>>
>>>> This breaks our menuconfig, because it can no longer find ncurses 
>>>> if its
>>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>>> example:
>>>>
>>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>>
>>>>    GEN     ./Makefile
>>>>    HOSTLD  scripts/kconfig/mconf
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find 
>>>> -lncurses
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>>> collect2: error: ld returned 1 exit status
>>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>>> make[2]: *** 
>>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>>>> menuconfig] Error 2
>>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>>> make: *** [Makefile:24: __sub-make] Error 2
>>>> Command failed.
>>>> Press any key to continue...
>>>>
>>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>>> 'make menuconfig' command.
>>>>
>>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>>> ---
>>>>   meta/classes/kernel.bbclass | 2 ++
>>>>   1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index 2f6eca382e9..e4df1531c19 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>>     inherit cml1
>>>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>>>> +
>>>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>>
>>
>
>

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Paul Eggleton]

Actually it's an artifact of how mailman works, it excludes CC on the mail to 
the list - I'm not sure whether were it to include it that the message would 
end up being CC'd both from the act of you sending the message and the mailing 
list also sending its copy, but as far as I have observed it has always 
behaved this way. It's possible that the "avoid duplicate messages" user 
preference setting has an effect, not sure.

Cheers,
Paul

On Friday, 16 March 2018 4:47:14 AM +08 Cal Sullivan wrote:
> Yeah I'm confused. My outbox says Ross is CC'd, my inbox does not. My 
> mail client is borked somehow.
> 
> ---
> Cal
> 
> On 03/15/2018 01:30 PM, Randy MacLeod wrote:
> > On 2018-03-15 03:53 PM, Cal Sullivan wrote:
> >> Woops, +Ross to CC.
> > Maybe you used BCC? Anyway +Ross to CC for reals now. :)
> > ../Randy

-- 

Paul Eggleton
Intel Open Source Technology Centre

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Burton, Ross]

[-- Attachment #1: Type: text/plain, Size: 2068 bytes --]

Picked to mut, thanks Cal

Ross

On 15 March 2018 at 19:42, Cal Sullivan <california.l.sullivan@intel.com>
wrote:

> Ping. This is still an issue and it looks like this patch fell through the
> cracks!
>
> Thanks,
> Cal
>
>
> On 01/24/2018 07:12 PM, California Sullivan wrote:
>
>> Kernel v4.14 and newer contain the following in their Makefile:
>>
>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>
>> This breaks our menuconfig, because it can no longer find ncurses if its
>> not on the host machine. This can be seen in linux-yocto-dev, for
>> example:
>>
>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>
>>    GEN     ./Makefile
>>    HOSTLD  scripts/kconfig/mconf
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>> collect2: error: ld returned 1 exit status
>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>> make[2]: *** [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei
>> 7-64/kernel-source/Makefile:504: menuconfig] Error 2
>> make[1]: *** [Makefile:146: sub-make] Error 2
>> make: *** [Makefile:24: __sub-make] Error 2
>> Command failed.
>> Press any key to continue...
>>
>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>> 'make menuconfig' command.
>>
>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>> ---
>>   meta/classes/kernel.bbclass | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>> index 2f6eca382e9..e4df1531c19 100644
>> --- a/meta/classes/kernel.bbclass
>> +++ b/meta/classes/kernel.bbclass
>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>     inherit cml1
>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>> +
>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>
>
>

[-- Attachment #2: Type: text/html, Size: 2755 bytes --]

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Andre McCurdy]

On Fri, Mar 16, 2018 at 3:13 AM, Burton, Ross <ross.burton@intel.com> wrote:
> Picked to mut, thanks Cal
>
> Ross
>
> On 15 March 2018 at 19:42, Cal Sullivan <california.l.sullivan@intel.com>
> wrote:
>>
>> Ping. This is still an issue and it looks like this patch fell through the
>> cracks!
>>
>> Thanks,
>> Cal
>>
>>
>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>>
>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>
>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>
>>> This breaks our menuconfig, because it can no longer find ncurses if its
>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>> example:
>>>
>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>
>>>    GEN     ./Makefile
>>>    HOSTLD  scripts/kconfig/mconf
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>> collect2: error: ld returned 1 exit status
>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>> make[2]: ***
>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504:
>>> menuconfig] Error 2
>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>> make: *** [Makefile:24: __sub-make] Error 2
>>> Command failed.
>>> Press any key to continue...
>>>
>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>> 'make menuconfig' command.
>>>
>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>> ---
>>>   meta/classes/kernel.bbclass | 2 ++
>>>   1 file changed, 2 insertions(+)
>>>
>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>> index 2f6eca382e9..e4df1531c19 100644
>>> --- a/meta/classes/kernel.bbclass
>>> +++ b/meta/classes/kernel.bbclass
>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>     inherit cml1
>>>   +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"

What's the reasoning behind appending to KCONFIG_CONFIG_COMMAND from
kernel.bbclass rather than appending from inside cml1.bbclass (the
only place KCONFIG_CONFIG_COMMAND is used) or simply updating the
default value of KCONFIG_CONFIG_COMMAND?

>>> +
>>>   EXPORT_FUNCTIONS do_compile do_install do_configure
>>>     # kernel-base becomes kernel-${KERNEL_VERSION}
>>
>>
>
>
> --
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

On 03/16/2018 11:38 AM, Andre McCurdy wrote:
> On Fri, Mar 16, 2018 at 3:13 AM, Burton, Ross <ross.burton@intel.com> wrote:
>> Picked to mut, thanks Cal
>>
>> Ross
>>
>> On 15 March 2018 at 19:42, Cal Sullivan <california.l.sullivan@intel.com>
>> wrote:
>>> Ping. This is still an issue and it looks like this patch fell through the
>>> cracks!
>>>
>>> Thanks,
>>> Cal
>>>
>>>
>>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>>
>>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>>
>>>> This breaks our menuconfig, because it can no longer find ncurses if its
>>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>>> example:
>>>>
>>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>>
>>>>     GEN     ./Makefile
>>>>     HOSTLD  scripts/kconfig/mconf
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -lncurses
>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>>> collect2: error: ld returned 1 exit status
>>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] Error 1
>>>> make[2]: ***
>>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504:
>>>> menuconfig] Error 2
>>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>>> make: *** [Makefile:24: __sub-make] Error 2
>>>> Command failed.
>>>> Press any key to continue...
>>>>
>>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>>> 'make menuconfig' command.
>>>>
>>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>>> ---
>>>>    meta/classes/kernel.bbclass | 2 ++
>>>>    1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/meta/classes/kernel.bbclass b/meta/classes/kernel.bbclass
>>>> index 2f6eca382e9..e4df1531c19 100644
>>>> --- a/meta/classes/kernel.bbclass
>>>> +++ b/meta/classes/kernel.bbclass
>>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>>      inherit cml1
>>>>    +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
> What's the reasoning behind appending to KCONFIG_CONFIG_COMMAND from
> kernel.bbclass rather than appending from inside cml1.bbclass (the
> only place KCONFIG_CONFIG_COMMAND is used) or simply updating the
> default value of KCONFIG_CONFIG_COMMAND?
cml1.bbclass is also used by busybox and I don't know what sort of 
effect this may have on it.

Thanks,
Cal
>
>>>> +
>>>>    EXPORT_FUNCTIONS do_compile do_install do_configure
>>>>      # kernel-base becomes kernel-${KERNEL_VERSION}
>>>
>>
>> --
>> _______________________________________________
>> Openembedded-core mailing list
>> Openembedded-core@lists.openembedded.org
>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>

Re: [PATCH] kernel.bbclass: set HOSTLDFLAGS in KCONFIG_CONFIG_COMMAND

[Cal Sullivan]

On 03/16/2018 11:41 AM, Cal Sullivan wrote:
>
>
> On 03/16/2018 11:38 AM, Andre McCurdy wrote:
>> On Fri, Mar 16, 2018 at 3:13 AM, Burton, Ross <ross.burton@intel.com> 
>> wrote:
>>> Picked to mut, thanks Cal
>>>
>>> Ross
>>>
>>> On 15 March 2018 at 19:42, Cal Sullivan 
>>> <california.l.sullivan@intel.com>
>>> wrote:
>>>> Ping. This is still an issue and it looks like this patch fell 
>>>> through the
>>>> cracks!
>>>>
>>>> Thanks,
>>>> Cal
>>>>
>>>>
>>>> On 01/24/2018 07:12 PM, California Sullivan wrote:
>>>>> Kernel v4.14 and newer contain the following in their Makefile:
>>>>>
>>>>> HOST_LFS_LDFLAGS := $(shell getconf LFS_LDFLAGS)
>>>>> HOSTLDFLAGS  := $(HOST_LFS_LDFLAGS)
>>>>>
>>>>> This breaks our menuconfig, because it can no longer find ncurses 
>>>>> if its
>>>>> not on the host machine. This can be seen in linux-yocto-dev, for
>>>>> example:
>>>>>
>>>>> [clsulliv@clsulliv build]$ bitbake virtual/kernel -c menuconfig
>>>>>
>>>>>     GEN     ./Makefile
>>>>>     HOSTLD  scripts/kconfig/mconf
>>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find 
>>>>> -lncurses
>>>>> /home/clsulliv/yocto/poky/build/tmp/hosttools/ld: cannot find -ltinfo
>>>>> collect2: error: ld returned 1 exit status
>>>>> make[3]: *** [scripts/Makefile.host:99: scripts/kconfig/mconf] 
>>>>> Error 1
>>>>> make[2]: ***
>>>>> [/home/clsulliv/yocto/poky/build/tmp/work-shared/intel-corei7-64/kernel-source/Makefile:504: 
>>>>>
>>>>> menuconfig] Error 2
>>>>> make[1]: *** [Makefile:146: sub-make] Error 2
>>>>> make: *** [Makefile:24: __sub-make] Error 2
>>>>> Command failed.
>>>>> Press any key to continue...
>>>>>
>>>>> Fix this by setting HOSTLDFLAGS to ${BUILD_LDFLAGS} in our
>>>>> 'make menuconfig' command.
>>>>>
>>>>> Signed-off-by: California Sullivan <california.l.sullivan@intel.com>
>>>>> ---
>>>>>    meta/classes/kernel.bbclass | 2 ++
>>>>>    1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/meta/classes/kernel.bbclass 
>>>>> b/meta/classes/kernel.bbclass
>>>>> index 2f6eca382e9..e4df1531c19 100644
>>>>> --- a/meta/classes/kernel.bbclass
>>>>> +++ b/meta/classes/kernel.bbclass
>>>>> @@ -531,6 +531,8 @@ addtask savedefconfig after do_configure
>>>>>      inherit cml1
>>>>>    +KCONFIG_CONFIG_COMMAND_append = " HOSTLDFLAGS='${BUILD_LDFLAGS}'"
>> What's the reasoning behind appending to KCONFIG_CONFIG_COMMAND from
>> kernel.bbclass rather than appending from inside cml1.bbclass (the
>> only place KCONFIG_CONFIG_COMMAND is used) or simply updating the
>> default value of KCONFIG_CONFIG_COMMAND?
> cml1.bbclass is also used by busybox and I don't know what sort of 
> effect this may have on it.
>
Eh, it took like five second to test, and it doesn't break busybox's 
menuconfig. You're probably right that I should just change the default.

> Thanks,
> Cal
>>
>>>>> +
>>>>>    EXPORT_FUNCTIONS do_compile do_install do_configure
>>>>>      # kernel-base becomes kernel-${KERNEL_VERSION}
>>>>
>>>
>>> -- 
>>> _______________________________________________
>>> Openembedded-core mailing list
>>> Openembedded-core@lists.openembedded.org
>>> http://lists.openembedded.org/mailman/listinfo/openembedded-core
>>>
>