* [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality
@ 2016-09-10 2:20 Marcel Ziswiler
2016-09-10 16:33 ` Joe Hershberger
2016-09-10 16:51 ` Marek Vasut
0 siblings, 2 replies; 5+ messages in thread
From: Marcel Ziswiler @ 2016-09-10 2:20 UTC (permalink / raw)
To: u-boot
Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
("net: Stop including NFS overhead in defragment max") the following
has been reproducibly observed while trying to transfer data over TFTP:
Load address: 0x80408000
Loading: EHCI timed out on TD - token=0x8008d80
T EHCI timed out on TD - token=0x88008d80
Rx: failed to receive: -5
This patch fixes this by upping our maximal de-fragmentation aka IP
packet size again.
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
---
include/configs/colibri_t30.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h
index fbb235d..3431cde 100644
--- a/include/configs/colibri_t30.h
+++ b/include/configs/colibri_t30.h
@@ -48,6 +48,7 @@
/* General networking support */
#define CONFIG_IP_DEFRAG
+#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
#define CONFIG_TFTP_BLOCKSIZE 16384
#define CONFIG_TFTP_TSIZE
--
2.5.5
^ permalink raw reply related [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality
2016-09-10 2:20 [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality Marcel Ziswiler
@ 2016-09-10 16:33 ` Joe Hershberger
2016-09-10 16:51 ` Marek Vasut
1 sibling, 0 replies; 5+ messages in thread
From: Joe Hershberger @ 2016-09-10 16:33 UTC (permalink / raw)
To: u-boot
Hi Marcel,
On Fri, Sep 9, 2016 at 9:20 PM, Marcel Ziswiler
<marcel.ziswiler@toradex.com> wrote:
> Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
> ("net: Stop including NFS overhead in defragment max") the following
> has been reproducibly observed while trying to transfer data over TFTP:
>
> Load address: 0x80408000
> Loading: EHCI timed out on TD - token=0x8008d80
> T EHCI timed out on TD - token=0x88008d80
> Rx: failed to receive: -5
>
> This patch fixes this by upping our maximal de-fragmentation aka IP
> packet size again.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> include/configs/colibri_t30.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h
> index fbb235d..3431cde 100644
> --- a/include/configs/colibri_t30.h
> +++ b/include/configs/colibri_t30.h
> @@ -48,6 +48,7 @@
>
> /* General networking support */
> #define CONFIG_IP_DEFRAG
> +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
I suspect this is more than you need, right? You are using TFTP, not
NFS. You probably only need an extra 34 bytes.
> #define CONFIG_TFTP_BLOCKSIZE 16384
You could also just reduce this by 34 bytes.
> #define CONFIG_TFTP_TSIZE
>
> --
> 2.5.5
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality
2016-09-10 2:20 [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality Marcel Ziswiler
2016-09-10 16:33 ` Joe Hershberger
@ 2016-09-10 16:51 ` Marek Vasut
2016-09-14 14:36 ` Marcel Ziswiler
1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2016-09-10 16:51 UTC (permalink / raw)
To: u-boot
On 09/10/2016 04:20 AM, Marcel Ziswiler wrote:
> Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
> ("net: Stop including NFS overhead in defragment max") the following
> has been reproducibly observed while trying to transfer data over TFTP:
>
> Load address: 0x80408000
> Loading: EHCI timed out on TD - token=0x8008d80
> T EHCI timed out on TD - token=0x88008d80
> Rx: failed to receive: -5
>
> This patch fixes this by upping our maximal de-fragmentation aka IP
> packet size again.
>
> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>
> ---
>
> include/configs/colibri_t30.h | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/include/configs/colibri_t30.h b/include/configs/colibri_t30.h
> index fbb235d..3431cde 100644
> --- a/include/configs/colibri_t30.h
> +++ b/include/configs/colibri_t30.h
> @@ -48,6 +48,7 @@
>
> /* General networking support */
> #define CONFIG_IP_DEFRAG
> +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
> #define CONFIG_TFTP_BLOCKSIZE 16384
> #define CONFIG_TFTP_TSIZE
>
>
Applied, thanks . If you need to rectify this further based on Joe's
feedback, please do, but I want this fixed before the release.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality
2016-09-10 16:51 ` Marek Vasut
@ 2016-09-14 14:36 ` Marcel Ziswiler
2016-09-14 15:18 ` Marek Vasut
0 siblings, 1 reply; 5+ messages in thread
From: Marcel Ziswiler @ 2016-09-14 14:36 UTC (permalink / raw)
To: u-boot
On Sat, 2016-09-10 at 18:51 +0200, Marek Vasut wrote:
> On 09/10/2016 04:20 AM, Marcel Ziswiler wrote:
> >
> > Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
> > ("net: Stop including NFS overhead in defragment max") the
> > following
> > has been reproducibly observed while trying to transfer data over
> > TFTP:
> >
> > Load address: 0x80408000
> > Loading: EHCI timed out on TD - token=0x8008d80
> > T EHCI timed out on TD - token=0x88008d80
> > Rx: failed to receive: -5
> >
> > This patch fixes this by upping our maximal de-fragmentation aka IP
> > packet size again.
> >
> > Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
> >
> > ---
> >
> > ?include/configs/colibri_t30.h | 1 +
> > ?1 file changed, 1 insertion(+)
> >
> > diff --git a/include/configs/colibri_t30.h
> > b/include/configs/colibri_t30.h
> > index fbb235d..3431cde 100644
> > --- a/include/configs/colibri_t30.h
> > +++ b/include/configs/colibri_t30.h
> > @@ -48,6 +48,7 @@
> > ?
> > ?/* General networking support */
> > ?#define CONFIG_IP_DEFRAG
> > +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
> > ?#define CONFIG_TFTP_BLOCKSIZE 16384
> > ?#define CONFIG_TFTP_TSIZE
> > ?
> >
> Applied, thanks . If you need to rectify this further based on Joe's
> feedback, please do, but I want this fixed before the release.
Unfortunately the release already happened. Nevertheless I will send an
updated version 2 ASAP which fixes all of our boards currently
exhibiting this issue the way Joe suggested.
^ permalink raw reply [flat|nested] 5+ messages in thread* [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality
2016-09-14 14:36 ` Marcel Ziswiler
@ 2016-09-14 15:18 ` Marek Vasut
0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2016-09-14 15:18 UTC (permalink / raw)
To: u-boot
On 09/14/2016 04:36 PM, Marcel Ziswiler wrote:
> On Sat, 2016-09-10 at 18:51 +0200, Marek Vasut wrote:
>> On 09/10/2016 04:20 AM, Marcel Ziswiler wrote:
>>>
>>> Since commit aa7a648747d8c704a9a81c9e493d386930724e9d
>>> ("net: Stop including NFS overhead in defragment max") the
>>> following
>>> has been reproducibly observed while trying to transfer data over
>>> TFTP:
>>>
>>> Load address: 0x80408000
>>> Loading: EHCI timed out on TD - token=0x8008d80
>>> T EHCI timed out on TD - token=0x88008d80
>>> Rx: failed to receive: -5
>>>
>>> This patch fixes this by upping our maximal de-fragmentation aka IP
>>> packet size again.
>>>
>>> Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
>>>
>>> ---
>>>
>>> include/configs/colibri_t30.h | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/include/configs/colibri_t30.h
>>> b/include/configs/colibri_t30.h
>>> index fbb235d..3431cde 100644
>>> --- a/include/configs/colibri_t30.h
>>> +++ b/include/configs/colibri_t30.h
>>> @@ -48,6 +48,7 @@
>>>
>>> /* General networking support */
>>> #define CONFIG_IP_DEFRAG
>>> +#define CONFIG_NET_MAXDEFRAG (16384 + 4096 + 24)
>>> #define CONFIG_TFTP_BLOCKSIZE 16384
>>> #define CONFIG_TFTP_TSIZE
>>>
>>>
>> Applied, thanks . If you need to rectify this further based on Joe's
>> feedback, please do, but I want this fixed before the release.
>
> Unfortunately the release already happened. Nevertheless I will send an
> updated version 2 ASAP which fixes all of our boards currently
> exhibiting this issue the way Joe suggested.
>
Please base that on top of u-boot-usb/master , I already applied V1 .
Me and Tom agreed this is not critical enough to wrap it into release.
--
Best regards,
Marek Vasut
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2016-09-14 15:18 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-09-10 2:20 [U-Boot] [PATCH] colibri_t30: fix usb ethernet functionality Marcel Ziswiler
2016-09-10 16:33 ` Joe Hershberger
2016-09-10 16:51 ` Marek Vasut
2016-09-14 14:36 ` Marcel Ziswiler
2016-09-14 15:18 ` Marek Vasut
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.