From: Joe Perches <joe@perches.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Guido Günther" <agx@sigxcpu.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Johan Hovold" <johan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging
Date: Thu, 04 Apr 2019 11:55:17 -0700 [thread overview]
Message-ID: <ab5f36952d2125f5ed9706aa58b64ab10fecf531.camel@perches.com> (raw)
In-Reply-To: <20190404170040.GA23897@ravnborg.org>
On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote:
> Hi Joe.
>
> On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote:
> > These were missing '\n' terminations, add them.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++---------
> > 1 file changed, 10 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > index 158a6d548068..d88ea8da2ec2 100644
> > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx)
> >
> > ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> > if (ret < 0) {
> > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode");
> > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n");
>
> I was under the impression that newlines was optional these days.
> Should we always use them with logging?
Yes.
The general problem is KERN_CONT/pr_cont uses where interleaving
is still possible from multiple threads.
> I did not find any obvious clues in linux/printk.h
I'll see about adding something one day to the Documentation.
Likely in coding-style.rst.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: "Guido Günther" <agx@sigxcpu.org>,
"Thierry Reding" <thierry.reding@gmail.com>,
"David Airlie" <airlied@linux.ie>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Rutland" <mark.rutland@arm.com>,
"Kevin Hilman" <khilman@baylibre.com>,
"Manivannan Sadhasivam" <manivannan.sadhasivam@linaro.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Jagan Teki" <jagan@amarulasolutions.com>,
"Martin Blumenstingl" <martin.blumenstingl@googlemail.com>,
"Johan Hovold" <johan@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Mauro Carvalho Chehab" <mchehab+samsung@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Nicolas Ferre" <nicolas.ferre@microchip.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.ke
Subject: Re: [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging
Date: Thu, 04 Apr 2019 11:55:17 -0700 [thread overview]
Message-ID: <ab5f36952d2125f5ed9706aa58b64ab10fecf531.camel@perches.com> (raw)
In-Reply-To: <20190404170040.GA23897@ravnborg.org>
On Thu, 2019-04-04 at 19:00 +0200, Sam Ravnborg wrote:
> Hi Joe.
>
> On Thu, Apr 04, 2019 at 08:06:09AM -0700, Joe Perches wrote:
> > These were missing '\n' terminations, add them.
> >
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> > drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c | 19 ++++++++++---------
> > 1 file changed, 10 insertions(+), 9 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > index 158a6d548068..d88ea8da2ec2 100644
> > --- a/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > +++ b/drivers/gpu/drm/panel/panel-rocktech-jh057n00900.c
> > @@ -123,7 +123,7 @@ static int jh057n_init_sequence(struct jh057n *ctx)
> >
> > ret = mipi_dsi_dcs_exit_sleep_mode(dsi);
> > if (ret < 0) {
> > - DRM_DEV_ERROR(dev, "Failed to exit sleep mode");
> > + DRM_DEV_ERROR(dev, "Failed to exit sleep mode\n");
>
> I was under the impression that newlines was optional these days.
> Should we always use them with logging?
Yes.
The general problem is KERN_CONT/pr_cont uses where interleaving
is still possible from multiple threads.
> I did not find any obvious clues in linux/printk.h
I'll see about adding something one day to the Documentation.
Likely in coding-style.rst.
next prev parent reply other threads:[~2019-04-04 18:55 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-01 10:35 [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Guido Günther
2019-04-01 10:35 ` [PATCH v5 1/3] dt-bindings: Add vendor prefix for ROCKTECH DISPLAYS LIMITED Guido Günther
2019-04-01 10:35 ` [PATCH v5 2/3] dt-bindings: Add Rocktech jh057n00900 panel bindings Guido Günther
2019-04-01 10:35 ` [PATCH v5 3/3] drm/panel: Add Rocktech jh057n00900 panel driver Guido Günther
2019-04-01 10:35 ` Guido Günther
2019-04-03 16:17 ` [PATCH v5 0/3] drm/panel: Support Rocktech jh057n00900 DSI panel Thierry Reding
2019-04-03 17:11 ` Joe Perches
2019-04-03 20:09 ` Joe Perches
2019-04-03 21:07 ` Sam Ravnborg
2019-04-03 21:07 ` Sam Ravnborg
2019-04-04 5:02 ` Joe Perches
2019-04-04 5:02 ` Joe Perches
2019-04-04 10:53 ` Guido Günther
2019-04-04 15:06 ` [PATCH] drm/panel: Rocktech jh057n00900: Add terminating newlines to logging Joe Perches
2019-04-04 15:48 ` Guido Günther
2019-04-04 16:19 ` Joe Perches
2019-04-04 17:09 ` Thierry Reding
2019-04-04 17:09 ` Thierry Reding
2019-04-04 17:00 ` Sam Ravnborg
2019-04-04 17:00 ` Sam Ravnborg
2019-04-04 18:55 ` Joe Perches [this message]
2019-04-04 18:55 ` Joe Perches
2019-04-04 19:08 ` Sam Ravnborg
2019-04-04 19:08 ` Sam Ravnborg
2019-04-04 17:08 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ab5f36952d2125f5ed9706aa58b64ab10fecf531.camel@perches.com \
--to=joe@perches.com \
--cc=agx@sigxcpu.org \
--cc=airlied@linux.ie \
--cc=daniel@ffwll.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=jagan@amarulasolutions.com \
--cc=johan@kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-kernel@vger.kernel.org \
--cc=manivannan.sadhasivam@linaro.org \
--cc=mark.rutland@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab+samsung@kernel.org \
--cc=nicolas.ferre@microchip.com \
--cc=robh+dt@kernel.org \
--cc=sam@ravnborg.org \
--cc=shawnguo@kernel.org \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.